From: Matthias Brugger <matthias.bgg@gmail.com> To: Eddie Huang <eddie.huang@mediatek.com>, Andrew Morton <akpm@linux-foundation.org> Cc: rtc-linux@googlegroups.com, Alessandro Zummo <a.zummo@towertech.it>, srv_heupstream@mediatek.com, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Grant Likely <grant.likely@linaro.org>, Tianping Fang <tianping.fang@mediatek.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer <kernel@pengutronix.de>, yh.chen@mediatek.com, yingjoe.chen@mediatek.com, linux-mediatek@lists.infradead.org Subject: Re: [rtc-linux] [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver Date: Fri, 13 Mar 2015 12:19:36 +0100 [thread overview] Message-ID: <5502C7C8.1020002@gmail.com> (raw) In-Reply-To: <1426242563.18291.19.camel@mtksdaap41> On 13/03/15 11:29, Eddie Huang wrote: > > I encounter some trouble when I add code to check return value of > regmap_read and regmap_write. Every RTC register access through regmap, > and there are many register read/write in this driver. If I check every > return value, the driver will become ugly. I try to make this driver > clean using following macro. > > static int __rtc_read(struct mt6397_rtc *rtc, u32 offset, u32 *data) > { > u32 addr = rtc->addr_base + offset; > > if (offset < rtc->addr_range) > return regmap_read(rtc->regmap, addr, data); > > return -EINVAL; > } > > #define rtc_read(ret, rtc, offset, data) \ > ({ \ > ret = __rtc_read(rtc, offset, data); \ > if (ret < 0) \ > goto rtc_exit; \ > }) \ > I agree with Sascha on hiding a goto statement in a macro is not a good idea. > > And function call rtc_read, rtc_write looks like: > > static int mtk_rtc_read_time(struct device *dev, struct rtc_time *tm) > { > unsigned long time; > struct mt6397_rtc *rtc = dev_get_drvdata(dev); > int ret = 0; > u32 sec; > > mutex_lock(&rtc->lock); > do { > rtc_read(ret, rtc, RTC_TC_SEC, &tm->tm_sec); > rtc_read(ret, rtc, RTC_TC_MIN, &tm->tm_min); > rtc_read(ret, rtc, RTC_TC_HOU, &tm->tm_hour); > rtc_read(ret, rtc, RTC_TC_DOM, &tm->tm_mday); > rtc_read(ret, rtc, RTC_TC_MTH, &tm->tm_mon); > rtc_read(ret, rtc, RTC_TC_YEA, &tm->tm_year); > rtc_read(ret, rtc, RTC_TC_SEC, &sec); > } while (sec < tm->tm_sec); What about introducing static int __mtk_rtc_read_time(struct mt6397_rtc *rtc, struct rtc_time *tm, u32 *sec) and hide the checks of return values from regmap_read and the offset check in there. You return the error code or 0. This way the while loop would look like this: do { ret = __mtk_rtc_read_time(rtc, &tm, &sec); if (ret < 0) goto rtc_exit; } while (sec < tm->tm_sec); Best regards, Matthias
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger) To: linux-arm-kernel@lists.infradead.org Subject: [rtc-linux] [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver Date: Fri, 13 Mar 2015 12:19:36 +0100 [thread overview] Message-ID: <5502C7C8.1020002@gmail.com> (raw) In-Reply-To: <1426242563.18291.19.camel@mtksdaap41> On 13/03/15 11:29, Eddie Huang wrote: > > I encounter some trouble when I add code to check return value of > regmap_read and regmap_write. Every RTC register access through regmap, > and there are many register read/write in this driver. If I check every > return value, the driver will become ugly. I try to make this driver > clean using following macro. > > static int __rtc_read(struct mt6397_rtc *rtc, u32 offset, u32 *data) > { > u32 addr = rtc->addr_base + offset; > > if (offset < rtc->addr_range) > return regmap_read(rtc->regmap, addr, data); > > return -EINVAL; > } > > #define rtc_read(ret, rtc, offset, data) \ > ({ \ > ret = __rtc_read(rtc, offset, data); \ > if (ret < 0) \ > goto rtc_exit; \ > }) \ > I agree with Sascha on hiding a goto statement in a macro is not a good idea. > > And function call rtc_read, rtc_write looks like: > > static int mtk_rtc_read_time(struct device *dev, struct rtc_time *tm) > { > unsigned long time; > struct mt6397_rtc *rtc = dev_get_drvdata(dev); > int ret = 0; > u32 sec; > > mutex_lock(&rtc->lock); > do { > rtc_read(ret, rtc, RTC_TC_SEC, &tm->tm_sec); > rtc_read(ret, rtc, RTC_TC_MIN, &tm->tm_min); > rtc_read(ret, rtc, RTC_TC_HOU, &tm->tm_hour); > rtc_read(ret, rtc, RTC_TC_DOM, &tm->tm_mday); > rtc_read(ret, rtc, RTC_TC_MTH, &tm->tm_mon); > rtc_read(ret, rtc, RTC_TC_YEA, &tm->tm_year); > rtc_read(ret, rtc, RTC_TC_SEC, &sec); > } while (sec < tm->tm_sec); What about introducing static int __mtk_rtc_read_time(struct mt6397_rtc *rtc, struct rtc_time *tm, u32 *sec) and hide the checks of return values from regmap_read and the offset check in there. You return the error code or 0. This way the while loop would look like this: do { ret = __mtk_rtc_read_time(rtc, &tm, &sec); if (ret < 0) goto rtc_exit; } while (sec < tm->tm_sec); Best regards, Matthias
next prev parent reply other threads:[~2015-03-13 11:19 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-28 9:27 [PATCH 0/2] Add Mediatek RTC driver Eddie Huang 2015-01-28 9:27 ` Eddie Huang 2015-01-28 9:27 ` [PATCH 1/2] dt: bindings: Add Mediatek RTC driver binding document Eddie Huang 2015-01-28 9:27 ` Eddie Huang 2015-01-28 9:27 ` [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver Eddie Huang 2015-01-28 9:27 ` Eddie Huang 2015-02-23 21:50 ` [rtc-linux] " Andrew Morton 2015-02-23 21:50 ` Andrew Morton 2015-02-23 21:50 ` Andrew Morton 2015-03-02 8:20 ` Eddie Huang 2015-03-02 8:20 ` Eddie Huang 2015-03-02 8:20 ` Eddie Huang 2015-03-02 19:35 ` Andrew Morton 2015-03-02 19:35 ` Andrew Morton 2015-03-02 19:35 ` Andrew Morton 2015-03-13 10:29 ` Eddie Huang 2015-03-13 10:29 ` Eddie Huang 2015-03-13 10:29 ` Eddie Huang 2015-03-13 10:57 ` Sascha Hauer 2015-03-13 10:57 ` Sascha Hauer 2015-03-13 10:57 ` Sascha Hauer 2015-03-16 9:52 ` Eddie Huang 2015-03-16 9:52 ` Eddie Huang 2015-03-16 9:52 ` Eddie Huang 2015-03-13 11:19 ` Matthias Brugger [this message] 2015-03-13 11:19 ` Matthias Brugger 2015-03-16 15:30 ` Uwe Kleine-König 2015-03-16 15:30 ` Uwe Kleine-König 2015-03-17 12:31 ` Eddie Huang 2015-03-17 12:31 ` Eddie Huang 2015-03-17 12:31 ` Eddie Huang 2015-03-17 13:43 ` Uwe Kleine-König 2015-03-17 13:43 ` Uwe Kleine-König 2015-03-17 13:43 ` Uwe Kleine-König 2015-03-18 3:27 ` Eddie Huang 2015-03-18 3:27 ` Eddie Huang 2015-03-18 3:27 ` Eddie Huang 2015-03-18 7:42 ` Uwe Kleine-König 2015-03-18 7:42 ` Uwe Kleine-König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5502C7C8.1020002@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=a.zummo@towertech.it \ --cc=akpm@linux-foundation.org \ --cc=devicetree@vger.kernel.org \ --cc=eddie.huang@mediatek.com \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=rtc-linux@googlegroups.com \ --cc=srv_heupstream@mediatek.com \ --cc=tianping.fang@mediatek.com \ --cc=yh.chen@mediatek.com \ --cc=yingjoe.chen@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.