* [Buildroot] [PATCH 1/1] package/wpa_supplicant: Enable support for log to debug file
@ 2015-03-12 22:00 Jörg Krause
2015-03-13 22:08 ` Gustavo Zacarias
0 siblings, 1 reply; 4+ messages in thread
From: Jörg Krause @ 2015-03-12 22:00 UTC (permalink / raw)
To: buildroot
Enables the '-f' option (log output to debug file instead of stdout) for
wpa_supplicant.
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
package/wpa_supplicant/Config.in | 5 +++++
package/wpa_supplicant/wpa_supplicant.mk | 4 ++++
2 files changed, 9 insertions(+)
diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
index f32a867..7c213a2 100644
--- a/package/wpa_supplicant/Config.in
+++ b/package/wpa_supplicant/Config.in
@@ -32,6 +32,11 @@ config BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_SYSLOG
help
Enable support for sending debug messages to syslog.
+config BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_FILE
+ bool "Enable log output to debug file"
+ help
+ Enable support for log output to debug file instead of stdout.
+
config BR2_PACKAGE_WPA_SUPPLICANT_WPS
bool "Enable WPS"
help
diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index 682cb4c..4f9dff0 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -107,6 +107,10 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_SYSLOG),y)
WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_DEBUG_SYSLOG
endif
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_SYSLOG),y)
+ WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_DEBUG_FILE
+endif
+
ifeq ($(BR2_PACKAGE_READLINE),y)
WPA_SUPPLICANT_DEPENDENCIES += readline
WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE
--
2.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpa_supplicant: Enable support for log to debug file
2015-03-12 22:00 [Buildroot] [PATCH 1/1] package/wpa_supplicant: Enable support for log to debug file Jörg Krause
@ 2015-03-13 22:08 ` Gustavo Zacarias
2015-03-17 21:30 ` Jörg Krause
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Zacarias @ 2015-03-13 22:08 UTC (permalink / raw)
To: buildroot
On 03/12/2015 07:00 PM, J?rg Krause wrote:
> Enables the '-f' option (log output to debug file instead of stdout) for
> wpa_supplicant.
Just force enable it, binary size +8 bytes for an ARM target, it doesn't
make sense to make it an option (specially since it must be used and
doesn't affect anything by default).
Regards.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpa_supplicant: Enable support for log to debug file
2015-03-13 22:08 ` Gustavo Zacarias
@ 2015-03-17 21:30 ` Jörg Krause
2015-03-17 21:32 ` Gustavo Zacarias
0 siblings, 1 reply; 4+ messages in thread
From: Jörg Krause @ 2015-03-17 21:30 UTC (permalink / raw)
To: buildroot
On Fr, 2015-03-13 at 19:08 -0300, Gustavo Zacarias wrote:
> On 03/12/2015 07:00 PM, J?rg Krause wrote:
>
> > Enables the '-f' option (log output to debug file instead of stdout) for
> > wpa_supplicant.
>
> Just force enable it, binary size +8 bytes for an ARM target, it doesn't
> make sense to make it an option (specially since it must be used and
> doesn't affect anything by default).
> Regards.
>
Sorry, there is an error in the patch:
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_SYSLOG),y)
+ WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_DEBUG_FILE
+endif
Should be of course:
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_DEBUG_FILE),y)
+ WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_DEBUG_FILE
+endif
For me it's +963 bytes. Force enable it anyway?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpa_supplicant: Enable support for log to debug file
2015-03-17 21:30 ` Jörg Krause
@ 2015-03-17 21:32 ` Gustavo Zacarias
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2015-03-17 21:32 UTC (permalink / raw)
To: buildroot
On 03/17/2015 06:30 PM, J?rg Krause wrote:
> For me it's +963 bytes. Force enable it anyway?
Yes, it's still negligible and the user must use the option in order for
wpa_supplicant to do anything different than what it did before it was
enabled.
Regards.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-17 21:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 22:00 [Buildroot] [PATCH 1/1] package/wpa_supplicant: Enable support for log to debug file Jörg Krause
2015-03-13 22:08 ` Gustavo Zacarias
2015-03-17 21:30 ` Jörg Krause
2015-03-17 21:32 ` Gustavo Zacarias
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.