All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nicholas Mc Guire <hofrat@osadl.org>, Tony Lindgren <tony@atomide.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: twl6040: match wait_for_completion_timeout return type
Date: Mon, 16 Mar 2015 12:48:54 +0200	[thread overview]
Message-ID: <5506B516.9070206@ti.com> (raw)
In-Reply-To: <1426493822-10331-1-git-send-email-hofrat@osadl.org>

On 03/16/2015 10:17 AM, Nicholas Mc Guire wrote:
> Return type of wait_for_completion_timeout is unsigned long not int. As
> time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> Patch was compile tested with x86_64_defconfig + CONFIG_TWL6040_CORE=y
> 
> Patch is against 4.0-rc3 (localversion-next is -next-20150316)
> 
>  drivers/mfd/twl6040.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index f71ee3d..d6f9761 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -259,7 +259,7 @@ static irqreturn_t twl6040_thint_handler(int irq, void *data)
>  
>  static int twl6040_power_up_automatic(struct twl6040 *twl6040)
>  {
> -	int time_left;
> +	unsigned long time_left;
>  
>  	gpio_set_value(twl6040->audpwron, 1);
>  
> 


-- 
Péter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nicholas Mc Guire <hofrat@osadl.org>, Tony Lindgren <tony@atomide.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: twl6040: match wait_for_completion_timeout return type
Date: Mon, 16 Mar 2015 12:48:54 +0200	[thread overview]
Message-ID: <5506B516.9070206@ti.com> (raw)
In-Reply-To: <1426493822-10331-1-git-send-email-hofrat@osadl.org>

On 03/16/2015 10:17 AM, Nicholas Mc Guire wrote:
> Return type of wait_for_completion_timeout is unsigned long not int. As
> time_left is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> Patch was compile tested with x86_64_defconfig + CONFIG_TWL6040_CORE=y
> 
> Patch is against 4.0-rc3 (localversion-next is -next-20150316)
> 
>  drivers/mfd/twl6040.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c
> index f71ee3d..d6f9761 100644
> --- a/drivers/mfd/twl6040.c
> +++ b/drivers/mfd/twl6040.c
> @@ -259,7 +259,7 @@ static irqreturn_t twl6040_thint_handler(int irq, void *data)
>  
>  static int twl6040_power_up_automatic(struct twl6040 *twl6040)
>  {
> -	int time_left;
> +	unsigned long time_left;
>  
>  	gpio_set_value(twl6040->audpwron, 1);
>  
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-03-16 10:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16  8:17 [PATCH] mfd: twl6040: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-03-16 10:48 ` Peter Ujfalusi [this message]
2015-03-16 10:48   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5506B516.9070206@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=hofrat@osadl.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.