All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Alex Hung <alex.hung@canonical.com>
Cc: Len Brown <lenb@kernel.org>,
	Linux ACPI Mailing List <linux-acpi@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
Date: Tue, 17 Mar 2015 11:01:55 +0800	[thread overview]
Message-ID: <55079923.8050400@intel.com> (raw)
In-Reply-To: <5045126.GmAGs977fU@vostro.rjw.lan>

Hi Alex,

On 03/17/2015 10:31 AM, Rafael J. Wysocki wrote:
> On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote:
>> Rafael,
>>
>> Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails.

Is it the hotkey broken with Win8 OSI or the acpi_video interface?
If it is just the interface, then you can add the system into the dmi
table in drivers/acpi/video.c with video_disable_native_backlight as
the DMI callback function.

Thanks,
Aaron

>>
>> We have some cases that needs working acpi_video interfaces. I'd also
>> like to backport to previous kernels that has not use native backlight
> 
> If backlight is the only reason, we don't add machines to blacklist.c any
> more.
> 
> 
>> On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>> On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote:
>>>> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
>>>> to insufficient documentation for the driver implementation, blacklist
>>>> it as a workaround.
>>>
>>> I gather that the native backlight interface doesn't work on those systems too,
>>> is that correct?
>>>
>>>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>>>> ---
>>>>  drivers/acpi/blacklist.c |   12 ++++++++++++
>>>>  1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
>>>> index 9b693d5..98aa360 100644
>>>> --- a/drivers/acpi/blacklist.c
>>>> +++ b/drivers/acpi/blacklist.c
>>>> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>>>>       },
>>>>
>>>>       /*
>>>> +      * The brightness hotkeys do not work on those machines when
>>>> +      * returning true for _OSI("Windows 2012")
>>>> +      */
>>>> +     {
>>>> +     .callback = dmi_disable_osi_win8,
>>>> +     .ident = "HP Pavilion dv6",
>>>> +     .matches = {
>>>> +                 DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>>>> +                 DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
>>>> +             },
>>>> +     },
>>>> +     /*
>>>>        * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
>>>>        * Linux ignores it, except for the machines enumerated below.
>>>>        */
>>>>
>>>
> 


  reply	other threads:[~2015-03-17  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  6:39 [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6 Alex Hung
2015-03-10 22:20 ` Rafael J. Wysocki
2015-03-14 12:46   ` Alex Hung
2015-03-17  2:31     ` Rafael J. Wysocki
2015-03-17  3:01       ` Aaron Lu [this message]
2015-03-17  6:14         ` Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55079923.8050400@intel.com \
    --to=aaron.lu@intel.com \
    --cc=alex.hung@canonical.com \
    --cc=hdegoede@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.