* [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
@ 2015-03-03 6:39 Alex Hung
2015-03-10 22:20 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Alex Hung @ 2015-03-03 6:39 UTC (permalink / raw)
To: lenb, rjw, linux-acpi, alex.hung
The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
to insufficient documentation for the driver implementation, blacklist
it as a workaround.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
drivers/acpi/blacklist.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 9b693d5..98aa360 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
},
/*
+ * The brightness hotkeys do not work on those machines when
+ * returning true for _OSI("Windows 2012")
+ */
+ {
+ .callback = dmi_disable_osi_win8,
+ .ident = "HP Pavilion dv6",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
+ },
+ },
+ /*
* BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
* Linux ignores it, except for the machines enumerated below.
*/
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
2015-03-03 6:39 [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6 Alex Hung
@ 2015-03-10 22:20 ` Rafael J. Wysocki
2015-03-14 12:46 ` Alex Hung
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-03-10 22:20 UTC (permalink / raw)
To: Alex Hung; +Cc: lenb, linux-acpi
On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote:
> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
> to insufficient documentation for the driver implementation, blacklist
> it as a workaround.
I gather that the native backlight interface doesn't work on those systems too,
is that correct?
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> drivers/acpi/blacklist.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index 9b693d5..98aa360 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
> },
>
> /*
> + * The brightness hotkeys do not work on those machines when
> + * returning true for _OSI("Windows 2012")
> + */
> + {
> + .callback = dmi_disable_osi_win8,
> + .ident = "HP Pavilion dv6",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
> + },
> + },
> + /*
> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
> * Linux ignores it, except for the machines enumerated below.
> */
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
2015-03-10 22:20 ` Rafael J. Wysocki
@ 2015-03-14 12:46 ` Alex Hung
2015-03-17 2:31 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Alex Hung @ 2015-03-14 12:46 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, Linux ACPI Mailing List
Rafael,
Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails.
We have some cases that needs working acpi_video interfaces. I'd also
like to backport to previous kernels that has not use native backlight
by default
Cheers,
Alex Hung
On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote:
>> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
>> to insufficient documentation for the driver implementation, blacklist
>> it as a workaround.
>
> I gather that the native backlight interface doesn't work on those systems too,
> is that correct?
>
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>> drivers/acpi/blacklist.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
>> index 9b693d5..98aa360 100644
>> --- a/drivers/acpi/blacklist.c
>> +++ b/drivers/acpi/blacklist.c
>> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>> },
>>
>> /*
>> + * The brightness hotkeys do not work on those machines when
>> + * returning true for _OSI("Windows 2012")
>> + */
>> + {
>> + .callback = dmi_disable_osi_win8,
>> + .ident = "HP Pavilion dv6",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
>> + },
>> + },
>> + /*
>> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
>> * Linux ignores it, except for the machines enumerated below.
>> */
>>
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
Cheers,
Alex Hung
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
2015-03-14 12:46 ` Alex Hung
@ 2015-03-17 2:31 ` Rafael J. Wysocki
2015-03-17 3:01 ` Aaron Lu
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2015-03-17 2:31 UTC (permalink / raw)
To: Alex Hung; +Cc: Len Brown, Linux ACPI Mailing List, Hans de Goede, Aaron Lu
On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote:
> Rafael,
>
> Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails.
>
> We have some cases that needs working acpi_video interfaces. I'd also
> like to backport to previous kernels that has not use native backlight
If backlight is the only reason, we don't add machines to blacklist.c any
more.
> On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote:
> >> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
> >> to insufficient documentation for the driver implementation, blacklist
> >> it as a workaround.
> >
> > I gather that the native backlight interface doesn't work on those systems too,
> > is that correct?
> >
> >> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> >> ---
> >> drivers/acpi/blacklist.c | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> >> index 9b693d5..98aa360 100644
> >> --- a/drivers/acpi/blacklist.c
> >> +++ b/drivers/acpi/blacklist.c
> >> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
> >> },
> >>
> >> /*
> >> + * The brightness hotkeys do not work on those machines when
> >> + * returning true for _OSI("Windows 2012")
> >> + */
> >> + {
> >> + .callback = dmi_disable_osi_win8,
> >> + .ident = "HP Pavilion dv6",
> >> + .matches = {
> >> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> >> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
> >> + },
> >> + },
> >> + /*
> >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
> >> * Linux ignores it, except for the machines enumerated below.
> >> */
> >>
> >
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
2015-03-17 2:31 ` Rafael J. Wysocki
@ 2015-03-17 3:01 ` Aaron Lu
2015-03-17 6:14 ` Alex Hung
0 siblings, 1 reply; 6+ messages in thread
From: Aaron Lu @ 2015-03-17 3:01 UTC (permalink / raw)
To: Rafael J. Wysocki, Alex Hung
Cc: Len Brown, Linux ACPI Mailing List, Hans de Goede
Hi Alex,
On 03/17/2015 10:31 AM, Rafael J. Wysocki wrote:
> On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote:
>> Rafael,
>>
>> Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails.
Is it the hotkey broken with Win8 OSI or the acpi_video interface?
If it is just the interface, then you can add the system into the dmi
table in drivers/acpi/video.c with video_disable_native_backlight as
the DMI callback function.
Thanks,
Aaron
>>
>> We have some cases that needs working acpi_video interfaces. I'd also
>> like to backport to previous kernels that has not use native backlight
>
> If backlight is the only reason, we don't add machines to blacklist.c any
> more.
>
>
>> On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>> On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote:
>>>> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
>>>> to insufficient documentation for the driver implementation, blacklist
>>>> it as a workaround.
>>>
>>> I gather that the native backlight interface doesn't work on those systems too,
>>> is that correct?
>>>
>>>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>>>> ---
>>>> drivers/acpi/blacklist.c | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
>>>> index 9b693d5..98aa360 100644
>>>> --- a/drivers/acpi/blacklist.c
>>>> +++ b/drivers/acpi/blacklist.c
>>>> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>>>> },
>>>>
>>>> /*
>>>> + * The brightness hotkeys do not work on those machines when
>>>> + * returning true for _OSI("Windows 2012")
>>>> + */
>>>> + {
>>>> + .callback = dmi_disable_osi_win8,
>>>> + .ident = "HP Pavilion dv6",
>>>> + .matches = {
>>>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
>>>> + },
>>>> + },
>>>> + /*
>>>> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
>>>> * Linux ignores it, except for the machines enumerated below.
>>>> */
>>>>
>>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6
2015-03-17 3:01 ` Aaron Lu
@ 2015-03-17 6:14 ` Alex Hung
0 siblings, 0 replies; 6+ messages in thread
From: Alex Hung @ 2015-03-17 6:14 UTC (permalink / raw)
To: Aaron Lu
Cc: Rafael J. Wysocki, Len Brown, Linux ACPI Mailing List, Hans de Goede
Rafael and Aaron,
Thanks for the comment. I will try drivers/acpi/video.c instead and
submit another patch.
Cheers,
Alex Hung
On Tue, Mar 17, 2015 at 11:01 AM, Aaron Lu <aaron.lu@intel.com> wrote:
> Hi Alex,
>
> On 03/17/2015 10:31 AM, Rafael J. Wysocki wrote:
>> On Saturday, March 14, 2015 08:46:25 PM Alex Hung wrote:
>>> Rafael,
>>>
>>> Do you mean /sys/class/backlight/intel_backlight? It works but acpi_video fails.
>
> Is it the hotkey broken with Win8 OSI or the acpi_video interface?
> If it is just the interface, then you can add the system into the dmi
> table in drivers/acpi/video.c with video_disable_native_backlight as
> the DMI callback function.
>
> Thanks,
> Aaron
>
>>>
>>> We have some cases that needs working acpi_video interfaces. I'd also
>>> like to backport to previous kernels that has not use native backlight
>>
>> If backlight is the only reason, we don't add machines to blacklist.c any
>> more.
>>
>>
>>> On Wed, Mar 11, 2015 at 6:20 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>>> On Tuesday, March 03, 2015 02:39:14 PM Alex Hung wrote:
>>>>> The brightness hotkeys of HP Pavilion dv6 does not work with Win8 OSI. Due
>>>>> to insufficient documentation for the driver implementation, blacklist
>>>>> it as a workaround.
>>>>
>>>> I gather that the native backlight interface doesn't work on those systems too,
>>>> is that correct?
>>>>
>>>>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>>>>> ---
>>>>> drivers/acpi/blacklist.c | 12 ++++++++++++
>>>>> 1 file changed, 12 insertions(+)
>>>>>
>>>>> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
>>>>> index 9b693d5..98aa360 100644
>>>>> --- a/drivers/acpi/blacklist.c
>>>>> +++ b/drivers/acpi/blacklist.c
>>>>> @@ -300,6 +300,18 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>>>>> },
>>>>>
>>>>> /*
>>>>> + * The brightness hotkeys do not work on those machines when
>>>>> + * returning true for _OSI("Windows 2012")
>>>>> + */
>>>>> + {
>>>>> + .callback = dmi_disable_osi_win8,
>>>>> + .ident = "HP Pavilion dv6",
>>>>> + .matches = {
>>>>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
>>>>> + },
>>>>> + },
>>>>> + /*
>>>>> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
>>>>> * Linux ignores it, except for the machines enumerated below.
>>>>> */
>>>>>
>>>>
>>
>
--
Cheers,
Alex Hung
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-17 6:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 6:39 [PATCH] ACPI / blacklist: blacklist Win8 OSI for HP Pavilion dv6 Alex Hung
2015-03-10 22:20 ` Rafael J. Wysocki
2015-03-14 12:46 ` Alex Hung
2015-03-17 2:31 ` Rafael J. Wysocki
2015-03-17 3:01 ` Aaron Lu
2015-03-17 6:14 ` Alex Hung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.