* [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
@ 2015-03-09 16:03 Mike Williams
2015-03-09 22:32 ` Thomas Petazzoni
2015-03-19 0:41 ` Arnout Vandecappelle
0 siblings, 2 replies; 6+ messages in thread
From: Mike Williams @ 2015-03-09 16:03 UTC (permalink / raw)
To: buildroot
Signed-off-by: Mike Williams <mike@mikebwilliams.com>
---
package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index 682cb4c..242bea5 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -164,4 +164,15 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
$(WPA_SUPPLICANT_INSTALL_DBUS)
endef
+define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
+ $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant.service \
+ $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant.service
+ $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant at .service \
+ $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant at .service
+ $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-nl80211 at .service \
+ $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-nl80211 at .service
+ $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-wired at .service \
+ $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired at .service
+endef
+
$(eval $(generic-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
2015-03-09 16:03 [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files Mike Williams
@ 2015-03-09 22:32 ` Thomas Petazzoni
2015-03-11 13:55 ` Mike Williams
2015-03-19 0:41 ` Arnout Vandecappelle
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-03-09 22:32 UTC (permalink / raw)
To: buildroot
Dear Mike Williams,
On Mon, 9 Mar 2015 12:03:31 -0400, Mike Williams wrote:
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 682cb4c..242bea5 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -164,4 +164,15 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
> $(WPA_SUPPLICANT_INSTALL_DBUS)
> endef
>
> +define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant.service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant.service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant at .service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-nl80211 at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-nl80211 at .service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-wired at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired at .service
> +endef
Could you please add the symlinks needed to make sure that these
services are started at boot by default?
I know this is not your opinion, but starting services by default is
what we do in basically all packages in Buildroot today, and therefore
something we should continue doing for consistency (and also because
we believe that's a sane default).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
2015-03-09 22:32 ` Thomas Petazzoni
@ 2015-03-11 13:55 ` Mike Williams
2015-03-11 14:49 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Mike Williams @ 2015-03-11 13:55 UTC (permalink / raw)
To: buildroot
Thomas,
On Mon, Mar 9, 2015 at 6:32 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Mike Williams,
>
> On Mon, 9 Mar 2015 12:03:31 -0400, Mike Williams wrote:
>
>> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
>> index 682cb4c..242bea5 100644
>> --- a/package/wpa_supplicant/wpa_supplicant.mk
>> +++ b/package/wpa_supplicant/wpa_supplicant.mk
>> @@ -164,4 +164,15 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
>> $(WPA_SUPPLICANT_INSTALL_DBUS)
>> endef
>>
>> +define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
>> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant.service \
>> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant.service
>> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant at .service \
>> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant at .service
>> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-nl80211 at .service \
>> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-nl80211 at .service
>> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-wired at .service \
>> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired at .service
>> +endef
>
> Could you please add the symlinks needed to make sure that these
> services are started at boot by default?
Yes, but it will take me a little while, maybe next week. Some of
these appear to be mutually exclusive, some of them require specific
configuration files for the interface or they will fail, and the
wpa_supplicant.service file needs to be modified depending on build
options set, etc. so it's not as simple as just enabling all of them.
>
> I know this is not your opinion, but starting services by default is
> what we do in basically all packages in Buildroot today, and therefore
> something we should continue doing for consistency (and also because
> we believe that's a sane default).
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
2015-03-11 13:55 ` Mike Williams
@ 2015-03-11 14:49 ` Thomas Petazzoni
2015-03-18 15:02 ` Mike Williams
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-03-11 14:49 UTC (permalink / raw)
To: buildroot
Dear Mike Williams,
On Wed, 11 Mar 2015 09:55:08 -0400, Mike Williams wrote:
> Yes, but it will take me a little while, maybe next week. Some of
> these appear to be mutually exclusive, some of them require specific
> configuration files for the interface or they will fail, and the
> wpa_supplicant.service file needs to be modified depending on build
> options set, etc. so it's not as simple as just enabling all of them.
Well, we had some discussion on IRC, and Arnout pointed out that
wpa_supplicant may be used for example by connman, and in this case,
you don't need to have the wpa_supplicant service started at boot.
So maybe in the end, what you propose is the good solution, and leave
it to the user to actually enable the service at boot if needed.
Arnout?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
2015-03-11 14:49 ` Thomas Petazzoni
@ 2015-03-18 15:02 ` Mike Williams
0 siblings, 0 replies; 6+ messages in thread
From: Mike Williams @ 2015-03-18 15:02 UTC (permalink / raw)
To: buildroot
Thomas,
On Wed, Mar 11, 2015 at 10:49 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Mike Williams,
>
> On Wed, 11 Mar 2015 09:55:08 -0400, Mike Williams wrote:
>
>> Yes, but it will take me a little while, maybe next week. Some of
>> these appear to be mutually exclusive, some of them require specific
>> configuration files for the interface or they will fail, and the
>> wpa_supplicant.service file needs to be modified depending on build
>> options set, etc. so it's not as simple as just enabling all of them.
>
> Well, we had some discussion on IRC, and Arnout pointed out that
> wpa_supplicant may be used for example by connman, and in this case,
> you don't need to have the wpa_supplicant service started at boot.
>
> So maybe in the end, what you propose is the good solution, and leave
> it to the user to actually enable the service at boot if needed.
>
> Arnout?
Did you guys ever decide what you want done here?
Thanks,
Mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
2015-03-09 16:03 [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files Mike Williams
2015-03-09 22:32 ` Thomas Petazzoni
@ 2015-03-19 0:41 ` Arnout Vandecappelle
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2015-03-19 0:41 UTC (permalink / raw)
To: buildroot
On 09/03/15 17:03, Mike Williams wrote:
> Signed-off-by: Mike Williams <mike@mikebwilliams.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
As discussed on IRC, adding symlinks to actually start those services is not
such a great idea because
- you probably don't want all of them;
- also other things are needed, like hostapd config and ifup wlan0;
- you may have something to manage these services, like network-manager or networkd.
Could be good to add that in a comment though.
Regards,
Arnout
> ---
> package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 682cb4c..242bea5 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -164,4 +164,15 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
> $(WPA_SUPPLICANT_INSTALL_DBUS)
> endef
>
> +define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant.service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant.service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant at .service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-nl80211 at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-nl80211 at .service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-wired at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired at .service
> +endef
> +
> $(eval $(generic-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-19 0:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-09 16:03 [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files Mike Williams
2015-03-09 22:32 ` Thomas Petazzoni
2015-03-11 13:55 ` Mike Williams
2015-03-11 14:49 ` Thomas Petazzoni
2015-03-18 15:02 ` Mike Williams
2015-03-19 0:41 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.