[review-request] bbarrosp/ui-fixes

[review-request] bbarrosp/ui-fixes

[belen barros pena]

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui-fixes

a8a5552ad7d3ba869f165ef4a392990263224428
bitbake: toasterui: hide right column if empty

cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
bitbake: toasterui: Improve messaging for empty layer details

09246f125cea1f8ff81081492824e14a3d38b02c
bitbake: toasterui: hide release when only one exists

a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
bitbake: toaster: update OpenEmbedded Toaster configuration

015fac8c6ef58218c8ad75d375907f13ac021548
bitbake: toaster: update Yocto Project Toaster configuration

Thanks,

Belén

Re: [review-request] bbarrosp/ui-fixes

[Michael Wood]

Looks good to me.

Thanks

Related comment (but not impacting on this review) - I've always found 
it weird that releases == git branches in toaster, that seems like an 
implementation detail to me, as in other projects a release could be a 
git tag or a tarball or a commit or any of the 100s of ways of 
distributing code.

On 22/03/15 20:17, belen barros pena wrote:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui-fixes
>
> a8a5552ad7d3ba869f165ef4a392990263224428
> bitbake: toasterui: hide right column if empty
>
> cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
> bitbake: toasterui: Improve messaging for empty layer details
>
> 09246f125cea1f8ff81081492824e14a3d38b02c
> bitbake: toasterui: hide release when only one exists
>
> a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
> bitbake: toaster: update OpenEmbedded Toaster configuration
>
> 015fac8c6ef58218c8ad75d375907f13ac021548
> bitbake: toaster: update Yocto Project Toaster configuration
>
> Thanks,
>
> Belén

Re: [review-request] bbarrosp/ui-fixes

[Barros Pena, Belen]

On 24/03/2015 11:29, "Michael Wood" <michael.g.wood@intel.com> wrote:

>Looks good to me.
>
>Thanks
>
>Related comment (but not impacting on this review) - I've always found
>it weird that releases == git branches in toaster, that seems like an
>implementation detail to me, as in other projects a release could be a
>git tag or a tarball or a commit or any of the 100s of ways of
>distributing code.

I didn't think this was the case. I was under the impression that a
release was a combination of a BitBake version and a OE metadata version.
What that version is set to (a branch, a git tag or a commit) should be
irrelevant (we should be supporting all 3, but not tarballs I think).

What makes you think that a release must be a git branch?

Cheers

Belén


>
>On 22/03/15 20:17, belen barros pena wrote:
>> 
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui
>>-fixes
>>
>> a8a5552ad7d3ba869f165ef4a392990263224428
>> bitbake: toasterui: hide right column if empty
>>
>> cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
>> bitbake: toasterui: Improve messaging for empty layer details
>>
>> 09246f125cea1f8ff81081492824e14a3d38b02c
>> bitbake: toasterui: hide release when only one exists
>>
>> a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
>> bitbake: toaster: update OpenEmbedded Toaster configuration
>>
>> 015fac8c6ef58218c8ad75d375907f13ac021548
>> bitbake: toaster: update Yocto Project Toaster configuration
>>
>> Thanks,
>>
>> Belén
>
>-- 
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster

Re: [review-request] bbarrosp/ui-fixes

[Michael Wood]

On 24/03/15 11:35, Barros Pena, Belen wrote:
>
> On 24/03/2015 11:29, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> Looks good to me.
>>
>> Thanks
>>
>> Related comment (but not impacting on this review) - I've always found
>> it weird that releases == git branches in toaster, that seems like an
>> implementation detail to me, as in other projects a release could be a
>> git tag or a tarball or a commit or any of the 100s of ways of
>> distributing code.
> I didn't think this was the case. I was under the impression that a
> release was a combination of a BitBake version and a OE metadata version.
> What that version is set to (a branch, a git tag or a commit) should be
> irrelevant (we should be supporting all 3, but not tarballs I think).
>
> What makes you think that a release must be a git branch?

The configuration for the release field names are "branch" and "up_branch"

(http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto/conf/toasterconf.json?#n62)

> Cheers
>
> Belén
>
>
>> On 22/03/15 20:17, belen barros pena wrote:
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui
>>> -fixes
>>>
>>> a8a5552ad7d3ba869f165ef4a392990263224428
>>> bitbake: toasterui: hide right column if empty
>>>
>>> cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
>>> bitbake: toasterui: Improve messaging for empty layer details
>>>
>>> 09246f125cea1f8ff81081492824e14a3d38b02c
>>> bitbake: toasterui: hide release when only one exists
>>>
>>> a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
>>> bitbake: toaster: update OpenEmbedded Toaster configuration
>>>
>>> 015fac8c6ef58218c8ad75d375907f13ac021548
>>> bitbake: toaster: update Yocto Project Toaster configuration
>>>
>>> Thanks,
>>>
>>> Belén
>> -- 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster

Re: [review-request] bbarrosp/ui-fixes

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 2585 bytes --]

On Tue, Mar 24, 2015 at 11:42 AM, Michael Wood <michael.g.wood@intel.com>
wrote:

> On 24/03/15 11:35, Barros Pena, Belen wrote:
>
>>
>> On 24/03/2015 11:29, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>
>>  Looks good to me.
>>>
>>> Thanks
>>>
>>> Related comment (but not impacting on this review) - I've always found
>>> it weird that releases == git branches in toaster, that seems like an
>>> implementation detail to me, as in other projects a release could be a
>>> git tag or a tarball or a commit or any of the 100s of ways of
>>> distributing code.
>>>
>> I didn't think this was the case. I was under the impression that a
>> release was a combination of a BitBake version and a OE metadata version.
>> What that version is set to (a branch, a git tag or a commit) should be
>> irrelevant (we should be supporting all 3, but not tarballs I think).
>>
>> What makes you think that a release must be a git branch?
>>
>
> The configuration for the release field names are "branch" and "up_branch"
>
>
​Call it lack of inspiration in naming fields :D

There is no direct relationship to the branches​ in git repos.

The indirect relationship is that YP does releases-as-branches; i.e. a
release is a branch in Poky.




> (http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-
> yocto/conf/toasterconf.json?#n62)
>
>
>  Cheers
>>
>> Belén
>>
>>
>>  On 22/03/15 20:17, belen barros pena wrote:
>>>
>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
>>>> log/?h=bbarrosp/ui
>>>> -fixes
>>>>
>>>> a8a5552ad7d3ba869f165ef4a392990263224428
>>>> bitbake: toasterui: hide right column if empty
>>>>
>>>> cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
>>>> bitbake: toasterui: Improve messaging for empty layer details
>>>>
>>>> 09246f125cea1f8ff81081492824e14a3d38b02c
>>>> bitbake: toasterui: hide release when only one exists
>>>>
>>>> a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
>>>> bitbake: toaster: update OpenEmbedded Toaster configuration
>>>>
>>>> 015fac8c6ef58218c8ad75d375907f13ac021548
>>>> bitbake: toaster: update Yocto Project Toaster configuration
>>>>
>>>> Thanks,
>>>>
>>>> Belén
>>>>
>>> --
>>> _______________________________________________
>>> toaster mailing list
>>> toaster@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster
>>>
>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 4834 bytes --]

Re: [review-request] bbarrosp/ui-fixes

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

All taken for submission,

Thank you,
Alex

On Sun, Mar 22, 2015 at 8:17 PM, belen barros pena <
belenbarrospena@gmail.com> wrote:

>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui-fixes
>
> a8a5552ad7d3ba869f165ef4a392990263224428
> bitbake: toasterui: hide right column if empty
>
> cf44f4dfe7a6dec273d77143dbe19eeab1ae23d5
> bitbake: toasterui: Improve messaging for empty layer details
>
> 09246f125cea1f8ff81081492824e14a3d38b02c
> bitbake: toasterui: hide release when only one exists
>
> a2ffbc6f186f7d7fb022c8bfcd5b01a1a3442bb6
> bitbake: toaster: update OpenEmbedded Toaster configuration
>
> 015fac8c6ef58218c8ad75d375907f13ac021548
> bitbake: toaster: update Yocto Project Toaster configuration
>
> Thanks,
>
> Belén
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1955 bytes --]

Re: [review-request] bbarrosp/ui-fixes

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

Taken for submission,

Thank you,
Alex

On Tue, Mar 3, 2015 at 10:05 AM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui-f
> ixes
>
> f93e462fcea8a84aa8dd3142d13782e513db674c
>
> bitbake: toaterui: shorten the unavailable artifact message
>
>
> ad2f860d7b5052b11d45e98bfcf4144affbd4e9e
>
> bitbake: toasterui: give some space to the download log button
>
>
> 1c39dc5f228a0a4f6f6b353147e5ad4b8922b9f7
>
> bitbake: toasterui: apply correct class to latest builds targets
>
>
> 3fd590c1a5508012c991d9ff9b70076bd3d0bbd8
>
> bitbake: toasterui: fix the h1 in the project builds page
>
>
> 4c0542c62547f8b0f032649c663f40e6ec9bfbbc
>
> bitbake: toasterui: don't open layer details in a new tab
>
>
> Thanks
>
> Belén
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 2047 bytes --]

[review-request] bbarrosp/ui-fixes

[Barros Pena, Belen]

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=bbarrosp/ui-f
ixes

f93e462fcea8a84aa8dd3142d13782e513db674c

bitbake: toaterui: shorten the unavailable artifact message


ad2f860d7b5052b11d45e98bfcf4144affbd4e9e

bitbake: toasterui: give some space to the download log button


1c39dc5f228a0a4f6f6b353147e5ad4b8922b9f7

bitbake: toasterui: apply correct class to latest builds targets


3fd590c1a5508012c991d9ff9b70076bd3d0bbd8

bitbake: toasterui: fix the h1 in the project builds page


4c0542c62547f8b0f032649c663f40e6ec9bfbbc

bitbake: toasterui: don't open layer details in a new tab


Thanks

Belén