All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: Add ABI documentation for out_voltage scan_elements
@ 2015-03-17 10:36 Haneen Mohammed
  2015-03-21 12:00 ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Haneen Mohammed @ 2015-03-17 10:36 UTC (permalink / raw)
  To: outreachy-kernel, linux-iio, jic23, daniel.baluta; +Cc: Haneen Mohammed

This patch adds ABI documentation entries for out_voltageY_en,
out_voltageY_type, and out_voltageY_index.
At least one user for these is preset:
AD8366 SPI Dual-Digital VGA.

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
 Documentation/ABI/testing/sysfs-bus-iio | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index fd026d9..bbb0bfd 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -994,6 +994,7 @@ What:		/sys/.../iio:deviceX/scan_elements/in_timestamp_en
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_en
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY-voltageZ_en
+What:		/sys/.../iio:deviceX/scan_elements/out_voltageY_en
 What:		/sys/.../iio:deviceX/scan_elements/in_incli_x_en
 What:		/sys/.../iio:deviceX/scan_elements/in_incli_y_en
 What:		/sys/.../iio:deviceX/scan_elements/in_pressureY_en
@@ -1011,6 +1012,7 @@ What:		/sys/.../iio:deviceX/scan_elements/in_magn_type
 What:		/sys/.../iio:deviceX/scan_elements/in_incli_type
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_type
 What:		/sys/.../iio:deviceX/scan_elements/in_voltage_type
+What:		/sys/.../iio:deviceX/scan_elements/out_voltageY_type
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_supply_type
 What:		/sys/.../iio:deviceX/scan_elements/in_timestamp_type
 What:		/sys/.../iio:deviceX/scan_elements/in_pressureY_type
@@ -1049,6 +1051,7 @@ Description:
 
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_index
 What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_supply_index
+What:		/sys/.../iio:deviceX/scan_elements/out_voltageY_index
 What:		/sys/.../iio:deviceX/scan_elements/in_accel_x_index
 What:		/sys/.../iio:deviceX/scan_elements/in_accel_y_index
 What:		/sys/.../iio:deviceX/scan_elements/in_accel_z_index
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] iio: Add ABI documentation for out_voltage scan_elements
  2015-03-17 10:36 [PATCH] iio: Add ABI documentation for out_voltage scan_elements Haneen Mohammed
@ 2015-03-21 12:00 ` Jonathan Cameron
  2015-03-24 12:30   ` Lars-Peter Clausen
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2015-03-21 12:00 UTC (permalink / raw)
  To: Haneen Mohammed, outreachy-kernel, linux-iio, daniel.baluta,
	Lars-Peter Clausen

On 17/03/15 10:36, Haneen Mohammed wrote:
> This patch adds ABI documentation entries for out_voltageY_en,
> out_voltageY_type, and out_voltageY_index.
> At least one user for these is preset:
> AD8366 SPI Dual-Digital VGA.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
These aren't used in the mainline driver.  We don't have buffered support
for output channels yet.  Looking at Analog's tree I don't think they have
support for this driver doing buffered output either (I think they may have
some internal support or maybe it's just a plan on how to do it!)
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index fd026d9..bbb0bfd 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -994,6 +994,7 @@ What:		/sys/.../iio:deviceX/scan_elements/in_timestamp_en
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_en
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY-voltageZ_en
> +What:		/sys/.../iio:deviceX/scan_elements/out_voltageY_en
>  What:		/sys/.../iio:deviceX/scan_elements/in_incli_x_en
>  What:		/sys/.../iio:deviceX/scan_elements/in_incli_y_en
>  What:		/sys/.../iio:deviceX/scan_elements/in_pressureY_en
> @@ -1011,6 +1012,7 @@ What:		/sys/.../iio:deviceX/scan_elements/in_magn_type
>  What:		/sys/.../iio:deviceX/scan_elements/in_incli_type
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_type
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltage_type
> +What:		/sys/.../iio:deviceX/scan_elements/out_voltageY_type
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_supply_type
>  What:		/sys/.../iio:deviceX/scan_elements/in_timestamp_type
>  What:		/sys/.../iio:deviceX/scan_elements/in_pressureY_type
> @@ -1049,6 +1051,7 @@ Description:
>  
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_index
>  What:		/sys/.../iio:deviceX/scan_elements/in_voltageY_supply_index
> +What:		/sys/.../iio:deviceX/scan_elements/out_voltageY_index
>  What:		/sys/.../iio:deviceX/scan_elements/in_accel_x_index
>  What:		/sys/.../iio:deviceX/scan_elements/in_accel_y_index
>  What:		/sys/.../iio:deviceX/scan_elements/in_accel_z_index
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] iio: Add ABI documentation for out_voltage scan_elements
  2015-03-21 12:00 ` Jonathan Cameron
@ 2015-03-24 12:30   ` Lars-Peter Clausen
  2015-03-27 22:10     ` Haneen
  0 siblings, 1 reply; 4+ messages in thread
From: Lars-Peter Clausen @ 2015-03-24 12:30 UTC (permalink / raw)
  To: Jonathan Cameron, Haneen Mohammed, outreachy-kernel, linux-iio,
	daniel.baluta

On 03/21/2015 01:00 PM, Jonathan Cameron wrote:
> On 17/03/15 10:36, Haneen Mohammed wrote:
>> This patch adds ABI documentation entries for out_voltageY_en,
>> out_voltageY_type, and out_voltageY_index.
>> At least one user for these is preset:
>> AD8366 SPI Dual-Digital VGA.
>>
>> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> These aren't used in the mainline driver.  We don't have buffered support
> for output channels yet.  Looking at Analog's tree I don't think they have
> support for this driver doing buffered output either (I think they may have
> some internal support or maybe it's just a plan on how to do it!)

We do have support for output buffers in our tree, but obviously not for a 
VGA. I think we should add the upstream documentation for these attributes 
at the same time we add the infrastructure support.

- Lars


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] iio: Add ABI documentation for out_voltage scan_elements
  2015-03-24 12:30   ` Lars-Peter Clausen
@ 2015-03-27 22:10     ` Haneen
  0 siblings, 0 replies; 4+ messages in thread
From: Haneen @ 2015-03-27 22:10 UTC (permalink / raw)
  To: jic23, daniel.baluta; +Cc: linux-iio, lars

On Tue, Mar 24, 2015 at 01:30:24PM +0100, Lars-Peter Clausen wrote:
> On 03/21/2015 01:00 PM, Jonathan Cameron wrote:
> >On 17/03/15 10:36, Haneen Mohammed wrote:
> >>This patch adds ABI documentation entries for out_voltageY_en,
> >>out_voltageY_type, and out_voltageY_index.
> >>At least one user for these is preset:
> >>AD8366 SPI Dual-Digital VGA.
> >>
> >>Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> >These aren't used in the mainline driver.  We don't have buffered support
> >for output channels yet.  Looking at Analog's tree I don't think they have
> >support for this driver doing buffered output either (I think they may have
> >some internal support or maybe it's just a plan on how to do it!)
> 
> We do have support for output buffers in our tree, but obviously not
> for a VGA. I think we should add the upstream documentation for
> these attributes at the same time we add the infrastructure support.
> 
> - Lars

Sorry my bad. I used the iio dummy to check that out, and I didn't
know I had to specify no buffer support through the scan_index since
the driver I checked didn't have that. I will be more carefull next
time!

Haneen

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-27 22:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-17 10:36 [PATCH] iio: Add ABI documentation for out_voltage scan_elements Haneen Mohammed
2015-03-21 12:00 ` Jonathan Cameron
2015-03-24 12:30   ` Lars-Peter Clausen
2015-03-27 22:10     ` Haneen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.