All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
	gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: Add overrun handling of SCIFA and SCIFB
Date: Wed, 25 Mar 2015 11:57:25 +0000	[thread overview]
Message-ID: <5512A2A5.7040406@cogentembedded.com> (raw)
In-Reply-To: <1427266818-10985-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hello.

On 3/25/2015 10:00 AM, Nobuhiro Iwamatsu wrote:

> SCIFA and SCIFB can detect the overrun, but it does not support.

    s/it/the driver/.

> This adds overrun handling of SCIFA and SCIFB.

    s/of/for/.

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>   drivers/tty/serial/sh-sci.c | 33 +++++++++++++++++++++++----------
>   1 file changed, 23 insertions(+), 10 deletions(-)

> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 5b50c79..0a78e1d 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
[...]
> @@ -1005,7 +1017,10 @@ static irqreturn_t sci_mpxed_interrupt(int irq, void *ptr)
>   	ssr_status = serial_port_in(port, SCxSR);
>   	scr_status = serial_port_in(port, SCSCR);
>   	if (port->type = PORT_SCIF || port->type = PORT_HSCIF)
> -		slr_status = serial_port_in(port, SCLSR);
> +		orer_status = serial_port_in(port, SCLSR);
> +	else if (port->type = PORT_SCIFA || port->type = PORT_SCIFB)
> +		orer_status = ssr_status;
> +

    I think the above *if*'s are asking to be *switch* statement instead.

[...]

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
	gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: Add overrun handling of SCIFA and SCIFB
Date: Wed, 25 Mar 2015 14:57:25 +0300	[thread overview]
Message-ID: <5512A2A5.7040406@cogentembedded.com> (raw)
In-Reply-To: <1427266818-10985-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hello.

On 3/25/2015 10:00 AM, Nobuhiro Iwamatsu wrote:

> SCIFA and SCIFB can detect the overrun, but it does not support.

    s/it/the driver/.

> This adds overrun handling of SCIFA and SCIFB.

    s/of/for/.

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>   drivers/tty/serial/sh-sci.c | 33 +++++++++++++++++++++++----------
>   1 file changed, 23 insertions(+), 10 deletions(-)

> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 5b50c79..0a78e1d 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
[...]
> @@ -1005,7 +1017,10 @@ static irqreturn_t sci_mpxed_interrupt(int irq, void *ptr)
>   	ssr_status = serial_port_in(port, SCxSR);
>   	scr_status = serial_port_in(port, SCSCR);
>   	if (port->type == PORT_SCIF || port->type == PORT_HSCIF)
> -		slr_status = serial_port_in(port, SCLSR);
> +		orer_status = serial_port_in(port, SCLSR);
> +	else if (port->type == PORT_SCIFA || port->type == PORT_SCIFB)
> +		orer_status = ssr_status;
> +

    I think the above *if*'s are asking to be *switch* statement instead.

[...]

WBR, Sergei


  reply	other threads:[~2015-03-25 11:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25  7:00 [PATCH] serial: sh-sci: Add overrun handling of SCIFA and SCIFB Nobuhiro Iwamatsu
2015-03-25  7:00 ` Nobuhiro Iwamatsu
2015-03-25 11:57 ` Sergei Shtylyov [this message]
2015-03-25 11:57   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5512A2A5.7040406@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=nobuhiro.iwamatsu.yj@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.