* [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-25 17:43 ` Ioan Nicu
0 siblings, 0 replies; 9+ messages in thread
From: Ioan Nicu @ 2015-03-25 17:43 UTC (permalink / raw)
To: Peter Korsgaard, Wolfram Sang, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Alexander Sverdlin, Mathias Rulf
Probe deferral is not an error case. It happens only when
the necessary dependencies are not there yet.
The driver core is already printing a message when a driver
requests probe deferral, so this can be traced in the logs
without these error prints.
This patch changes the error messages from these deferral cases
to debug messages.
Signed-off-by: Ionut Nicu <ioan.nicu.ext-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
---
drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index f5798eb..9f1cfca 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
}
adapter = of_find_i2c_adapter_by_node(adapter_np);
if (!adapter) {
- dev_err(&pdev->dev, "Cannot find parent bus\n");
+ dev_dbg(&pdev->dev, "Cannot find parent bus\n");
return -EPROBE_DEFER;
}
mux->data.parent = i2c_adapter_id(adapter);
@@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
parent = i2c_get_adapter(mux->data.parent);
if (!parent) {
- dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
+ dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
mux->data.parent);
return -EPROBE_DEFER;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-25 19:48 ` Peter Korsgaard
0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2015-03-25 19:48 UTC (permalink / raw)
To: Ioan Nicu
Cc: Wolfram Sang, linux-i2c, linux-kernel, Alexander Sverdlin, Mathias Rulf
>>>>> "IN" == Ioan Nicu <ioan.nicu.ext@nsn.com> writes:
IN> Probe deferral is not an error case. It happens only when
IN> the necessary dependencies are not there yet.
IN> The driver core is already printing a message when a driver
IN> requests probe deferral, so this can be traced in the logs
IN> without these error prints.
IN> This patch changes the error messages from these deferral cases
IN> to debug messages.
IN> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-25 19:48 ` Peter Korsgaard
0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2015-03-25 19:48 UTC (permalink / raw)
To: Ioan Nicu
Cc: Wolfram Sang, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Alexander Sverdlin,
Mathias Rulf
>>>>> "IN" == Ioan Nicu <ioan.nicu.ext-OYasijW0DpE@public.gmane.org> writes:
IN> Probe deferral is not an error case. It happens only when
IN> the necessary dependencies are not there yet.
IN> The driver core is already printing a message when a driver
IN> requests probe deferral, so this can be traced in the logs
IN> without these error prints.
IN> This patch changes the error messages from these deferral cases
IN> to debug messages.
IN> Signed-off-by: Ionut Nicu <ioan.nicu.ext-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Acked-by: Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-26 9:09 ` Alexander Sverdlin
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Sverdlin @ 2015-03-26 9:09 UTC (permalink / raw)
To: Ioan Nicu, Peter Korsgaard, Wolfram Sang, linux-i2c, linux-kernel
Cc: Mathias Rulf
On 25/03/15 18:43, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
>
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
>
> This patch changes the error messages from these deferral cases
> to debug messages.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>
Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..9f1cfca 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
> }
> adapter = of_find_i2c_adapter_by_node(adapter_np);
> if (!adapter) {
> - dev_err(&pdev->dev, "Cannot find parent bus\n");
> + dev_dbg(&pdev->dev, "Cannot find parent bus\n");
> return -EPROBE_DEFER;
> }
> mux->data.parent = i2c_adapter_id(adapter);
> @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>
> parent = i2c_get_adapter(mux->data.parent);
> if (!parent) {
> - dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> + dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
> mux->data.parent);
> return -EPROBE_DEFER;
> }
--
Best regards,
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-26 9:09 ` Alexander Sverdlin
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Sverdlin @ 2015-03-26 9:09 UTC (permalink / raw)
To: Ioan Nicu, Peter Korsgaard, Wolfram Sang,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Mathias Rulf
On 25/03/15 18:43, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
>
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
>
> This patch changes the error messages from these deferral cases
> to debug messages.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Acked-by: Alexander Sverdlin <alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..9f1cfca 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
> }
> adapter = of_find_i2c_adapter_by_node(adapter_np);
> if (!adapter) {
> - dev_err(&pdev->dev, "Cannot find parent bus\n");
> + dev_dbg(&pdev->dev, "Cannot find parent bus\n");
> return -EPROBE_DEFER;
> }
> mux->data.parent = i2c_adapter_id(adapter);
> @@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>
> parent = i2c_get_adapter(mux->data.parent);
> if (!parent) {
> - dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> + dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
> mux->data.parent);
> return -EPROBE_DEFER;
> }
--
Best regards,
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-27 15:29 ` Wolfram Sang
0 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2015-03-27 15:29 UTC (permalink / raw)
To: Ioan Nicu
Cc: Peter Korsgaard, linux-i2c, linux-kernel, Alexander Sverdlin,
Mathias Rulf
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Wed, Mar 25, 2015 at 06:43:51PM +0100, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
>
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
>
> This patch changes the error messages from these deferral cases
> to debug messages.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>
Why not simply removing it?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
@ 2015-03-27 15:29 ` Wolfram Sang
0 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2015-03-27 15:29 UTC (permalink / raw)
To: Ioan Nicu
Cc: Peter Korsgaard, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Alexander Sverdlin,
Mathias Rulf
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Wed, Mar 25, 2015 at 06:43:51PM +0100, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
>
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
>
> This patch changes the error messages from these deferral cases
> to debug messages.
>
> Signed-off-by: Ionut Nicu <ioan.nicu.ext-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Why not simply removing it?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals
2015-03-27 15:29 ` Wolfram Sang
(?)
@ 2015-03-30 7:57 ` Ioan Nicu
-1 siblings, 0 replies; 9+ messages in thread
From: Ioan Nicu @ 2015-03-30 7:57 UTC (permalink / raw)
To: ext Wolfram Sang
Cc: Ioan Nicu, Peter Korsgaard, linux-i2c, linux-kernel,
Alexander Sverdlin, Mathias Rulf
On Fri, Mar 27, 2015 at 04:29:33PM +0100, ext Wolfram Sang wrote:
> On Wed, Mar 25, 2015 at 06:43:51PM +0100, Ioan Nicu wrote:
> > Probe deferral is not an error case. It happens only when
> > the necessary dependencies are not there yet.
> >
> > The driver core is already printing a message when a driver
> > requests probe deferral, so this can be traced in the logs
> > without these error prints.
> >
> > This patch changes the error messages from these deferral cases
> > to debug messages.
> >
> > Signed-off-by: Ionut Nicu <ioan.nicu.ext@nokia.com>
>
> Why not simply removing it?
>
Right, those messages are not relevant anyway, so removing them is better.
I'll send out an updated patch.
Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread