* [PATCH] drm/msm: Fix convert to drm_of_get_data_lanes_count
@ 2022-06-12 14:33 Marek Vasut
2022-06-13 14:32 ` Andrzej Hajda
2022-06-13 16:50 ` Abhinav Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2022-06-12 14:33 UTC (permalink / raw)
To: dri-devel
Cc: Marek Vasut, kernel test robot, Maxime Ripard, Sean Paul,
Abhinav Kumar, robert.foss, Laurent Pinchart, Andrzej Hajda,
Dmitry Baryshkov, Sam Ravnborg
Add missing header file into dsi_host.c and encode data-lanes string
directly into the warning message in the driver to avoid build issues
detected by lkp.
Fixes: 185443efa26a ("drm/msm: Convert to drm_of_get_data_lanes_count")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/msm/dp/dp_parser.c | 4 ++--
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c
index 346556c5706d7..57ae14a0e1814 100644
--- a/drivers/gpu/drm/msm/dp/dp_parser.c
+++ b/drivers/gpu/drm/msm/dp/dp_parser.c
@@ -106,8 +106,8 @@ static int dp_parser_misc(struct dp_parser *parser)
len = drm_of_get_data_lanes_count(of_node, 1, DP_MAX_NUM_DP_LANES);
if (len < 0) {
- DRM_WARN("Invalid property %s, default max DP lanes = %d\n",
- data_lane_property, DP_MAX_NUM_DP_LANES);
+ DRM_WARN("Invalid property \"data-lanes\", default max DP lanes = %d\n",
+ DP_MAX_NUM_DP_LANES);
len = DP_MAX_NUM_DP_LANES;
}
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index db5871b9c5d88..7e21916d1511a 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -21,6 +21,8 @@
#include <video/mipi_display.h>
+#include <drm/drm_of.h>
+
#include "dsi.h"
#include "dsi.xml.h"
#include "sfpb.xml.h"
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Fix convert to drm_of_get_data_lanes_count
2022-06-12 14:33 [PATCH] drm/msm: Fix convert to drm_of_get_data_lanes_count Marek Vasut
@ 2022-06-13 14:32 ` Andrzej Hajda
2022-06-13 16:50 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2022-06-13 14:32 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: kernel test robot, Maxime Ripard, Sean Paul, Abhinav Kumar,
robert.foss, Laurent Pinchart, Dmitry Baryshkov, Sam Ravnborg
On 12.06.2022 16:33, Marek Vasut wrote:
> Add missing header file into dsi_host.c and encode data-lanes string
> directly into the warning message in the driver to avoid build issues
> detected by lkp.
>
> Fixes: 185443efa26a ("drm/msm: Convert to drm_of_get_data_lanes_count")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Sean Paul <sean@poorly.run>
> To: dri-devel@lists.freedesktop.org
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/msm/dp/dp_parser.c | 4 ++--
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c
> index 346556c5706d7..57ae14a0e1814 100644
> --- a/drivers/gpu/drm/msm/dp/dp_parser.c
> +++ b/drivers/gpu/drm/msm/dp/dp_parser.c
> @@ -106,8 +106,8 @@ static int dp_parser_misc(struct dp_parser *parser)
>
> len = drm_of_get_data_lanes_count(of_node, 1, DP_MAX_NUM_DP_LANES);
> if (len < 0) {
> - DRM_WARN("Invalid property %s, default max DP lanes = %d\n",
> - data_lane_property, DP_MAX_NUM_DP_LANES);
> + DRM_WARN("Invalid property \"data-lanes\", default max DP lanes = %d\n",
> + DP_MAX_NUM_DP_LANES);
> len = DP_MAX_NUM_DP_LANES;
> }
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index db5871b9c5d88..7e21916d1511a 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -21,6 +21,8 @@
>
> #include <video/mipi_display.h>
>
> +#include <drm/drm_of.h>
> +
> #include "dsi.h"
> #include "dsi.xml.h"
> #include "sfpb.xml.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Fix convert to drm_of_get_data_lanes_count
2022-06-12 14:33 [PATCH] drm/msm: Fix convert to drm_of_get_data_lanes_count Marek Vasut
2022-06-13 14:32 ` Andrzej Hajda
@ 2022-06-13 16:50 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Abhinav Kumar @ 2022-06-13 16:50 UTC (permalink / raw)
To: Marek Vasut, dri-devel
Cc: kernel test robot, Maxime Ripard, Sean Paul, robert.foss,
Laurent Pinchart, Andrzej Hajda, Dmitry Baryshkov, Sam Ravnborg
On 6/12/2022 7:33 AM, Marek Vasut wrote:
> Add missing header file into dsi_host.c and encode data-lanes string
> directly into the warning message in the driver to avoid build issues
> detected by lkp.
>
> Fixes: 185443efa26a ("drm/msm: Convert to drm_of_get_data_lanes_count")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Sean Paul <sean@poorly.run>
> To: dri-devel@lists.freedesktop.org
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_parser.c | 4 ++--
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c
> index 346556c5706d7..57ae14a0e1814 100644
> --- a/drivers/gpu/drm/msm/dp/dp_parser.c
> +++ b/drivers/gpu/drm/msm/dp/dp_parser.c
> @@ -106,8 +106,8 @@ static int dp_parser_misc(struct dp_parser *parser)
>
> len = drm_of_get_data_lanes_count(of_node, 1, DP_MAX_NUM_DP_LANES);
> if (len < 0) {
> - DRM_WARN("Invalid property %s, default max DP lanes = %d\n",
> - data_lane_property, DP_MAX_NUM_DP_LANES);
> + DRM_WARN("Invalid property \"data-lanes\", default max DP lanes = %d\n",
> + DP_MAX_NUM_DP_LANES);
> len = DP_MAX_NUM_DP_LANES;
> }
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index db5871b9c5d88..7e21916d1511a 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -21,6 +21,8 @@
>
> #include <video/mipi_display.h>
>
> +#include <drm/drm_of.h>
> +
> #include "dsi.h"
> #include "dsi.xml.h"
> #include "sfpb.xml.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-13 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-12 14:33 [PATCH] drm/msm: Fix convert to drm_of_get_data_lanes_count Marek Vasut
2022-06-13 14:32 ` Andrzej Hajda
2022-06-13 16:50 ` Abhinav Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.