All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
       [not found] <E1YdHjz-0005Rv-A3@sd-51317.xenomai.org>
@ 2015-04-01 12:51 ` Gilles Chanteperdrix
  2015-04-01 12:58   ` Philippe Gerum
  2015-04-01 13:38   ` Lowell Gilbert
  0 siblings, 2 replies; 15+ messages in thread
From: Gilles Chanteperdrix @ 2015-04-01 12:51 UTC (permalink / raw)
  To: xenomai

On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
> Module: xenomai-jki
> Branch: for-forge
> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
> 
> Author: Jan Kiszka <jan.kiszka@siemens.com>
> Date:   Wed Apr  1 14:25:42 2015 +0200
> 
> Create gitignore for autotools files
> 
> This avoids filling up "git status" with tones of autotools files that
> are now locally maintained.

I am not sure having a gitignore file in the repository is a good
idea, for instance, it will conflict with the gitignore I already
had, because not using the same autotools version as Philippe, my
git status was already filled with tons of autotools files without a
gitignore and before they were removed from the repository. I also
like to add files to gitignore like *~ my editor creates, and so if
my gitignore has local modifications, I will see it in the git
status too.

-- 
					    Gilles.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 12:51 ` [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files Gilles Chanteperdrix
@ 2015-04-01 12:58   ` Philippe Gerum
  2015-04-01 14:26     ` Jan Kiszka
  2015-04-01 13:38   ` Lowell Gilbert
  1 sibling, 1 reply; 15+ messages in thread
From: Philippe Gerum @ 2015-04-01 12:58 UTC (permalink / raw)
  To: Gilles Chanteperdrix, xenomai

On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>> Module: xenomai-jki
>> Branch: for-forge
>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>
>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>
>> Create gitignore for autotools files
>>
>> This avoids filling up "git status" with tones of autotools files that
>> are now locally maintained.
> 
> I am not sure having a gitignore file in the repository is a good
> idea, for instance, it will conflict with the gitignore I already
> had, because not using the same autotools version as Philippe, my
> git status was already filled with tons of autotools files without a
> gitignore and before they were removed from the repository. I also
> like to add files to gitignore like *~ my editor creates, and so if
> my gitignore has local modifications, I will see it in the git
> status too.
> 

I'd rather refrain from forcing .gitignore on users too, what to filter
out should remain a local policy. However, we could provide a sane
default template for this file if that helps, e.g. scripts/gitignore.dot.

-- 
Philippe.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 12:51 ` [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files Gilles Chanteperdrix
  2015-04-01 12:58   ` Philippe Gerum
@ 2015-04-01 13:38   ` Lowell Gilbert
  2015-04-01 14:24     ` Jan Kiszka
  1 sibling, 1 reply; 15+ messages in thread
From: Lowell Gilbert @ 2015-04-01 13:38 UTC (permalink / raw)
  To: xenomai

Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> writes:

> I am not sure having a gitignore file in the repository is a good
> idea, for instance, it will conflict with the gitignore I already
> had, because not using the same autotools version as Philippe, my
> git status was already filled with tons of autotools files without a
> gitignore and before they were removed from the repository. I also
> like to add files to gitignore like *~ my editor creates, and so if
> my gitignore has local modifications, I will see it in the git
> status too.

While I do not support adding gitignore to repositories, I suggest that
these particular issues are more easily handled with methods that cover
multiple work trees. In these examples, .git/info/exclude and
.config/git/ignore respectively.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 13:38   ` Lowell Gilbert
@ 2015-04-01 14:24     ` Jan Kiszka
  0 siblings, 0 replies; 15+ messages in thread
From: Jan Kiszka @ 2015-04-01 14:24 UTC (permalink / raw)
  To: Lowell Gilbert, xenomai

On 2015-04-01 15:38, Lowell Gilbert wrote:
> Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> writes:
> 
>> I am not sure having a gitignore file in the repository is a good
>> idea, for instance, it will conflict with the gitignore I already
>> had, because not using the same autotools version as Philippe, my
>> git status was already filled with tons of autotools files without a
>> gitignore and before they were removed from the repository. I also
>> like to add files to gitignore like *~ my editor creates, and so if
>> my gitignore has local modifications, I will see it in the git
>> status too.
> 
> While I do not support adding gitignore to repositories, I suggest that
> these particular issues are more easily handled with methods that cover
> multiple work trees. In these examples, .git/info/exclude and
> .config/git/ignore respectively.

Indeed. .gitignore is supposed to be carried in the repository (most
projects do this) while .git/... or ~/.config/... is for local tuning.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 12:58   ` Philippe Gerum
@ 2015-04-01 14:26     ` Jan Kiszka
  2015-04-01 16:20       ` Philippe Gerum
  0 siblings, 1 reply; 15+ messages in thread
From: Jan Kiszka @ 2015-04-01 14:26 UTC (permalink / raw)
  To: Philippe Gerum, Gilles Chanteperdrix, xenomai

On 2015-04-01 14:58, Philippe Gerum wrote:
> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>>> Module: xenomai-jki
>>> Branch: for-forge
>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>>
>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>>
>>> Create gitignore for autotools files
>>>
>>> This avoids filling up "git status" with tones of autotools files that
>>> are now locally maintained.
>>
>> I am not sure having a gitignore file in the repository is a good
>> idea, for instance, it will conflict with the gitignore I already
>> had, because not using the same autotools version as Philippe, my
>> git status was already filled with tons of autotools files without a
>> gitignore and before they were removed from the repository. I also
>> like to add files to gitignore like *~ my editor creates, and so if
>> my gitignore has local modifications, I will see it in the git
>> status too.
>>
> 
> I'd rather refrain from forcing .gitignore on users too, what to filter
> out should remain a local policy. However, we could provide a sane
> default template for this file if that helps, e.g. scripts/gitignore.dot.

See "man gitignore" for the common policy: .gitignore is already that
baseline we want to distribute.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 14:26     ` Jan Kiszka
@ 2015-04-01 16:20       ` Philippe Gerum
  2015-04-01 16:30         ` Jan Kiszka
  0 siblings, 1 reply; 15+ messages in thread
From: Philippe Gerum @ 2015-04-01 16:20 UTC (permalink / raw)
  To: Jan Kiszka, Gilles Chanteperdrix, xenomai

On 04/01/2015 04:26 PM, Jan Kiszka wrote:
> On 2015-04-01 14:58, Philippe Gerum wrote:
>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>>>> Module: xenomai-jki
>>>> Branch: for-forge
>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>>>
>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>>>
>>>> Create gitignore for autotools files
>>>>
>>>> This avoids filling up "git status" with tones of autotools files that
>>>> are now locally maintained.
>>>
>>> I am not sure having a gitignore file in the repository is a good
>>> idea, for instance, it will conflict with the gitignore I already
>>> had, because not using the same autotools version as Philippe, my
>>> git status was already filled with tons of autotools files without a
>>> gitignore and before they were removed from the repository. I also
>>> like to add files to gitignore like *~ my editor creates, and so if
>>> my gitignore has local modifications, I will see it in the git
>>> status too.
>>>
>>
>> I'd rather refrain from forcing .gitignore on users too, what to filter
>> out should remain a local policy. However, we could provide a sane
>> default template for this file if that helps, e.g. scripts/gitignore.dot.
> 
> See "man gitignore" for the common policy: .gitignore is already that
> baseline we want to distribute.
> 

"A project normally includes such .gitignore files in its repository,
containing patterns for files generated as part of the project build."

Those files are not generated by the build process, but by the
configuration process, which is separate. What is produced even depends
on the autoconf release being used locally.

-- 
Philippe.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 16:20       ` Philippe Gerum
@ 2015-04-01 16:30         ` Jan Kiszka
  2015-04-01 17:19           ` Philippe Gerum
  2015-04-01 19:49           ` Lennart Sorensen
  0 siblings, 2 replies; 15+ messages in thread
From: Jan Kiszka @ 2015-04-01 16:30 UTC (permalink / raw)
  To: Philippe Gerum, Gilles Chanteperdrix, xenomai

On 2015-04-01 18:20, Philippe Gerum wrote:
> On 04/01/2015 04:26 PM, Jan Kiszka wrote:
>> On 2015-04-01 14:58, Philippe Gerum wrote:
>>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
>>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>>>>> Module: xenomai-jki
>>>>> Branch: for-forge
>>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>
>>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>>>>
>>>>> Create gitignore for autotools files
>>>>>
>>>>> This avoids filling up "git status" with tones of autotools files that
>>>>> are now locally maintained.
>>>>
>>>> I am not sure having a gitignore file in the repository is a good
>>>> idea, for instance, it will conflict with the gitignore I already
>>>> had, because not using the same autotools version as Philippe, my
>>>> git status was already filled with tons of autotools files without a
>>>> gitignore and before they were removed from the repository. I also
>>>> like to add files to gitignore like *~ my editor creates, and so if
>>>> my gitignore has local modifications, I will see it in the git
>>>> status too.
>>>>
>>>
>>> I'd rather refrain from forcing .gitignore on users too, what to filter
>>> out should remain a local policy. However, we could provide a sane
>>> default template for this file if that helps, e.g. scripts/gitignore.dot.
>>
>> See "man gitignore" for the common policy: .gitignore is already that
>> baseline we want to distribute.
>>
> 
> "A project normally includes such .gitignore files in its repository,
> containing patterns for files generated as part of the project build."
> 
> Those files are not generated by the build process, but by the
> configuration process, which is separate. What is produced even depends
> on the autoconf release being used locally.

By pulling everything that autoconf generates out of the repo, forcing
the user of the git version to generate them yourself, you effectively
made those files build outputs. As we cannot store them out-of-tree
(like object files), we have to ignore them in-tree.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 16:30         ` Jan Kiszka
@ 2015-04-01 17:19           ` Philippe Gerum
  2015-04-01 18:06             ` Jan Kiszka
  2015-04-01 19:49           ` Lennart Sorensen
  1 sibling, 1 reply; 15+ messages in thread
From: Philippe Gerum @ 2015-04-01 17:19 UTC (permalink / raw)
  To: Jan Kiszka, Gilles Chanteperdrix, xenomai

On 04/01/2015 06:30 PM, Jan Kiszka wrote:
> On 2015-04-01 18:20, Philippe Gerum wrote:
>> On 04/01/2015 04:26 PM, Jan Kiszka wrote:
>>> On 2015-04-01 14:58, Philippe Gerum wrote:
>>>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
>>>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>>>>>> Module: xenomai-jki
>>>>>> Branch: for-forge
>>>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>>
>>>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>>>>>
>>>>>> Create gitignore for autotools files
>>>>>>
>>>>>> This avoids filling up "git status" with tones of autotools files that
>>>>>> are now locally maintained.
>>>>>
>>>>> I am not sure having a gitignore file in the repository is a good
>>>>> idea, for instance, it will conflict with the gitignore I already
>>>>> had, because not using the same autotools version as Philippe, my
>>>>> git status was already filled with tons of autotools files without a
>>>>> gitignore and before they were removed from the repository. I also
>>>>> like to add files to gitignore like *~ my editor creates, and so if
>>>>> my gitignore has local modifications, I will see it in the git
>>>>> status too.
>>>>>
>>>>
>>>> I'd rather refrain from forcing .gitignore on users too, what to filter
>>>> out should remain a local policy. However, we could provide a sane
>>>> default template for this file if that helps, e.g. scripts/gitignore.dot.
>>>
>>> See "man gitignore" for the common policy: .gitignore is already that
>>> baseline we want to distribute.
>>>
>>
>> "A project normally includes such .gitignore files in its repository,
>> containing patterns for files generated as part of the project build."
>>
>> Those files are not generated by the build process, but by the
>> configuration process, which is separate. What is produced even depends
>> on the autoconf release being used locally.
> 
> By pulling everything that autoconf generates out of the repo, forcing
> the user of the git version to generate them yourself, you effectively
> made those files build outputs. As we cannot store them out-of-tree
> (like object files), we have to ignore them in-tree.

Sorry, no. We cannot predict what files will be produced by the autoconf
system when bootstrapping unless we know about the autoconf version
being used locally, which we don't. This should be a clear hint that
forcing a filter on users for such files is a bad idea in the first place.

It seems fairly reasonable to ask people tracking our git trees to do
such bootstrap, and create their own filter in the same move.
Bootstrapping is a one time operation, which is documented:
http://xenomai.org/installing-xenomai-3-x/#Installing_the_Xenomai_libraries_and_tools

People building Xenomai out of tarballs won't have to care about
bootstrapping, since in this case we should assume that they don't care
for a development tree, but rather need a self-contained and frozen
source tree.

-- 
Philippe.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 17:19           ` Philippe Gerum
@ 2015-04-01 18:06             ` Jan Kiszka
  2015-04-02  8:56               ` Gilles Chanteperdrix
  0 siblings, 1 reply; 15+ messages in thread
From: Jan Kiszka @ 2015-04-01 18:06 UTC (permalink / raw)
  To: Philippe Gerum, Gilles Chanteperdrix, xenomai

On 2015-04-01 19:19, Philippe Gerum wrote:
> On 04/01/2015 06:30 PM, Jan Kiszka wrote:
>> On 2015-04-01 18:20, Philippe Gerum wrote:
>>> On 04/01/2015 04:26 PM, Jan Kiszka wrote:
>>>> On 2015-04-01 14:58, Philippe Gerum wrote:
>>>>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
>>>>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>>>>>>> Module: xenomai-jki
>>>>>>> Branch: for-forge
>>>>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>>>
>>>>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>>>>>>
>>>>>>> Create gitignore for autotools files
>>>>>>>
>>>>>>> This avoids filling up "git status" with tones of autotools files that
>>>>>>> are now locally maintained.
>>>>>>
>>>>>> I am not sure having a gitignore file in the repository is a good
>>>>>> idea, for instance, it will conflict with the gitignore I already
>>>>>> had, because not using the same autotools version as Philippe, my
>>>>>> git status was already filled with tons of autotools files without a
>>>>>> gitignore and before they were removed from the repository. I also
>>>>>> like to add files to gitignore like *~ my editor creates, and so if
>>>>>> my gitignore has local modifications, I will see it in the git
>>>>>> status too.
>>>>>>
>>>>>
>>>>> I'd rather refrain from forcing .gitignore on users too, what to filter
>>>>> out should remain a local policy. However, we could provide a sane
>>>>> default template for this file if that helps, e.g. scripts/gitignore.dot.
>>>>
>>>> See "man gitignore" for the common policy: .gitignore is already that
>>>> baseline we want to distribute.
>>>>
>>>
>>> "A project normally includes such .gitignore files in its repository,
>>> containing patterns for files generated as part of the project build."
>>>
>>> Those files are not generated by the build process, but by the
>>> configuration process, which is separate. What is produced even depends
>>> on the autoconf release being used locally.
>>
>> By pulling everything that autoconf generates out of the repo, forcing
>> the user of the git version to generate them yourself, you effectively
>> made those files build outputs. As we cannot store them out-of-tree
>> (like object files), we have to ignore them in-tree.
> 
> Sorry, no. We cannot predict what files will be produced by the autoconf
> system when bootstrapping unless we know about the autoconf version
> being used locally, which we don't. This should be a clear hint that
> forcing a filter on users for such files is a bad idea in the first place.

Those files do not change arbitrarily, and, yes, we can easily update
those as they come in via new version. That is how other project deal
with the very same issue.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 16:30         ` Jan Kiszka
  2015-04-01 17:19           ` Philippe Gerum
@ 2015-04-01 19:49           ` Lennart Sorensen
  2015-04-02  8:38             ` Gilles Chanteperdrix
  1 sibling, 1 reply; 15+ messages in thread
From: Lennart Sorensen @ 2015-04-01 19:49 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: xenomai

On Wed, Apr 01, 2015 at 06:30:36PM +0200, Jan Kiszka wrote:
> By pulling everything that autoconf generates out of the repo, forcing
> the user of the git version to generate them yourself, you effectively
> made those files build outputs. As we cannot store them out-of-tree
> (like object files), we have to ignore them in-tree.

Certainly having them in .gitignore is a handy way to avoid them
accidentally being commited again, if someone has a habbit of doing git
commit -a.

-- 
Len Sorensn


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 19:49           ` Lennart Sorensen
@ 2015-04-02  8:38             ` Gilles Chanteperdrix
  2015-04-02 17:49               ` Lennart Sorensen
  0 siblings, 1 reply; 15+ messages in thread
From: Gilles Chanteperdrix @ 2015-04-02  8:38 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: Jan Kiszka, xenomai

On Wed, Apr 01, 2015 at 03:49:28PM -0400, Lennart Sorensen wrote:
> On Wed, Apr 01, 2015 at 06:30:36PM +0200, Jan Kiszka wrote:
> > By pulling everything that autoconf generates out of the repo, forcing
> > the user of the git version to generate them yourself, you effectively
> > made those files build outputs. As we cannot store them out-of-tree
> > (like object files), we have to ignore them in-tree.
> 
> Certainly having them in .gitignore is a handy way to avoid them
> accidentally being commited again, if someone has a habbit of doing git
> commit -a.

git commit -a does not automatically add files to the repository. At
least not with the default configuration. Besides, nobody in this
thread is against the use of a .gitignore.

-- 
					    Gilles.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-01 18:06             ` Jan Kiszka
@ 2015-04-02  8:56               ` Gilles Chanteperdrix
  2015-04-02  9:32                 ` Jan Kiszka
  0 siblings, 1 reply; 15+ messages in thread
From: Gilles Chanteperdrix @ 2015-04-02  8:56 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: xenomai

On Wed, Apr 01, 2015 at 08:06:46PM +0200, Jan Kiszka wrote:
> On 2015-04-01 19:19, Philippe Gerum wrote:
> > On 04/01/2015 06:30 PM, Jan Kiszka wrote:
> >> On 2015-04-01 18:20, Philippe Gerum wrote:
> >>> On 04/01/2015 04:26 PM, Jan Kiszka wrote:
> >>>> On 2015-04-01 14:58, Philippe Gerum wrote:
> >>>>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
> >>>>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
> >>>>>>> Module: xenomai-jki
> >>>>>>> Branch: for-forge
> >>>>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
> >>>>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
> >>>>>>>
> >>>>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
> >>>>>>>
> >>>>>>> Create gitignore for autotools files
> >>>>>>>
> >>>>>>> This avoids filling up "git status" with tones of autotools files that
> >>>>>>> are now locally maintained.
> >>>>>>
> >>>>>> I am not sure having a gitignore file in the repository is a good
> >>>>>> idea, for instance, it will conflict with the gitignore I already
> >>>>>> had, because not using the same autotools version as Philippe, my
> >>>>>> git status was already filled with tons of autotools files without a
> >>>>>> gitignore and before they were removed from the repository. I also
> >>>>>> like to add files to gitignore like *~ my editor creates, and so if
> >>>>>> my gitignore has local modifications, I will see it in the git
> >>>>>> status too.
> >>>>>>
> >>>>>
> >>>>> I'd rather refrain from forcing .gitignore on users too, what to filter
> >>>>> out should remain a local policy. However, we could provide a sane
> >>>>> default template for this file if that helps, e.g. scripts/gitignore.dot.
> >>>>
> >>>> See "man gitignore" for the common policy: .gitignore is already that
> >>>> baseline we want to distribute.
> >>>>
> >>>
> >>> "A project normally includes such .gitignore files in its repository,
> >>> containing patterns for files generated as part of the project build."
> >>>
> >>> Those files are not generated by the build process, but by the
> >>> configuration process, which is separate. What is produced even depends
> >>> on the autoconf release being used locally.
> >>
> >> By pulling everything that autoconf generates out of the repo, forcing
> >> the user of the git version to generate them yourself, you effectively
> >> made those files build outputs. As we cannot store them out-of-tree
> >> (like object files), we have to ignore them in-tree.
> > 
> > Sorry, no. We cannot predict what files will be produced by the autoconf
> > system when bootstrapping unless we know about the autoconf version
> > being used locally, which we don't. This should be a clear hint that
> > forcing a filter on users for such files is a bad idea in the first place.
> 
> Those files do not change arbitrarily, and, yes, we can easily update
> those as they come in via new version. That is how other project deal
> with the very same issue.

The point is: different users may use different versions of the
autotools. I use whatever the installed distribution provides, this
may not be the latest version. And I am certainly not going to
install anything else for this or that project, I would rather
change the project autotools files so that they work with that
version.

The version I use for instance, adds a config/compile script which
apparently the version you use does not have.

Anyway, by requiring users who work with git to have the autotools
installed, we are asking them to know how to use them, so, we may as
well expect them to know how to put the generated file names to a
.gitignore.

-- 
					    Gilles.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-02  8:56               ` Gilles Chanteperdrix
@ 2015-04-02  9:32                 ` Jan Kiszka
  2015-04-02 11:42                   ` Gilles Chanteperdrix
  0 siblings, 1 reply; 15+ messages in thread
From: Jan Kiszka @ 2015-04-02  9:32 UTC (permalink / raw)
  To: Gilles Chanteperdrix; +Cc: xenomai

On 2015-04-02 10:56, Gilles Chanteperdrix wrote:
> On Wed, Apr 01, 2015 at 08:06:46PM +0200, Jan Kiszka wrote:
>> On 2015-04-01 19:19, Philippe Gerum wrote:
>>> On 04/01/2015 06:30 PM, Jan Kiszka wrote:
>>>> On 2015-04-01 18:20, Philippe Gerum wrote:
>>>>> On 04/01/2015 04:26 PM, Jan Kiszka wrote:
>>>>>> On 2015-04-01 14:58, Philippe Gerum wrote:
>>>>>>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
>>>>>>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
>>>>>>>>> Module: xenomai-jki
>>>>>>>>> Branch: for-forge
>>>>>>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
>>>>>>>>>
>>>>>>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
>>>>>>>>>
>>>>>>>>> Create gitignore for autotools files
>>>>>>>>>
>>>>>>>>> This avoids filling up "git status" with tones of autotools files that
>>>>>>>>> are now locally maintained.
>>>>>>>>
>>>>>>>> I am not sure having a gitignore file in the repository is a good
>>>>>>>> idea, for instance, it will conflict with the gitignore I already
>>>>>>>> had, because not using the same autotools version as Philippe, my
>>>>>>>> git status was already filled with tons of autotools files without a
>>>>>>>> gitignore and before they were removed from the repository. I also
>>>>>>>> like to add files to gitignore like *~ my editor creates, and so if
>>>>>>>> my gitignore has local modifications, I will see it in the git
>>>>>>>> status too.
>>>>>>>>
>>>>>>>
>>>>>>> I'd rather refrain from forcing .gitignore on users too, what to filter
>>>>>>> out should remain a local policy. However, we could provide a sane
>>>>>>> default template for this file if that helps, e.g. scripts/gitignore.dot.
>>>>>>
>>>>>> See "man gitignore" for the common policy: .gitignore is already that
>>>>>> baseline we want to distribute.
>>>>>>
>>>>>
>>>>> "A project normally includes such .gitignore files in its repository,
>>>>> containing patterns for files generated as part of the project build."
>>>>>
>>>>> Those files are not generated by the build process, but by the
>>>>> configuration process, which is separate. What is produced even depends
>>>>> on the autoconf release being used locally.
>>>>
>>>> By pulling everything that autoconf generates out of the repo, forcing
>>>> the user of the git version to generate them yourself, you effectively
>>>> made those files build outputs. As we cannot store them out-of-tree
>>>> (like object files), we have to ignore them in-tree.
>>>
>>> Sorry, no. We cannot predict what files will be produced by the autoconf
>>> system when bootstrapping unless we know about the autoconf version
>>> being used locally, which we don't. This should be a clear hint that
>>> forcing a filter on users for such files is a bad idea in the first place.
>>
>> Those files do not change arbitrarily, and, yes, we can easily update
>> those as they come in via new version. That is how other project deal
>> with the very same issue.
> 
> The point is: different users may use different versions of the
> autotools. I use whatever the installed distribution provides, this
> may not be the latest version. And I am certainly not going to
> install anything else for this or that project, I would rather
> change the project autotools files so that they work with that
> version.
> 
> The version I use for instance, adds a config/compile script which
> apparently the version you use does not have.
> 
> Anyway, by requiring users who work with git to have the autotools
> installed, we are asking them to know how to use them, so, we may as
> well expect them to know how to put the generated file names to a
> .gitignore.

So,

# .gitignore
.gitignore
...

? Err, something is utterly wrong here.

Come on, we have bigger fish to fry. Let's just add all currently known
autotools files to .gitignore, commit this thing and properly maintain
it *once* for everyone. There is zero point in deviation from what all
other projects do and what git users expect from us.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-02  9:32                 ` Jan Kiszka
@ 2015-04-02 11:42                   ` Gilles Chanteperdrix
  0 siblings, 0 replies; 15+ messages in thread
From: Gilles Chanteperdrix @ 2015-04-02 11:42 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: xenomai

On Thu, Apr 02, 2015 at 11:32:36AM +0200, Jan Kiszka wrote:
> On 2015-04-02 10:56, Gilles Chanteperdrix wrote:
> > On Wed, Apr 01, 2015 at 08:06:46PM +0200, Jan Kiszka wrote:
> >> On 2015-04-01 19:19, Philippe Gerum wrote:
> >>> On 04/01/2015 06:30 PM, Jan Kiszka wrote:
> >>>> On 2015-04-01 18:20, Philippe Gerum wrote:
> >>>>> On 04/01/2015 04:26 PM, Jan Kiszka wrote:
> >>>>>> On 2015-04-01 14:58, Philippe Gerum wrote:
> >>>>>>> On 04/01/2015 02:51 PM, Gilles Chanteperdrix wrote:
> >>>>>>>> On Wed, Apr 01, 2015 at 02:27:27PM +0200, git repository hosting wrote:
> >>>>>>>>> Module: xenomai-jki
> >>>>>>>>> Branch: for-forge
> >>>>>>>>> Commit: 519962c23a696aba736d8b535c8f1a00382dae8b
> >>>>>>>>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=519962c23a696aba736d8b535c8f1a00382dae8b
> >>>>>>>>>
> >>>>>>>>> Author: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>>>>>> Date:   Wed Apr  1 14:25:42 2015 +0200
> >>>>>>>>>
> >>>>>>>>> Create gitignore for autotools files
> >>>>>>>>>
> >>>>>>>>> This avoids filling up "git status" with tones of autotools files that
> >>>>>>>>> are now locally maintained.
> >>>>>>>>
> >>>>>>>> I am not sure having a gitignore file in the repository is a good
> >>>>>>>> idea, for instance, it will conflict with the gitignore I already
> >>>>>>>> had, because not using the same autotools version as Philippe, my
> >>>>>>>> git status was already filled with tons of autotools files without a
> >>>>>>>> gitignore and before they were removed from the repository. I also
> >>>>>>>> like to add files to gitignore like *~ my editor creates, and so if
> >>>>>>>> my gitignore has local modifications, I will see it in the git
> >>>>>>>> status too.
> >>>>>>>>
> >>>>>>>
> >>>>>>> I'd rather refrain from forcing .gitignore on users too, what to filter
> >>>>>>> out should remain a local policy. However, we could provide a sane
> >>>>>>> default template for this file if that helps, e.g. scripts/gitignore.dot.
> >>>>>>
> >>>>>> See "man gitignore" for the common policy: .gitignore is already that
> >>>>>> baseline we want to distribute.
> >>>>>>
> >>>>>
> >>>>> "A project normally includes such .gitignore files in its repository,
> >>>>> containing patterns for files generated as part of the project build."
> >>>>>
> >>>>> Those files are not generated by the build process, but by the
> >>>>> configuration process, which is separate. What is produced even depends
> >>>>> on the autoconf release being used locally.
> >>>>
> >>>> By pulling everything that autoconf generates out of the repo, forcing
> >>>> the user of the git version to generate them yourself, you effectively
> >>>> made those files build outputs. As we cannot store them out-of-tree
> >>>> (like object files), we have to ignore them in-tree.
> >>>
> >>> Sorry, no. We cannot predict what files will be produced by the autoconf
> >>> system when bootstrapping unless we know about the autoconf version
> >>> being used locally, which we don't. This should be a clear hint that
> >>> forcing a filter on users for such files is a bad idea in the first place.
> >>
> >> Those files do not change arbitrarily, and, yes, we can easily update
> >> those as they come in via new version. That is how other project deal
> >> with the very same issue.
> > 
> > The point is: different users may use different versions of the
> > autotools. I use whatever the installed distribution provides, this
> > may not be the latest version. And I am certainly not going to
> > install anything else for this or that project, I would rather
> > change the project autotools files so that they work with that
> > version.
> > 
> > The version I use for instance, adds a config/compile script which
> > apparently the version you use does not have.
> > 
> > Anyway, by requiring users who work with git to have the autotools
> > installed, we are asking them to know how to use them, so, we may as
> > well expect them to know how to put the generated file names to a
> > .gitignore.
> 
> So,
> 
> # .gitignore
> .gitignore
> ...

I do not see why you answer that. But if .gitignore was added to the
git repository, this does not work. The contents of .gitignore only
apply to files not in the repository. See gitignore documentation
for details.

-- 
					    Gilles.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files
  2015-04-02  8:38             ` Gilles Chanteperdrix
@ 2015-04-02 17:49               ` Lennart Sorensen
  0 siblings, 0 replies; 15+ messages in thread
From: Lennart Sorensen @ 2015-04-02 17:49 UTC (permalink / raw)
  To: Gilles Chanteperdrix; +Cc: Jan Kiszka, xenomai

On Thu, Apr 02, 2015 at 10:38:27AM +0200, Gilles Chanteperdrix wrote:
> On Wed, Apr 01, 2015 at 03:49:28PM -0400, Lennart Sorensen wrote:
> > On Wed, Apr 01, 2015 at 06:30:36PM +0200, Jan Kiszka wrote:
> > > By pulling everything that autoconf generates out of the repo, forcing
> > > the user of the git version to generate them yourself, you effectively
> > > made those files build outputs. As we cannot store them out-of-tree
> > > (like object files), we have to ignore them in-tree.
> > 
> > Certainly having them in .gitignore is a handy way to avoid them
> > accidentally being commited again, if someone has a habbit of doing git
> > commit -a.
> 
> git commit -a does not automatically add files to the repository. At
> least not with the default configuration. Besides, nobody in this
> thread is against the use of a .gitignore.

Oh right you are.  I was remembering wrong.

-- 
Len Sorensen


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2015-04-02 17:49 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <E1YdHjz-0005Rv-A3@sd-51317.xenomai.org>
2015-04-01 12:51 ` [Xenomai] [Xenomai-git] Jan Kiszka : Create gitignore for autotools files Gilles Chanteperdrix
2015-04-01 12:58   ` Philippe Gerum
2015-04-01 14:26     ` Jan Kiszka
2015-04-01 16:20       ` Philippe Gerum
2015-04-01 16:30         ` Jan Kiszka
2015-04-01 17:19           ` Philippe Gerum
2015-04-01 18:06             ` Jan Kiszka
2015-04-02  8:56               ` Gilles Chanteperdrix
2015-04-02  9:32                 ` Jan Kiszka
2015-04-02 11:42                   ` Gilles Chanteperdrix
2015-04-01 19:49           ` Lennart Sorensen
2015-04-02  8:38             ` Gilles Chanteperdrix
2015-04-02 17:49               ` Lennart Sorensen
2015-04-01 13:38   ` Lowell Gilbert
2015-04-01 14:24     ` Jan Kiszka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.