All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Fabio Estevam <festevam@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: Add simple read disturb test
Date: Thu, 02 Apr 2015 16:56:50 +0200	[thread overview]
Message-ID: <551D58B2.2050302@nod.at> (raw)
In-Reply-To: <CAOMZO5BpX0LHOmkPpsOHn+7x-VBzAnjuG0ed_n4OTe6_g0O2mQ@mail.gmail.com>

Am 02.04.2015 um 16:45 schrieb Fabio Estevam:
> On Thu, Apr 2, 2015 at 11:33 AM, Richard Weinberger <richard@nod.at> wrote:
> 
>> Why? Free()ing a NULL pointer is perfectly fine.
>> What did I miss? :)
> 
> If the first 'iobuf = kmalloc(mtd->erasesize, GFP_KERNEL);' fails then
> you jump to the out label where you call 5 kfree() and then return the
> error.
> 
> It would be much better just to return the error immediately in this
> case and add one label for each allocation error, so that it only
> kfree the previous successful allocations.

It is not *much* better. It is just a matter of taste.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Fabio Estevam <festevam@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: Add simple read disturb test
Date: Thu, 02 Apr 2015 16:56:50 +0200	[thread overview]
Message-ID: <551D58B2.2050302@nod.at> (raw)
In-Reply-To: <CAOMZO5BpX0LHOmkPpsOHn+7x-VBzAnjuG0ed_n4OTe6_g0O2mQ@mail.gmail.com>

Am 02.04.2015 um 16:45 schrieb Fabio Estevam:
> On Thu, Apr 2, 2015 at 11:33 AM, Richard Weinberger <richard@nod.at> wrote:
> 
>> Why? Free()ing a NULL pointer is perfectly fine.
>> What did I miss? :)
> 
> If the first 'iobuf = kmalloc(mtd->erasesize, GFP_KERNEL);' fails then
> you jump to the out label where you call 5 kfree() and then return the
> error.
> 
> It would be much better just to return the error immediately in this
> case and add one label for each allocation error, so that it only
> kfree the previous successful allocations.

It is not *much* better. It is just a matter of taste.

Thanks,
//richard

  reply	other threads:[~2015-04-02 14:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 14:13 [PATCH] mtd: Add simple read disturb test Richard Weinberger
2015-04-02 14:13 ` Richard Weinberger
2015-04-02 14:32 ` Fabio Estevam
2015-04-02 14:32   ` Fabio Estevam
2015-04-02 14:33   ` Richard Weinberger
2015-04-02 14:33     ` Richard Weinberger
2015-04-02 14:45     ` Fabio Estevam
2015-04-02 14:45       ` Fabio Estevam
2015-04-02 14:56       ` Richard Weinberger [this message]
2015-04-02 14:56         ` Richard Weinberger
2015-04-02 15:03         ` Fabio Estevam
2015-04-02 15:03           ` Fabio Estevam
2015-04-02 15:19           ` Richard Weinberger
2015-04-02 15:19             ` Richard Weinberger
2015-04-02 15:29   ` Richard Weinberger
2015-04-02 15:29     ` Richard Weinberger
2015-04-02 15:02 ` Fabio Estevam
2015-04-02 15:02   ` Fabio Estevam
2015-04-02 15:18   ` Richard Weinberger
2015-04-02 15:18     ` Richard Weinberger
2015-04-02 16:04 ` Brian Norris
2015-04-02 16:04   ` Brian Norris
2015-04-02 16:18   ` Richard Weinberger
2015-04-02 16:18     ` Richard Weinberger
2015-04-03  5:19     ` Andrea Scian
2015-04-12 19:31     ` Boris Brezillon
2015-04-12 19:31       ` Boris Brezillon
2015-10-13  0:11       ` Brian Norris
2015-10-19 21:11         ` Richard Weinberger
2015-10-20 13:22         ` Ezequiel Garcia
     [not found] <mailman.39315.1427996116.22890.linux-mtd@lists.infradead.org>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551D58B2.2050302@nod.at \
    --to=richard@nod.at \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.