All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: u.kleine-koenig@pengutronix.de, afaerber@suse.de,
	geert@linux-m68k.org, Rob Herring <robh+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl,
	andy.shevchenko@gmail.com, cw00.choi@samsung.com,
	Russell King <linux@arm.linux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Thomas Gleixner <tglx@linutronix.de>, Jiri Slaby <jslaby@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Joe Perches <joe@perches.com>, Antti Palosaari <crope@iki.fi>,
	Tejun Heo <tj@kernel.>
Subject: Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver
Date: Fri, 03 Apr 2015 13:29:44 -0400	[thread overview]
Message-ID: <551ECE08.8040407@hurleysoftware.com> (raw)
In-Reply-To: <1428080481-18591-11-git-send-email-mcoquelin.stm32@gmail.com>

On 04/03/2015 01:01 PM, Maxime Coquelin wrote:
> This drivers adds support to the STM32 USART controller, which is a
> standard serial driver.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

PS - I saw Rob's comment about 'hw-flow-ctrl' vs 'auto-flow-control'
and I'm ok with either so feel free to and my review comment to a v6
if that's the only change.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: u.kleine-koenig@pengutronix.de, afaerber@suse.de,
	geert@linux-m68k.org, Rob Herring <robh+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl,
	andy.shevchenko@gmail.com, cw00.choi@samsung.com,
	Russell King <linux@arm.linux.org.uk>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Thomas Gleixner <tglx@linutronix.de>, Jiri Slaby <jslaby@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Joe Perches <joe@perches.com>, Antti Palosaari <crope@iki.fi>,
	Tejun Heo <tj@kernel.org>, Will Deacon <will.deacon@arm.com>,
	Nikolay Borisov <Nikolay.Borisov@arm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Kees Cook <keescook@chromium.org>, Michal Marek <mmarek@suse.cz>,
	linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver
Date: Fri, 03 Apr 2015 13:29:44 -0400	[thread overview]
Message-ID: <551ECE08.8040407@hurleysoftware.com> (raw)
In-Reply-To: <1428080481-18591-11-git-send-email-mcoquelin.stm32@gmail.com>

On 04/03/2015 01:01 PM, Maxime Coquelin wrote:
> This drivers adds support to the STM32 USART controller, which is a
> standard serial driver.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

PS - I saw Rob's comment about 'hw-flow-ctrl' vs 'auto-flow-control'
and I'm ok with either so feel free to and my review comment to a v6
if that's the only change.

WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver
Date: Fri, 03 Apr 2015 13:29:44 -0400	[thread overview]
Message-ID: <551ECE08.8040407@hurleysoftware.com> (raw)
In-Reply-To: <1428080481-18591-11-git-send-email-mcoquelin.stm32@gmail.com>

On 04/03/2015 01:01 PM, Maxime Coquelin wrote:
> This drivers adds support to the STM32 USART controller, which is a
> standard serial driver.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

PS - I saw Rob's comment about 'hw-flow-ctrl' vs 'auto-flow-control'
and I'm ok with either so feel free to and my review comment to a v6
if that's the only change.

  reply	other threads:[~2015-04-03 17:29 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 17:01 [PATCH v5 00/15] Add support to STMicroelectronics STM32 family Maxime Coquelin
2015-04-03 17:01 ` Maxime Coquelin
2015-04-03 17:01 ` Maxime Coquelin
2015-04-03 17:01 ` [PATCH v5 02/15] ARM: ARMv7-M: Enlarge vector table up to 256 entries Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01 ` [PATCH v5 03/15] dt-bindings: Document the ARM System timer bindings Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:09   ` Rob Herring
2015-04-03 17:09     ` Rob Herring
2015-04-03 17:09     ` Rob Herring
2015-04-03 17:01 ` [PATCH v5 04/15] clocksource/drivers: Add ARM System timer driver Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01 ` [PATCH v5 05/15] dt-bindings: Document the STM32 reset bindings Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01 ` [PATCH v5 07/15] dt-bindings: Document the STM32 timer bindings Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:10   ` Rob Herring
2015-04-03 17:10     ` Rob Herring
2015-04-03 17:10     ` Rob Herring
2015-04-03 17:01 ` [PATCH v5 08/15] clockevents/drivers: Add STM32 Timer driver Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 22:09   ` Andy Shevchenko
2015-04-03 22:09     ` Andy Shevchenko
2015-04-03 22:09     ` Andy Shevchenko
     [not found]     ` <CAHp75VfPn_+sg_1iR_CdR2KuTyWcR+SKFsuHCbCkCKB0Oeqgfg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-03 22:14       ` Andy Shevchenko
2015-04-03 22:14         ` Andy Shevchenko
2015-04-03 22:14         ` Andy Shevchenko
2015-04-03 17:01 ` [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:29   ` Peter Hurley [this message]
2015-04-03 17:29     ` Peter Hurley
2015-04-03 17:29     ` Peter Hurley
     [not found]   ` <1428080481-18591-11-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-03 17:43     ` Joe Perches
2015-04-03 17:43       ` Joe Perches
2015-04-03 17:43       ` Joe Perches
2015-04-04 17:47       ` [PATCH] checkpatch: Add uart_ops to normally const structs Joe Perches
2015-04-07  7:55         ` Maxime Coquelin
2015-04-07  7:56       ` [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver Maxime Coquelin
2015-04-07  7:56         ` Maxime Coquelin
2015-04-07  7:56         ` Maxime Coquelin
2015-04-03 22:04   ` Andy Shevchenko
2015-04-03 22:04     ` Andy Shevchenko
2015-04-03 22:04     ` Andy Shevchenko
2015-04-07 16:05     ` Maxime Coquelin
2015-04-07 16:05       ` Maxime Coquelin
2015-04-07 16:05       ` Maxime Coquelin
     [not found] ` <1428080481-18591-1-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-03 17:01   ` [PATCH v5 01/15] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01   ` [PATCH v5 06/15] drivers: reset: Add STM32 reset driver Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01   ` [PATCH v5 09/15] dt-bindings: Document the STM32 USART bindings Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
     [not found]     ` <1428080481-18591-10-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-03 17:14       ` Rob Herring
2015-04-03 17:14         ` Rob Herring
2015-04-03 17:14         ` Rob Herring
2015-04-07 15:49         ` Maxime Coquelin
2015-04-07 15:49           ` Maxime Coquelin
2015-04-07 15:49           ` Maxime Coquelin
2015-04-03 17:01   ` [PATCH v5 11/15] ARM: Add STM32 family machine Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01   ` [PATCH v5 13/15] ARM: dts: Introduce STM32F429 MCU Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01   ` [PATCH v5 15/15] MAINTAINERS: Add entry for STM32 MCUs Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01     ` Maxime Coquelin
2015-04-03 17:01 ` [PATCH v5 12/15] ARM: dts: Add ARM System timer as clockevent in armv7m Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01 ` [PATCH v5 14/15] ARM: configs: Add STM32 defconfig Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin
2015-04-03 17:01   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551ECE08.8040407@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=afaerber@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=crope@iki.fi \
    --cc=cw00.choi@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=jslaby@suse.cz \
    --cc=linus.walleij@linaro.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@osg.samsung.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=pebolle@tiscali.nl \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel. \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.