All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Russell King <rmk+kernel@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Sekhar Nori <nsekhar@ti.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Tony Lindgren <tony@atomide.com>, Daniel Mack <daniel@zonque.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h
Date: Mon, 06 Apr 2015 19:04:21 +0000	[thread overview]
Message-ID: <5522D8B5.7050205@codeaurora.org> (raw)
In-Reply-To: <87lhi8rrmd.fsf@free.fr>

On 04/04/15 05:43, Robert Jarzmik wrote:
> Russell King <rmk+kernel@arm.linux.org.uk> writes:
>
>> clk_add_alias() is provided by clkdev, and is not part of the clk API.
>> Howver, it is prototyped in two locations: linux/clkdev.h and
>> linux/clk.h.  This is a mess.  Get rid of the redundant and unnecessary
>> version in linux/clk.h.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Actually, this serie fixes a regression I've seen in linux-next, and which was
> triggering the Oops in [1] on lubbock. With your serie, the kernel boots fine.
>
>

Is this with the lubbock_defconfig? Is it a regression in 4.0-rc series
or is it due to some pending -next patches interacting with the per-user
clock patches? It looks like the latter because __clk_get_hw() should be
inlined on lubbock_defconfig where CONFIG_COMMON_CLK=n.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project


WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Russell King <rmk+kernel@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Sekhar Nori <nsekhar@ti.com>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Tony Lindgren <tony@atomide.com>, Daniel Mack <daniel@zonque.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h
Date: Mon, 06 Apr 2015 12:04:21 -0700	[thread overview]
Message-ID: <5522D8B5.7050205@codeaurora.org> (raw)
In-Reply-To: <87lhi8rrmd.fsf@free.fr>

On 04/04/15 05:43, Robert Jarzmik wrote:
> Russell King <rmk+kernel@arm.linux.org.uk> writes:
>
>> clk_add_alias() is provided by clkdev, and is not part of the clk API.
>> Howver, it is prototyped in two locations: linux/clkdev.h and
>> linux/clk.h.  This is a mess.  Get rid of the redundant and unnecessary
>> version in linux/clk.h.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Actually, this serie fixes a regression I've seen in linux-next, and which was
> triggering the Oops in [1] on lubbock. With your serie, the kernel boots fine.
>
>

Is this with the lubbock_defconfig? Is it a regression in 4.0-rc series
or is it due to some pending -next patches interacting with the per-user
clock patches? It looks like the latter because __clk_get_hw() should be
inlined on lubbock_defconfig where CONFIG_COMMON_CLK=n.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project


WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h
Date: Mon, 06 Apr 2015 12:04:21 -0700	[thread overview]
Message-ID: <5522D8B5.7050205@codeaurora.org> (raw)
In-Reply-To: <87lhi8rrmd.fsf@free.fr>

On 04/04/15 05:43, Robert Jarzmik wrote:
> Russell King <rmk+kernel@arm.linux.org.uk> writes:
>
>> clk_add_alias() is provided by clkdev, and is not part of the clk API.
>> Howver, it is prototyped in two locations: linux/clkdev.h and
>> linux/clk.h.  This is a mess.  Get rid of the redundant and unnecessary
>> version in linux/clk.h.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Actually, this serie fixes a regression I've seen in linux-next, and which was
> triggering the Oops in [1] on lubbock. With your serie, the kernel boots fine.
>
>

Is this with the lubbock_defconfig? Is it a regression in 4.0-rc series
or is it due to some pending -next patches interacting with the per-user
clock patches? It looks like the latter because __clk_get_hw() should be
inlined on lubbock_defconfig where CONFIG_COMMON_CLK=n.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-04-06 19:04 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 17:11 [PATCH 00/14] Fix fallout from per-user struct clk patches Russell King - ARM Linux
2015-04-03 17:11 ` Russell King - ARM Linux
2015-04-03 17:11 ` Russell King - ARM Linux
2015-04-03 17:12 ` [PATCH 01/14] clk: update clk API documentation to clarify clk_round_rate() Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-07  8:47   ` [alsa-devel] " Ricard Wanderlof
2015-04-03 17:12 ` [PATCH 02/14] clkdev: drop __init from clkdev_add_table() Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12 ` [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 23:49   ` Tony Lindgren
2015-04-03 23:49     ` Tony Lindgren
2015-04-03 23:49     ` Tony Lindgren
2015-04-04 12:43   ` Robert Jarzmik
2015-04-04 12:43     ` Robert Jarzmik
2015-04-04 12:43     ` Robert Jarzmik
2015-04-04 12:43     ` Robert Jarzmik
2015-04-04 12:53     ` Russell King - ARM Linux
2015-04-04 12:53       ` Russell King - ARM Linux
2015-04-04 12:53       ` Russell King - ARM Linux
2015-04-06 19:04     ` Stephen Boyd [this message]
2015-04-06 19:04       ` Stephen Boyd
2015-04-06 19:04       ` Stephen Boyd
2015-04-07 10:05       ` Robert Jarzmik
2015-04-07 10:05         ` Robert Jarzmik
2015-04-07 10:05         ` Robert Jarzmik
2015-04-07 12:42       ` Russell King - ARM Linux
2015-04-07 12:42         ` Russell King - ARM Linux
2015-04-07 12:42         ` Russell King - ARM Linux
2015-04-06  5:50   ` Sekhar Nori
2015-04-06  5:51     ` Sekhar Nori
2015-04-06  5:50     ` Sekhar Nori
2015-04-06  5:50     ` Sekhar Nori
2015-04-03 17:12 ` [PATCH 04/14] clkdev: const-ify connection id to clk_add_alias() Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12 ` [PATCH 05/14] clkdev: use clk_hw internally Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-06 20:18   ` Stephen Boyd
2015-04-06 20:18     ` Stephen Boyd
2015-04-06 20:18     ` Stephen Boyd
2015-04-03 17:12 ` [PATCH 06/14] clkdev: add clkdev_create() helper Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-06 20:19   ` Stephen Boyd
2015-04-06 20:19     ` Stephen Boyd
2015-04-06 20:19     ` Stephen Boyd
2015-04-07 12:43     ` Russell King - ARM Linux
2015-04-07 12:43       ` Russell King - ARM Linux
2015-04-07 12:43       ` Russell King - ARM Linux
2015-04-07 23:09       ` Stephen Boyd
2015-04-07 23:09         ` Stephen Boyd
2015-04-07 23:09         ` Stephen Boyd
2015-04-03 17:12 ` [PATCH 07/14] media: omap3isp: remove unused clkdev Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 17:12   ` Russell King
2015-04-03 21:44   ` Laurent Pinchart
2015-04-03 21:44     ` Laurent Pinchart
2015-04-03 21:44     ` Laurent Pinchart
2015-04-05 14:20     ` Russell King - ARM Linux
2015-04-05 14:20       ` Russell King - ARM Linux
2015-04-05 14:20       ` Russell King - ARM Linux
2015-04-07  9:42       ` Laurent Pinchart
2015-04-07  9:42         ` Laurent Pinchart
2015-04-07  9:42         ` Laurent Pinchart
2015-04-07 12:45         ` Russell King - ARM Linux
2015-04-07 12:45           ` Russell King - ARM Linux
2015-04-07 12:45           ` Russell King - ARM Linux
2015-04-07 14:38           ` Laurent Pinchart
2015-04-07 14:38             ` Laurent Pinchart
2015-04-07 14:38             ` Laurent Pinchart
2015-04-03 17:13 ` [PATCH 08/14] SH: use clkdev_add_table() Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13 ` [PATCH 09/14] ARM: lpc32xx: convert to " Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13 ` [PATCH 10/14] ARM: orion: use clkdev_create() Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-04  0:17   ` Andrew Lunn
2015-04-04  0:17     ` Andrew Lunn
2015-04-04  0:17     ` Andrew Lunn
2015-04-07 13:20     ` Gregory CLEMENT
2015-04-07 13:20       ` Gregory CLEMENT
2015-04-07 13:20       ` Gregory CLEMENT
2015-04-07 14:01       ` Russell King - ARM Linux
2015-04-07 14:01         ` Russell King - ARM Linux
2015-04-07 14:01         ` Russell King - ARM Linux
2015-04-07 14:20         ` Gregory CLEMENT
2015-04-07 14:20           ` Gregory CLEMENT
2015-04-07 14:20           ` Gregory CLEMENT
2015-04-03 17:13 ` [PATCH 11/14] ARM: omap2: " Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 23:49   ` Tony Lindgren
2015-04-03 23:49     ` Tony Lindgren
2015-04-03 23:49     ` Tony Lindgren
2015-04-03 17:13 ` [PATCH 12/14] ARM: omap2: use clkdev_add_alias() Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 23:50   ` Tony Lindgren
2015-04-03 23:50     ` Tony Lindgren
2015-04-03 23:50     ` Tony Lindgren
2015-04-03 17:13 ` [PATCH 13/14] ASoC: migor: use clkdev_create() Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13 ` [PATCH 14/14] clk: s2mps11: " Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:13   ` Russell King
2015-04-03 17:16 ` [PATCH 00/14] Fix fallout from per-user struct clk patches Russell King - ARM Linux
2015-04-03 17:16   ` Russell King - ARM Linux
2015-04-03 17:16   ` Russell King - ARM Linux
2015-04-05  9:04 ` Geert Uytterhoeven
2015-04-05  9:04   ` Geert Uytterhoeven
2015-04-05  9:04   ` Geert Uytterhoeven
2015-04-05  9:04   ` Geert Uytterhoeven
2015-04-05 14:13   ` Russell King - ARM Linux
2015-04-05 14:13     ` Russell King - ARM Linux
2015-04-05 14:13     ` Russell King - ARM Linux
2015-04-05 14:13     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5522D8B5.7050205@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=robert.jarzmik@free.fr \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.