From: Hannes Reinecke <hare@suse.de>
To: "Narsimhulu Musini (nmusini)" <nmusini@cisco.com>,
"JBottomley@Parallels.com" <JBottomley@Parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "Sesidhar Baddela (sebaddel)" <sebaddel@cisco.com>
Subject: Re: [PATCH v2 6/9] snic:Add low level queuing interfaces
Date: Tue, 07 Apr 2015 08:38:43 +0200 [thread overview]
Message-ID: <55237B73.7080702@suse.de> (raw)
In-Reply-To: <D142F680.1D3FD%nmusini@cisco.com>
On 04/02/2015 10:13 AM, Narsimhulu Musini (nmusini) wrote:
> Hi Hannes,
>
> Thank you for reviewing the patch. Please find responses inline.
> I will incorporate the comments and suggestions in next patch submittal.
>
>
> On 25/03/15 4:43 pm, "Hannes Reinecke" <hare@suse.de> wrote:
>
>> Hi Narsimhulu,
>>
>> On 03/11/2015 06:01 PM, Narsimhulu Musini wrote:
>>> These files contain low level queueing interfaces includes
>>> hardware queues, and management of hardware features.
>>>
>>> v2
>>> driver supports x86-64 arch, so removed cpu_to_XX API to maintain
>>> consistency.
>>>
>>> Signed-off-by: Narsimhulu Musini <nmusini@cisco.com>
>>> Signed-off-by: Sesidhar Baddela <sebaddel@cisco.com>
>>> ---
>> Please find some comments below.
>>
[ .. ]
>> That really looks like a 64bit structure read in as 32bit values ...
>> If so please use 64bit values here ...
> The structure members are aligned to hardware data, I would prefer to keep
> it same.
>
I _know_ that they are aligned.
The point of my question was whether these values are _real_ 32-bit
values or rather 64-bit values with the top 32-bit masked off.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-07 6:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 17:01 [PATCH v2 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini
2015-03-11 17:01 ` [PATCH v2 1/9] snic: snic module infrastructure Narsimhulu Musini
2015-03-12 0:54 ` Julian Calaby
[not found] ` <C243A617-47A8-4568-A8ED-2E343812ADA9@cisco.com>
2015-03-12 1:43 ` Julian Calaby
2015-03-12 1:56 ` Narsimhulu Musini (nmusini)
2015-03-25 10:05 ` Hannes Reinecke
2015-03-11 17:01 ` [PATCH v2 2/9] snic:Add interrupt, resource firmware interfaces Narsimhulu Musini
2015-03-25 10:18 ` Hannes Reinecke
2015-04-02 7:48 ` Narsimhulu Musini (nmusini)
2015-04-07 6:27 ` Hannes Reinecke
2015-04-08 8:58 ` Narsimhulu Musini (nmusini)
2015-03-11 17:01 ` [PATCH v2 3/9] snic:Add meta request, handling of meta requests Narsimhulu Musini
2015-03-25 10:32 ` Hannes Reinecke
2015-04-02 7:53 ` Narsimhulu Musini (nmusini)
2015-03-11 17:01 ` [PATCH v2 4/9] snic:Add snic target discovery Narsimhulu Musini
2015-03-25 10:36 ` Hannes Reinecke
2015-03-11 17:01 ` [PATCH v2 5/9] snic:add SCSI handling, AEN, and fwreset handling Narsimhulu Musini
2015-03-25 11:01 ` Hannes Reinecke
2015-04-02 8:06 ` Narsimhulu Musini (nmusini)
2015-03-11 17:01 ` [PATCH v2 6/9] snic:Add low level queuing interfaces Narsimhulu Musini
2015-03-25 11:13 ` Hannes Reinecke
2015-04-02 8:13 ` Narsimhulu Musini (nmusini)
2015-04-07 6:38 ` Hannes Reinecke [this message]
2015-04-08 9:05 ` Narsimhulu Musini (nmusini)
2015-04-08 9:07 ` Hannes Reinecke
2015-03-11 17:01 ` [PATCH v2 7/9] snic:Add sysfs entries to list stats and trace data Narsimhulu Musini
2015-03-25 11:14 ` Hannes Reinecke
2015-03-11 17:01 ` [PATCH v2 8/9] snic:Add event tracing to capture IO events Narsimhulu Musini
2015-03-25 11:15 ` Hannes Reinecke
2015-03-11 17:01 ` [PATCH v2 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS Narsimhulu Musini
2015-03-25 11:16 ` Hannes Reinecke
2015-04-02 8:16 ` Narsimhulu Musini (nmusini)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55237B73.7080702@suse.de \
--to=hare@suse.de \
--cc=JBottomley@Parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.