Re: [PATCH v2 1/9] snic: snic module infrastructure

["Narsimhulu Musini (nmusini)" <nmusini@cisco.com>]

Hi Julian Calby,

  Sure, thanks.

Thanks
Narsimhulu

On 12/03/15 7:13 am, "Julian Calaby" <julian.calaby@gmail.com> wrote:

>Hi simha,
>
>On Thu, Mar 12, 2015 at 12:37 PM, Narsimhulu Musini (nmusini)
><nmusini@cisco.com> wrote:
>> Hi,
>>
>>   Thanks for pointing the change log location. Do you suggest to
>>resubmit the entire patch series with v2. If you find some time, Could
>>you please review the patch.
>
>Firstly, please don't top post (i.e. post above the reply) and please
>don't take discussions off list. (always reply-to-all)
>
>I can almost guarantee that you'll get more comments, so wait for
>other people to review it first.
>
>I don't know the SCSI code well enough to do a useful technical
>review, so I only review for basic style issues.
>
>Thanks,
>
>Julian Calaby
>
>
>> Thanks
>> simha
>>
>>
>> On 12-Mar-2015, at 6:24 am, Julian Calaby <julian.calaby@gmail.com>
>>wrote:
>>
>>> Hi,
>>>
>>> On Thu, Mar 12, 2015 at 4:01 AM, Narsimhulu Musini <nmusini@cisco.com>
>>>wrote:
>>>> snic_main.c contains module load and unload, global driver context,
>>>> PCI Registration, PCI probe and remove, SCSI ML registration
>>>>functionality.
>>>>
>>>> snic.h contains snic structure definition, snic global context, and
>>>> prototypes.
>>>>
>>>> snic_os.h contains OS specific interfaces.
>>>>
>>>> snic_attrs.c contains device attributes to list snic state, link
>>>>state,
>>>> and driver version under /sys/class/scsi_host/host<id>/
>>>>
>>>> v2
>>>> Added Compile time macro for debugfs dependent functionality.
>>>
>>> Your changelog should be below the "---" and before the diffstat.
>>>
>>>> Signed-off-by: Narsimhulu Musini <nmusini@cisco.com>
>>>> Signed-off-by: Sesidhar Baddela <sebaddel@cisco.com>
>>>> ---
>>>
>>> I.e. here.
>>>
>>>> drivers/scsi/snic/snic.h       |  421 +++++++++++++++++
>>>> drivers/scsi/snic/snic_attrs.c |   80 ++++
>>>> drivers/scsi/snic/snic_main.c  | 1022
>>>>++++++++++++++++++++++++++++++++++++++++
>>>> drivers/scsi/snic/snic_os.h    |   81 ++++
>>>> 4 files changed, 1604 insertions(+)
>>>> create mode 100644 drivers/scsi/snic/snic.h
>>>> create mode 100644 drivers/scsi/snic/snic_attrs.c
>>>> create mode 100644 drivers/scsi/snic/snic_main.c
>>>> create mode 100644 drivers/scsi/snic/snic_os.h
>>>
>>> Thanks,
>>>
>>> --
>>> Julian Calaby
>>>
>>> Email: julian.calaby@gmail.com
>>> Profile: http://www.google.com/profiles/julian.calaby/
>>
>
>
>
>-- 
>Julian Calaby
>
>Email: julian.calaby@gmail.com
>Profile: http://www.google.com/profiles/julian.calaby/