All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] [patch 5/9] ocfs2: clear the rest of the buffers on error
@ 2015-04-07 21:55 akpm at linux-foundation.org
  0 siblings, 0 replies; only message in thread
From: akpm at linux-foundation.org @ 2015-04-07 21:55 UTC (permalink / raw)
  To: ocfs2-devel

From: Goldwyn Rodrigues <rgoldwyn@suse.de>
Subject: ocfs2: clear the rest of the buffers on error

In case a validation fails, clear the rest of the buffers and return the
error to the calling function.

This also facilitates bubbling up the error originating from ocfs2_error
to calling functions.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/ocfs2/buffer_head_io.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff -puN fs/ocfs2/buffer_head_io.c~clear-the-rest-of-the-buffers-on-error fs/ocfs2/buffer_head_io.c
--- a/fs/ocfs2/buffer_head_io.c~clear-the-rest-of-the-buffers-on-error
+++ a/fs/ocfs2/buffer_head_io.c
@@ -316,6 +316,12 @@ int ocfs2_read_blocks(struct ocfs2_cachi
 		bh = bhs[i];
 
 		if (!(flags & OCFS2_BH_READAHEAD)) {
+			if (status) {
+				/* Clear the rest of the buffers on error */
+				put_bh(bh);
+				bhs[i] = NULL;
+				continue;
+			}
 			/* We know this can't have changed as we hold the
 			 * owner sem. Avoid doing any work on the bh if the
 			 * journal has it. */
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-04-07 21:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-07 21:55 [Ocfs2-devel] [patch 5/9] ocfs2: clear the rest of the buffers on error akpm at linux-foundation.org

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.