* [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-03 10:03 ` Frederic Danis
0 siblings, 0 replies; 16+ messages in thread
From: Frederic Danis @ 2015-04-03 10:03 UTC (permalink / raw)
To: linux-serial, linux-bluetooth, peter
This is a partial revert of patch "tty: Remove external interface for
tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
set tty_set_termios() publicly available.
This will be needed by Bluetooth hci_uart module to be able to change
Bluetooth controller and local UART speed during vendor specific
initialization.
Signed-off-by: Frederic Danis <frederic.danis@linux.intel.com>
---
drivers/tty/tty_ioctl.c | 3 ++-
include/linux/tty.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 632fc81..8e53fe4 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -536,7 +536,7 @@ EXPORT_SYMBOL(tty_termios_hw_change);
* Locking: termios_rwsem
*/
-static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
{
struct ktermios old_termios;
struct tty_ldisc *ld;
@@ -569,6 +569,7 @@ static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
up_write(&tty->termios_rwsem);
return 0;
}
+EXPORT_SYMBOL_GPL(tty_set_termios);
/**
* set_termios - set termios values for a tty
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 358a337..fe5623c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -491,6 +491,7 @@ static inline speed_t tty_get_baud_rate(struct tty_struct *tty)
extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
+extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);
extern struct tty_ldisc *tty_ldisc_ref(struct tty_struct *);
extern void tty_ldisc_deref(struct tty_ldisc *);
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-03 10:03 ` Frederic Danis
0 siblings, 0 replies; 16+ messages in thread
From: Frederic Danis @ 2015-04-03 10:03 UTC (permalink / raw)
To: linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8
This is a partial revert of patch "tty: Remove external interface for
tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
set tty_set_termios() publicly available.
This will be needed by Bluetooth hci_uart module to be able to change
Bluetooth controller and local UART speed during vendor specific
initialization.
Signed-off-by: Frederic Danis <frederic.danis-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/tty/tty_ioctl.c | 3 ++-
include/linux/tty.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 632fc81..8e53fe4 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -536,7 +536,7 @@ EXPORT_SYMBOL(tty_termios_hw_change);
* Locking: termios_rwsem
*/
-static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
{
struct ktermios old_termios;
struct tty_ldisc *ld;
@@ -569,6 +569,7 @@ static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
up_write(&tty->termios_rwsem);
return 0;
}
+EXPORT_SYMBOL_GPL(tty_set_termios);
/**
* set_termios - set termios values for a tty
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 358a337..fe5623c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -491,6 +491,7 @@ static inline speed_t tty_get_baud_rate(struct tty_struct *tty)
extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
+extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);
extern struct tty_ldisc *tty_ldisc_ref(struct tty_struct *);
extern void tty_ldisc_deref(struct tty_ldisc *);
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-03 10:30 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-03 10:30 UTC (permalink / raw)
To: Frederic Danis, linux-serial, linux-bluetooth
Hi Frederic,
On 04/03/2015 06:03 AM, Frederic Danis wrote:
> This is a partial revert of patch "tty: Remove external interface for
> tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
> set tty_set_termios() publicly available.
>
> This will be needed by Bluetooth hci_uart module to be able to change
> Bluetooth controller and local UART speed during vendor specific
> initialization.
NAK.
1. Where is this _proposed_ usage?
2. The HCI line discipline has no business changing the line rate.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-03 10:30 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-03 10:30 UTC (permalink / raw)
To: Frederic Danis, linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA
Hi Frederic,
On 04/03/2015 06:03 AM, Frederic Danis wrote:
> This is a partial revert of patch "tty: Remove external interface for
> tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
> set tty_set_termios() publicly available.
>
> This will be needed by Bluetooth hci_uart module to be able to change
> Bluetooth controller and local UART speed during vendor specific
> initialization.
NAK.
1. Where is this _proposed_ usage?
2. The HCI line discipline has no business changing the line rate.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-03 11:49 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-03 11:49 UTC (permalink / raw)
To: Frederic Danis; +Cc: linux-serial, linux-bluetooth, Greg KH, Jiri Slaby
[ +cc GregKH, JiriS ]
On 04/03/2015 06:30 AM, Peter Hurley wrote:
> Hi Frederic,
>
> On 04/03/2015 06:03 AM, Frederic Danis wrote:
>> This is a partial revert of patch "tty: Remove external interface for
>> tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
>> set tty_set_termios() publicly available.
>>
>> This will be needed by Bluetooth hci_uart module to be able to change
>> Bluetooth controller and local UART speed during vendor specific
>> initialization.
>
> NAK.
>
> 1. Where is this _proposed_ usage?
Found it. RFC series in linux-bluetooth.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-03 11:49 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-03 11:49 UTC (permalink / raw)
To: Frederic Danis
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA, Greg KH, Jiri Slaby
[ +cc GregKH, JiriS ]
On 04/03/2015 06:30 AM, Peter Hurley wrote:
> Hi Frederic,
>
> On 04/03/2015 06:03 AM, Frederic Danis wrote:
>> This is a partial revert of patch "tty: Remove external interface for
>> tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
>> set tty_set_termios() publicly available.
>>
>> This will be needed by Bluetooth hci_uart module to be able to change
>> Bluetooth controller and local UART speed during vendor specific
>> initialization.
>
> NAK.
>
> 1. Where is this _proposed_ usage?
Found it. RFC series in linux-bluetooth.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-10 12:13 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-10 12:13 UTC (permalink / raw)
To: Frederic Danis; +Cc: linux-serial, linux-bluetooth
On 04/03/2015 06:03 AM, Frederic Danis wrote:
> This is a partial revert of patch "tty: Remove external interface for
> tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
> set tty_set_termios() publicly available.
>
> This will be needed by Bluetooth hci_uart module to be able to change
> Bluetooth controller and local UART speed during vendor specific
> initialization.
Please resend to tty maintainers (and cc me).
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Patch] tty: Re-add external interface for tty_set_termios()
@ 2015-04-10 12:13 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-10 12:13 UTC (permalink / raw)
To: Frederic Danis
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA
On 04/03/2015 06:03 AM, Frederic Danis wrote:
> This is a partial revert of patch "tty: Remove external interface for
> tty_set_termios()" from Peter Hurley (2015-01-25 SHA1 632f32e2107) to
> set tty_set_termios() publicly available.
>
> This will be needed by Bluetooth hci_uart module to be able to change
> Bluetooth controller and local UART speed during vendor specific
> initialization.
Please resend to tty maintainers (and cc me).
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-21 16:04 ` Marcel Holtmann
0 siblings, 0 replies; 16+ messages in thread
From: Marcel Holtmann @ 2015-04-21 16:04 UTC (permalink / raw)
To: Greg KH
Cc: Peter Hurley, Frederic Danis, linux-serial,
bluez mailin list (linux-bluetooth@vger.kernel.org),
jslaby
Hi Greg,
>>> This is needed by Bluetooth hci_uart module to be able to change speed
>>> of Bluetooth controller and local UART.
>>
>> Because this is the lesser evil right now,
>>
>> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
>
> Does this need to be in 4.1-rc1? Or is this a 4.2 thing?
if you can queue this up for 4.1-rc1, that would be great. We are using it. It is just the driver using it did not make it to 4.0-rc1 yet.
Regards
Marcel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-21 16:04 ` Marcel Holtmann
0 siblings, 0 replies; 16+ messages in thread
From: Marcel Holtmann @ 2015-04-21 16:04 UTC (permalink / raw)
To: Greg KH
Cc: Peter Hurley, Frederic Danis,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
bluez mailin list
(linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
jslaby-AlSwsSmVLrQ
Hi Greg,
>>> This is needed by Bluetooth hci_uart module to be able to change speed
>>> of Bluetooth controller and local UART.
>>
>> Because this is the lesser evil right now,
>>
>> Reviewed-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
>
> Does this need to be in 4.1-rc1? Or is this a 4.2 thing?
if you can queue this up for 4.1-rc1, that would be great. We are using it. It is just the driver using it did not make it to 4.0-rc1 yet.
Regards
Marcel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-21 9:06 ` Greg KH
0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2015-04-21 9:06 UTC (permalink / raw)
To: Peter Hurley; +Cc: Frederic Danis, linux-serial, linux-bluetooth, jslaby
On Fri, Apr 10, 2015 at 09:24:11AM -0400, Peter Hurley wrote:
> On 04/10/2015 09:13 AM, Frederic Danis wrote:
> > This is needed by Bluetooth hci_uart module to be able to change speed
> > of Bluetooth controller and local UART.
>
> Because this is the lesser evil right now,
>
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Does this need to be in 4.1-rc1? Or is this a 4.2 thing?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-21 9:06 ` Greg KH
0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2015-04-21 9:06 UTC (permalink / raw)
To: Peter Hurley
Cc: Frederic Danis, linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA, jslaby-AlSwsSmVLrQ
On Fri, Apr 10, 2015 at 09:24:11AM -0400, Peter Hurley wrote:
> On 04/10/2015 09:13 AM, Frederic Danis wrote:
> > This is needed by Bluetooth hci_uart module to be able to change speed
> > of Bluetooth controller and local UART.
>
> Because this is the lesser evil right now,
>
> Reviewed-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
Does this need to be in 4.1-rc1? Or is this a 4.2 thing?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-10 13:24 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-10 13:24 UTC (permalink / raw)
To: Frederic Danis, gregkh; +Cc: linux-serial, linux-bluetooth, jslaby
On 04/10/2015 09:13 AM, Frederic Danis wrote:
> This is needed by Bluetooth hci_uart module to be able to change speed
> of Bluetooth controller and local UART.
Because this is the lesser evil right now,
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-10 13:24 ` Peter Hurley
0 siblings, 0 replies; 16+ messages in thread
From: Peter Hurley @ 2015-04-10 13:24 UTC (permalink / raw)
To: Frederic Danis, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA, jslaby-AlSwsSmVLrQ
On 04/10/2015 09:13 AM, Frederic Danis wrote:
> This is needed by Bluetooth hci_uart module to be able to change speed
> of Bluetooth controller and local UART.
Because this is the lesser evil right now,
Reviewed-by: Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-10 13:13 ` Frederic Danis
0 siblings, 0 replies; 16+ messages in thread
From: Frederic Danis @ 2015-04-10 13:13 UTC (permalink / raw)
To: linux-serial, linux-bluetooth, gregkh, jslaby; +Cc: peter
This is needed by Bluetooth hci_uart module to be able to change speed
of Bluetooth controller and local UART.
Signed-off-by: Frederic Danis <frederic.danis@linux.intel.com>
---
Re-send this patch on Peter Hurley request
drivers/tty/tty_ioctl.c | 3 ++-
include/linux/tty.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 632fc81..8e53fe4 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -536,7 +536,7 @@ EXPORT_SYMBOL(tty_termios_hw_change);
* Locking: termios_rwsem
*/
-static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
{
struct ktermios old_termios;
struct tty_ldisc *ld;
@@ -569,6 +569,7 @@ static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
up_write(&tty->termios_rwsem);
return 0;
}
+EXPORT_SYMBOL_GPL(tty_set_termios);
/**
* set_termios - set termios values for a tty
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 358a337..fe5623c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -491,6 +491,7 @@ static inline speed_t tty_get_baud_rate(struct tty_struct *tty)
extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
+extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);
extern struct tty_ldisc *tty_ldisc_ref(struct tty_struct *);
extern void tty_ldisc_deref(struct tty_ldisc *);
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] tty: Re-add external interface for tty_set_termios()
@ 2015-04-10 13:13 ` Frederic Danis
0 siblings, 0 replies; 16+ messages in thread
From: Frederic Danis @ 2015-04-10 13:13 UTC (permalink / raw)
To: linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, jslaby-AlSwsSmVLrQ
Cc: peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8
This is needed by Bluetooth hci_uart module to be able to change speed
of Bluetooth controller and local UART.
Signed-off-by: Frederic Danis <frederic.danis-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
Re-send this patch on Peter Hurley request
drivers/tty/tty_ioctl.c | 3 ++-
include/linux/tty.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 632fc81..8e53fe4 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -536,7 +536,7 @@ EXPORT_SYMBOL(tty_termios_hw_change);
* Locking: termios_rwsem
*/
-static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
{
struct ktermios old_termios;
struct tty_ldisc *ld;
@@ -569,6 +569,7 @@ static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
up_write(&tty->termios_rwsem);
return 0;
}
+EXPORT_SYMBOL_GPL(tty_set_termios);
/**
* set_termios - set termios values for a tty
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 358a337..fe5623c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -491,6 +491,7 @@ static inline speed_t tty_get_baud_rate(struct tty_struct *tty)
extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
+extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);
extern struct tty_ldisc *tty_ldisc_ref(struct tty_struct *);
extern void tty_ldisc_deref(struct tty_ldisc *);
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
end of thread, other threads:[~2015-04-21 16:04 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-03 10:03 [Patch] tty: Re-add external interface for tty_set_termios() Frederic Danis
2015-04-03 10:03 ` Frederic Danis
2015-04-03 10:30 ` Peter Hurley
2015-04-03 10:30 ` Peter Hurley
2015-04-03 11:49 ` Peter Hurley
2015-04-03 11:49 ` Peter Hurley
2015-04-10 12:13 ` Peter Hurley
2015-04-10 12:13 ` Peter Hurley
2015-04-10 13:13 [PATCH] " Frederic Danis
2015-04-10 13:13 ` Frederic Danis
2015-04-10 13:24 ` Peter Hurley
2015-04-10 13:24 ` Peter Hurley
2015-04-21 9:06 ` Greg KH
2015-04-21 9:06 ` Greg KH
2015-04-21 16:04 ` Marcel Holtmann
2015-04-21 16:04 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.