* [U-Boot] [PATCH v2] ARM: fix arch/arm/Makefile for Tegra
@ 2015-04-11 15:58 Masahiro Yamada
2015-04-11 16:05 ` Tom Rini
2015-04-12 3:39 ` Stephen Warren
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2015-04-11 15:58 UTC (permalink / raw)
To: u-boot
Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to
arch/arm/Makefile), all the Tegra boards are broken because the SPL
is built for ARMv7.
Insert Tegra-specific code to arch/arm/Makefile to set compiler
flags for an earlier ARM architecture.
Note:
The v1 patch for commit 79d75d752717 *was* correct when it was
submitted. Notice it was originally written for multi .config
configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for
Tegra U-Boot Main/SPL, respectively. But, until it was merged into
the mainline, commit e02ee2548afe (kconfig: switch to single .config
configuration) had been already applied there.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reported-by: Stephen Warren <swarren@nvidia.com>
Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
Tested-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Changes in v2:
- Brush up the commit-description because V1 had a typo (s/look/took/)
- Add Jan's Tested-by credit
arch/arm/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 6463c19..bd4749c 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -2,6 +2,11 @@
# SPDX-License-Identifier: GPL-2.0+
#
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TEGRA),yy)
+CONFIG_CPU_V7=
+CONFIG_CPU_ARM720T=y
+endif
+
# This selects which instruction set is used.
arch-$(CONFIG_CPU_ARM720T) =-march=armv4
arch-$(CONFIG_CPU_ARM920T) =-march=armv4
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2] ARM: fix arch/arm/Makefile for Tegra
2015-04-11 15:58 [U-Boot] [PATCH v2] ARM: fix arch/arm/Makefile for Tegra Masahiro Yamada
@ 2015-04-11 16:05 ` Tom Rini
2015-04-12 3:39 ` Stephen Warren
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2015-04-11 16:05 UTC (permalink / raw)
To: u-boot
On Sun, Apr 12, 2015 at 12:58:14AM +0900, Masahiro Yamada wrote:
> Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to
> arch/arm/Makefile), all the Tegra boards are broken because the SPL
> is built for ARMv7.
>
> Insert Tegra-specific code to arch/arm/Makefile to set compiler
> flags for an earlier ARM architecture.
>
> Note:
> The v1 patch for commit 79d75d752717 *was* correct when it was
> submitted. Notice it was originally written for multi .config
> configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for
> Tegra U-Boot Main/SPL, respectively. But, until it was merged into
> the mainline, commit e02ee2548afe (kconfig: switch to single .config
> configuration) had been already applied there.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reported-by: Stephen Warren <swarren@nvidia.com>
> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Tested-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150411/2f56d389/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2] ARM: fix arch/arm/Makefile for Tegra
2015-04-11 15:58 [U-Boot] [PATCH v2] ARM: fix arch/arm/Makefile for Tegra Masahiro Yamada
2015-04-11 16:05 ` Tom Rini
@ 2015-04-12 3:39 ` Stephen Warren
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2015-04-12 3:39 UTC (permalink / raw)
To: u-boot
On 04/11/2015 09:58 AM, Masahiro Yamada wrote:
> Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to
> arch/arm/Makefile), all the Tegra boards are broken because the SPL
> is built for ARMv7.
>
> Insert Tegra-specific code to arch/arm/Makefile to set compiler
> flags for an earlier ARM architecture.
>
> Note:
> The v1 patch for commit 79d75d752717 *was* correct when it was
> submitted. Notice it was originally written for multi .config
> configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for
> Tegra U-Boot Main/SPL, respectively. But, until it was merged into
> the mainline, commit e02ee2548afe (kconfig: switch to single .config
> configuration) had been already applied there.
Tested-by: Stephen Warren <swarren@wwwdotorg.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-12 3:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-11 15:58 [U-Boot] [PATCH v2] ARM: fix arch/arm/Makefile for Tegra Masahiro Yamada
2015-04-11 16:05 ` Tom Rini
2015-04-12 3:39 ` Stephen Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.