From: Michal Simek <monstr@monstr.eu>
To: Peter Hurley <peter@hurleysoftware.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration
Date: Tue, 14 Apr 2015 07:12:11 +0200 [thread overview]
Message-ID: <552CA1AB.1050608@monstr.eu> (raw)
In-Reply-To: <552BE5B8.4050204@hurleysoftware.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On 04/13/2015 05:50 PM, Peter Hurley wrote:
> [ + Arnd ]
>
> Hi Michal,
>
> On 04/13/2015 10:35 AM, Michal Simek wrote:
>> Do not probe all serial drivers by of_serial.c which are using
>> device_type = "serial"; property. Only drivers which have valid
>> compatible strings listed in the driver should be probed.
>
> What does this fix?
> Is there some kind of probe problem you're trying to address?
> Are you trying to silence the error message?
>
>> When PORT_UNKNOWN probe will fail anyway.
>
> Ok, but doesn't device_attach() just continue to try to match other
> drivers on the platform bus?
Please look at my response to Greg reply. Hope that explain it.
Thanks,
Michal
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-04-14 5:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 14:35 [PATCH] serial: of-serial: Remove device_type = "serial" registration Michal Simek
2015-04-13 15:50 ` Peter Hurley
2015-04-13 15:50 ` Peter Hurley
2015-04-14 5:12 ` Michal Simek [this message]
2015-04-13 17:00 ` Greg Kroah-Hartman
2015-04-14 5:10 ` Michal Simek
2015-04-14 7:38 ` Greg Kroah-Hartman
2015-04-14 10:04 ` Michal Simek
2015-04-14 10:04 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552CA1AB.1050608@monstr.eu \
--to=monstr@monstr.eu \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peter@hurleysoftware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.