All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Simek <michal.simek@xilinx.com>,
	linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: Arnd Bergmann <arnd@arndb.de>,
	stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration
Date: Mon, 13 Apr 2015 11:50:16 -0400	[thread overview]
Message-ID: <552BE5B8.4050204@hurleysoftware.com> (raw)
In-Reply-To: <b8ba9c125be49a8a70a04807179c5f7fe79b1ae0.1428935724.git.michal.simek@xilinx.com>

[ + Arnd ]

Hi Michal,

On 04/13/2015 10:35 AM, Michal Simek wrote:
> Do not probe all serial drivers by of_serial.c which are using
> device_type = "serial"; property. Only drivers which have valid
> compatible strings listed in the driver should be probed.

What does this fix?
Is there some kind of probe problem you're trying to address?
Are you trying to silence the error message?

> When PORT_UNKNOWN probe will fail anyway.

Ok, but doesn't device_attach() just continue to try to match other
drivers on the platform bus?

Regards,
Peter Hurley

> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> CC: <stable@vger.kernel.org>
> ---
> 
>  drivers/tty/serial/of_serial.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 33fb94f78967..0a52c8b55a5f 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = {
>  	{ .compatible = "ibm,qpace-nwp-serial",
>  		.data = (void *)PORT_NWPSERIAL, },
>  #endif
> -	{ .type = "serial",         .data = (void *)PORT_UNKNOWN, },
>  	{ /* end of list */ },
>  };
>  
> 


WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Simek <michal.simek@xilinx.com>,
	linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: Arnd Bergmann <arnd@arndb.de>,
	stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org,
	Jiri Slaby <jslaby@suse.cz>Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration
Date: Mon, 13 Apr 2015 11:50:16 -0400	[thread overview]
Message-ID: <552BE5B8.4050204@hurleysoftware.com> (raw)
In-Reply-To: <b8ba9c125be49a8a70a04807179c5f7fe79b1ae0.1428935724.git.michal.simek@xilinx.com>

[ + Arnd ]

Hi Michal,

On 04/13/2015 10:35 AM, Michal Simek wrote:
> Do not probe all serial drivers by of_serial.c which are using
> device_type = "serial"; property. Only drivers which have valid
> compatible strings listed in the driver should be probed.

What does this fix?
Is there some kind of probe problem you're trying to address?
Are you trying to silence the error message?

> When PORT_UNKNOWN probe will fail anyway.

Ok, but doesn't device_attach() just continue to try to match other
drivers on the platform bus?

Regards,
Peter Hurley

> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> CC: <stable@vger.kernel.org>
> ---
> 
>  drivers/tty/serial/of_serial.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 33fb94f78967..0a52c8b55a5f 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = {
>  	{ .compatible = "ibm,qpace-nwp-serial",
>  		.data = (void *)PORT_NWPSERIAL, },
>  #endif
> -	{ .type = "serial",         .data = (void *)PORT_UNKNOWN, },
>  	{ /* end of list */ },
>  };
>  
> 

  reply	other threads:[~2015-04-13 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 14:35 [PATCH] serial: of-serial: Remove device_type = "serial" registration Michal Simek
2015-04-13 15:50 ` Peter Hurley [this message]
2015-04-13 15:50   ` Peter Hurley
2015-04-14  5:12   ` Michal Simek
2015-04-13 17:00 ` Greg Kroah-Hartman
2015-04-14  5:10   ` Michal Simek
2015-04-14  7:38     ` Greg Kroah-Hartman
2015-04-14 10:04       ` Michal Simek
2015-04-14 10:04         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552BE5B8.4050204@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.