All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14  4:24 ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-04-14  4:24 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, linux-kernel, Guenter Roeck, Martin Sperl

Fix:

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error:
			dereferencing pointer to incomplete type
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:2: error:
	`		implicit declaration of function 'gpiochip_find'
drivers/spi/spi-bcm2835.c:387:21: error:
			dereferencing pointer to incomplete type

by adding the now mandatory GPIOLIB dependency.

Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
	on first spi_setup")
Cc: Martin Sperl <kernel@martin.sperl.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 198f96b7fb45..a132180a9251 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -78,6 +78,7 @@ config SPI_ATMEL
 config SPI_BCM2835
 	tristate "BCM2835 SPI controller"
 	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on GPIOLIB
 	help
 	  This selects a driver for the Broadcom BCM2835 SPI master.
 
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14  4:24 ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-04-14  4:24 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Guenter Roeck, Martin Sperl

Fix:

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error:
			dereferencing pointer to incomplete type
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:2: error:
	`		implicit declaration of function 'gpiochip_find'
drivers/spi/spi-bcm2835.c:387:21: error:
			dereferencing pointer to incomplete type

by adding the now mandatory GPIOLIB dependency.

Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
	on first spi_setup")
Cc: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 198f96b7fb45..a132180a9251 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -78,6 +78,7 @@ config SPI_ATMEL
 config SPI_BCM2835
 	tristate "BCM2835 SPI controller"
 	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on GPIOLIB
 	help
 	  This selects a driver for the Broadcom BCM2835 SPI master.
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14  5:48   ` Martin Sperl
  0 siblings, 0 replies; 8+ messages in thread
From: Martin Sperl @ 2015-04-14  5:48 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Mark Brown, linux-spi, linux-kernel, Stephen Warren, jim.epost,
	linux-rpi-kernel


> On 14.04.2015, at 06:24, Guenter Roeck <linux@roeck-us.net> wrote:
> 
> by adding the now mandatory GPIOLIB dependency.
> 
Note this shows up during automated randconfig testing.

> Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
> 	on first spi_setup")
> Cc: Martin Sperl <kernel@martin.sperl.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

I have had an identical patch in the pipeline as well, but
I was still testing it over the night.

Signed-off-by: Martin Sperl <kernel@martin.sperl.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14  5:48   ` Martin Sperl
  0 siblings, 0 replies; 8+ messages in thread
From: Martin Sperl @ 2015-04-14  5:48 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Stephen Warren,
	jim.epost-Re5JQEeQqe8AvxtiuMwx3w, linux-rpi-kernel


> On 14.04.2015, at 06:24, Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> wrote:
> 
> by adding the now mandatory GPIOLIB dependency.
> 
Note this shows up during automated randconfig testing.

> Fixes: a30a555d7435 ("spi: bcm2835: transform native-cs to gpio-cs
> 	on first spi_setup")
> Cc: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
> Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>

I have had an identical patch in the pipeline as well, but
I was still testing it over the night.

Signed-off-by: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14  9:01     ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-04-14  9:01 UTC (permalink / raw)
  To: Martin Sperl
  Cc: Mark Brown, linux-spi, linux-kernel, Stephen Warren, jim.epost,
	linux-rpi-kernel

On 04/13/2015 10:48 PM, Martin Sperl wrote:
>
>> On 14.04.2015, at 06:24, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> by adding the now mandatory GPIOLIB dependency.
>>
> Note this shows up during automated randconfig testing.
>

Also for m68k:allmodconfig and mips:allmodconfig in both mainline and -next.

http://server.roeck-us.net:8010/builders/hwmon-m68k-master/builds/129
http://server.roeck-us.net:8010/builders/hwmon-mips-master/builds/129

Guenter


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14  9:01     ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-04-14  9:01 UTC (permalink / raw)
  To: Martin Sperl
  Cc: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Stephen Warren,
	jim.epost-Re5JQEeQqe8AvxtiuMwx3w, linux-rpi-kernel

On 04/13/2015 10:48 PM, Martin Sperl wrote:
>
>> On 14.04.2015, at 06:24, Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> wrote:
>>
>> by adding the now mandatory GPIOLIB dependency.
>>
> Note this shows up during automated randconfig testing.
>

Also for m68k:allmodconfig and mips:allmodconfig in both mainline and -next.

http://server.roeck-us.net:8010/builders/hwmon-m68k-master/builds/129
http://server.roeck-us.net:8010/builders/hwmon-mips-master/builds/129

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14 20:08   ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2015-04-14 20:08 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-spi, linux-kernel, Martin Sperl

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On Mon, Apr 13, 2015 at 09:24:48PM -0700, Guenter Roeck wrote:
> Fix:
> 
> drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
> drivers/spi/spi-bcm2835.c:356:21: error:
> 			dereferencing pointer to incomplete type

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] spi: bcm2835: Add GPIOLIB dependency
@ 2015-04-14 20:08   ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2015-04-14 20:08 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Martin Sperl

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On Mon, Apr 13, 2015 at 09:24:48PM -0700, Guenter Roeck wrote:
> Fix:
> 
> drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
> drivers/spi/spi-bcm2835.c:356:21: error:
> 			dereferencing pointer to incomplete type

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-04-14 20:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-14  4:24 [PATCH] spi: bcm2835: Add GPIOLIB dependency Guenter Roeck
2015-04-14  4:24 ` Guenter Roeck
2015-04-14  5:48 ` Martin Sperl
2015-04-14  5:48   ` Martin Sperl
2015-04-14  9:01   ` Guenter Roeck
2015-04-14  9:01     ` Guenter Roeck
2015-04-14 20:08 ` Mark Brown
2015-04-14 20:08   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.