[PATCH] XSA120 follows to the Linux kernel.

[PATCH] XSA120 follows to the Linux kernel.

[Konrad Rzeszutek Wilk]

Hey David and Boris,

Please see the two patches - the first one fixes an situation that
the original XSA-120 patch hadn't considered.

The second patch is more of just a cleanup. Can be 4.1 material.

 drivers/xen/xen-pciback/pciback_ops.c | 4 ----
 1 file changed, 4 deletions(-)

Konrad Rzeszutek Wilk (2):
      xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
      xen/pciback: Remove is_busmaster=0 as pci_disable_device does it already

[PATCH 1/2] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.

[Konrad Rzeszutek Wilk]

There is no need for this at all. Worst it means that if
the guest tries to write to BARs it could lead (on certain
platforms) to PCI SERR errors.

Please note that with af6fc858a35b90e89ea7a7ee58e66628c55c776b
"xen-pciback: limit guest control of command register"
a guest is still allowed to enable those control bits (safely), but
is not allowed to disable them and that therefore a well behaved
frontend which enables things before using them will still
function correctly.

This is done via an write to the configuration register 0x4 which
triggers on the backend side:
command_write
  \- pci_enable_device
     \- pci_enable_device_flags
        \- do_pci_enable_device
           \- pcibios_enable_device
              \-pci_enable_resourcess
                [which enables the PCI_COMMAND_MEMORY|PCI_COMMAND_IO]

However guests (and drivers) which don't do this could cause
problems, including the security issues which XSA-120 sought
to address.

CC: stable@vger.kernel.org
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pciback_ops.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index c4a0666..26e6513 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -119,8 +119,6 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
 		if (pci_is_enabled(dev))
 			pci_disable_device(dev);
 
-		pci_write_config_word(dev, PCI_COMMAND, 0);
-
 		dev->is_busmaster = 0;
 	} else {
 		pci_read_config_word(dev, PCI_COMMAND, &cmd);
-- 
2.1.0

[PATCH 1/2] xen/pciback: Don't disable PCI_COMMAND on PCI device reset.

[Konrad Rzeszutek Wilk]

There is no need for this at all. Worst it means that if
the guest tries to write to BARs it could lead (on certain
platforms) to PCI SERR errors.

Please note that with af6fc858a35b90e89ea7a7ee58e66628c55c776b
"xen-pciback: limit guest control of command register"
a guest is still allowed to enable those control bits (safely), but
is not allowed to disable them and that therefore a well behaved
frontend which enables things before using them will still
function correctly.

This is done via an write to the configuration register 0x4 which
triggers on the backend side:
command_write
  \- pci_enable_device
     \- pci_enable_device_flags
        \- do_pci_enable_device
           \- pcibios_enable_device
              \-pci_enable_resourcess
                [which enables the PCI_COMMAND_MEMORY|PCI_COMMAND_IO]

However guests (and drivers) which don't do this could cause
problems, including the security issues which XSA-120 sought
to address.

CC: stable@vger.kernel.org
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pciback_ops.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index c4a0666..26e6513 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -119,8 +119,6 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
 		if (pci_is_enabled(dev))
 			pci_disable_device(dev);
 
-		pci_write_config_word(dev, PCI_COMMAND, 0);
-
 		dev->is_busmaster = 0;
 	} else {
 		pci_read_config_word(dev, PCI_COMMAND, &cmd);
-- 
2.1.0

[PATCH 2/2] xen/pciback: Remove is_busmaster=0 as pci_disable_device does it already

[Konrad Rzeszutek Wilk]

There is no need for this.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pciback_ops.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 26e6513..a131733 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -118,8 +118,6 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
 #endif
 		if (pci_is_enabled(dev))
 			pci_disable_device(dev);
-
-		dev->is_busmaster = 0;
 	} else {
 		pci_read_config_word(dev, PCI_COMMAND, &cmd);
 		if (cmd & (PCI_COMMAND_INVALIDATE)) {
-- 
2.1.0

[PATCH 2/2] xen/pciback: Remove is_busmaster=0 as pci_disable_device does it already

[Konrad Rzeszutek Wilk]

There is no need for this.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pciback_ops.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 26e6513..a131733 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -118,8 +118,6 @@ void xen_pcibk_reset_device(struct pci_dev *dev)
 #endif
 		if (pci_is_enabled(dev))
 			pci_disable_device(dev);
-
-		dev->is_busmaster = 0;
 	} else {
 		pci_read_config_word(dev, PCI_COMMAND, &cmd);
 		if (cmd & (PCI_COMMAND_INVALIDATE)) {
-- 
2.1.0

Re: [Xen-devel] [PATCH] XSA120 follows to the Linux kernel.

[David Vrabel]

On 03/04/15 15:28, Konrad Rzeszutek Wilk wrote:
> Hey David and Boris,
> 
> Please see the two patches - the first one fixes an situation that
> the original XSA-120 patch hadn't considered.
> 
> The second patch is more of just a cleanup. Can be 4.1 material.

Applied both to devel/for-linus-4.1 since 4.0 is imminent (possibly),
thanks.

David

Re: [PATCH] XSA120 follows to the Linux kernel.

[David Vrabel]

On 03/04/15 15:28, Konrad Rzeszutek Wilk wrote:
> Hey David and Boris,
> 
> Please see the two patches - the first one fixes an situation that
> the original XSA-120 patch hadn't considered.
> 
> The second patch is more of just a cleanup. Can be 4.1 material.

Applied both to devel/for-linus-4.1 since 4.0 is imminent (possibly),
thanks.

David

Re: [Xen-devel] [PATCH] XSA120 follows to the Linux kernel.

[Jan Beulich]

>>> On 10.04.15 at 16:37, <david.vrabel@citrix.com> wrote:
> On 03/04/15 15:28, Konrad Rzeszutek Wilk wrote:
>> Hey David and Boris,
>> 
>> Please see the two patches - the first one fixes an situation that
>> the original XSA-120 patch hadn't considered.
>> 
>> The second patch is more of just a cleanup. Can be 4.1 material.
> 
> Applied both to devel/for-linus-4.1 since 4.0 is imminent (possibly),
> thanks.

And considering Sander's bisection result posted yesterday (plus
the - afaict - still unaddressed question raised by IanC regarding
the correctness wrt to bits other than 0 and 1) I suppose you
dropped them again?

Jan

Re: [PATCH] XSA120 follows to the Linux kernel.

[Jan Beulich]

>>> On 10.04.15 at 16:37, <david.vrabel@citrix.com> wrote:
> On 03/04/15 15:28, Konrad Rzeszutek Wilk wrote:
>> Hey David and Boris,
>> 
>> Please see the two patches - the first one fixes an situation that
>> the original XSA-120 patch hadn't considered.
>> 
>> The second patch is more of just a cleanup. Can be 4.1 material.
> 
> Applied both to devel/for-linus-4.1 since 4.0 is imminent (possibly),
> thanks.

And considering Sander's bisection result posted yesterday (plus
the - afaict - still unaddressed question raised by IanC regarding
the correctness wrt to bits other than 0 and 1) I suppose you
dropped them again?

Jan

[PATCH] XSA120 follows to the Linux kernel.

[Konrad Rzeszutek Wilk]

Hey David and Boris,

Please see the two patches - the first one fixes an situation that
the original XSA-120 patch hadn't considered.

The second patch is more of just a cleanup. Can be 4.1 material.

 drivers/xen/xen-pciback/pciback_ops.c | 4 ----
 1 file changed, 4 deletions(-)

Konrad Rzeszutek Wilk (2):
      xen/pciback: Don't disable PCI_COMMAND on PCI device reset.
      xen/pciback: Remove is_busmaster=0 as pci_disable_device does it already