* [PATCH -next] input/touchscreen: fix sur40.c build errors
@ 2015-04-15 15:54 Randy Dunlap
2015-04-15 16:10 ` Florian Echtler
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2015-04-15 15:54 UTC (permalink / raw)
To: LKML, linux-input; +Cc: Florian 'floe' Echtler, Dmitry Torokhov
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors due to missing Kconfig dependency.
drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to `video_unregister_device'
sur40.c:(.text+0x22be77): undefined reference to `v4l2_device_unregister'
drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to `v4l2_device_register'
sur40.c:(.text+0x22cb1a): undefined reference to `v4l2_device_unregister'
sur40.c:(.text+0x22cbf7): undefined reference to `video_device_release_empty'
sur40.c:(.text+0x22cc53): undefined reference to `__video_register_device'
sur40.c:(.text+0x22cc90): undefined reference to `video_unregister_device'
drivers/built-in.o: In function `sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Florian 'floe' Echtler <floe@butterbrot.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
---
drivers/input/touchscreen/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig
+++ linux-next-20150415/drivers/input/touchscreen/Kconfig
@@ -981,6 +981,7 @@ config TOUCHSCREEN_SUR40
tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
depends on USB
depends on MEDIA_USB_SUPPORT
+ depends on VIDEO_V4L2
select INPUT_POLLDEV
select VIDEOBUF2_DMA_SG
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] input/touchscreen: fix sur40.c build errors
2015-04-15 15:54 [PATCH -next] input/touchscreen: fix sur40.c build errors Randy Dunlap
@ 2015-04-15 16:10 ` Florian Echtler
0 siblings, 0 replies; 2+ messages in thread
From: Florian Echtler @ 2015-04-15 16:10 UTC (permalink / raw)
To: Randy Dunlap, LKML, linux-input; +Cc: Dmitry Torokhov
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
Hello Randy,
On 15.04.2015 17:54, Randy Dunlap wrote:
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig
> +++ linux-next-20150415/drivers/input/touchscreen/Kconfig
> @@ -981,6 +981,7 @@ config TOUCHSCREEN_SUR40
> tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
> depends on USB
> depends on MEDIA_USB_SUPPORT
> + depends on VIDEO_V4L2
> select INPUT_POLLDEV
> select VIDEOBUF2_DMA_SG
> help
>
Thanks for catching this. I assumed videobuf2 would to auto-select
video-v4l2 in any case.
Best, Florian
--
SENT FROM MY DEC VT50 TERMINAL
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-15 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 15:54 [PATCH -next] input/touchscreen: fix sur40.c build errors Randy Dunlap
2015-04-15 16:10 ` Florian Echtler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.