All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login
@ 2015-04-15 16:20 Kinglong Mee
  2015-05-07 14:16 ` Steve Dickson
  0 siblings, 1 reply; 5+ messages in thread
From: Kinglong Mee @ 2015-04-15 16:20 UTC (permalink / raw)
  To: Steve Dickson; +Cc: linux-nfs, Eino Juhani Oltedal, kinglongmee

Eino reports, 
Configure using the following command

    ./configure --prefix=/home/username/installs/tmp --exec-prefix=/home/username/installs/tmp

When running "make install" most of the packages are put under /home/username/installs/tmp, but for some reason the install script tries to put osd_login under /sbin, which results in an error:

    Making install in osd_login
    make[2]: Entering directory `/home/username/installs/nfs-utils-1.3.2/utils/osd_login'
    make[3]: Entering directory `/home/username/installs/nfs-utils-1.3.2/utils/osd_login'
        /usr/bin/mkdir -p '/sbin'
        /usr/bin/install -c osd_login '/sbin'
        /usr/bin/install: cannot remove ‘/sbin/osd_login’: Permission denied
        make[3]: *** [install-dist_sbinSCRIPTS] Error 1 

Reported-by: Eino Juhani Oltedal <e.j.oltedal@fys.uio.no>
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
 configure.ac      | 7 +++++++
 utils/Makefile.am | 5 ++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d4301a2..33a2f57 100644
--- a/configure.ac
+++ b/configure.ac
@@ -216,6 +216,13 @@ AC_ARG_ENABLE(nfsdcltrack,
 	enable_nfsdcltrack=$enableval,
 	enable_nfsdcltrack="yes")
 
+AC_ARG_ENABLE(osdlogin,
+	[AC_HELP_STRING([--disable-osdlogin],
+			[disable osd_login scripts @<:@default=no@:>@])],
+	enable_osdlogin=$enableval,
+	enable_osdlogin="yes")
+	AM_CONDITIONAL(CONFIG_OSD_LOGIN, [test "$enable_osdlogin" = "yes" ])
+
 dnl Check for TI-RPC library and headers
 AC_LIBTIRPC
 
diff --git a/utils/Makefile.am b/utils/Makefile.am
index b892dc8..6dd4a57 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -25,6 +25,10 @@ if CONFIG_NFSDCLTRACK
 OPTDIRS += nfsdcltrack
 endif
 
+if CONFIG_OSD_LOGIN
+OPTDIRS += osd_login
+endif
+
 SUBDIRS = \
 	exportfs \
 	mountd \
@@ -32,7 +36,6 @@ SUBDIRS = \
 	nfsstat \
 	showmount \
 	statd \
-	osd_login \
 	$(OPTDIRS)
 
 MAINTAINERCLEANFILES = Makefile.in
-- 
2.3.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login
  2015-04-15 16:20 [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login Kinglong Mee
@ 2015-05-07 14:16 ` Steve Dickson
  2015-05-07 14:59   ` Kinglong Mee
  0 siblings, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2015-05-07 14:16 UTC (permalink / raw)
  To: Kinglong Mee; +Cc: linux-nfs, Eino Juhani Oltedal



On 04/15/2015 12:20 PM, Kinglong Mee wrote:
> Eino reports, 
> Configure using the following command
> 
>     ./configure --prefix=/home/username/installs/tmp --exec-prefix=/home/username/installs/tmp
> 
> When running "make install" most of the packages are put under /home/username/installs/tmp, but for some reason the install script tries to put osd_login under /sbin, which results in an error:
> 
>     Making install in osd_login
>     make[2]: Entering directory `/home/username/installs/nfs-utils-1.3.2/utils/osd_login'
>     make[3]: Entering directory `/home/username/installs/nfs-utils-1.3.2/utils/osd_login'
>         /usr/bin/mkdir -p '/sbin'
>         /usr/bin/install -c osd_login '/sbin'
>         /usr/bin/install: cannot remove ‘/sbin/osd_login’: Permission denied
>         make[3]: *** [install-dist_sbinSCRIPTS] Error 1 
> 
> Reported-by: Eino Juhani Oltedal <e.j.oltedal@fys.uio.no>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
I changed this just a bit... Instead of disabling it, I change
it to enable the installation which is 'no' by default.

Committed... 

steved.
 
> ---
>  configure.ac      | 7 +++++++
>  utils/Makefile.am | 5 ++++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index d4301a2..33a2f57 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -216,6 +216,13 @@ AC_ARG_ENABLE(nfsdcltrack,
>  	enable_nfsdcltrack=$enableval,
>  	enable_nfsdcltrack="yes")
>  
> +AC_ARG_ENABLE(osdlogin,
> +	[AC_HELP_STRING([--disable-osdlogin],
> +			[disable osd_login scripts @<:@default=no@:>@])],
> +	enable_osdlogin=$enableval,
> +	enable_osdlogin="yes")
> +	AM_CONDITIONAL(CONFIG_OSD_LOGIN, [test "$enable_osdlogin" = "yes" ])
> +
>  dnl Check for TI-RPC library and headers
>  AC_LIBTIRPC
>  
> diff --git a/utils/Makefile.am b/utils/Makefile.am
> index b892dc8..6dd4a57 100644
> --- a/utils/Makefile.am
> +++ b/utils/Makefile.am
> @@ -25,6 +25,10 @@ if CONFIG_NFSDCLTRACK
>  OPTDIRS += nfsdcltrack
>  endif
>  
> +if CONFIG_OSD_LOGIN
> +OPTDIRS += osd_login
> +endif
> +
>  SUBDIRS = \
>  	exportfs \
>  	mountd \
> @@ -32,7 +36,6 @@ SUBDIRS = \
>  	nfsstat \
>  	showmount \
>  	statd \
> -	osd_login \
>  	$(OPTDIRS)
>  
>  MAINTAINERCLEANFILES = Makefile.in
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login
  2015-05-07 14:16 ` Steve Dickson
@ 2015-05-07 14:59   ` Kinglong Mee
  2015-05-07 15:22     ` Steve Dickson
  0 siblings, 1 reply; 5+ messages in thread
From: Kinglong Mee @ 2015-05-07 14:59 UTC (permalink / raw)
  To: Steve Dickson; +Cc: linux-nfs, Eino Juhani Oltedal, kinglongmee

On 5/7/2015 10:16 PM, Steve Dickson wrote:
> On 04/15/2015 12:20 PM, Kinglong Mee wrote:
>> Eino reports, 
>> Configure using the following command
>>
>>     ./configure --prefix=/home/username/installs/tmp --exec-prefix=/home/username/installs/tmp
>>
>> When running "make install" most of the packages are put under /home/username/installs/tmp, but for some reason the install script tries to put osd_login under /sbin, which results in an error:
>>
>>     Making install in osd_login
>>     make[2]: Entering directory `/home/username/installs/nfs-utils-1.3.2/utils/osd_login'
>>     make[3]: Entering directory `/home/username/installs/nfs-utils-1.3.2/utils/osd_login'
>>         /usr/bin/mkdir -p '/sbin'
>>         /usr/bin/install -c osd_login '/sbin'
>>         /usr/bin/install: cannot remove ‘/sbin/osd_login’: Permission denied
>>         make[3]: *** [install-dist_sbinSCRIPTS] Error 1 
>>
>> Reported-by: Eino Juhani Oltedal <e.j.oltedal@fys.uio.no>
>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> I changed this just a bit... Instead of disabling it, I change
> it to enable the installation which is 'no' by default.
> 
> Committed... 
> 
> steved.
>  
>> ---
>>  configure.ac      | 7 +++++++
>>  utils/Makefile.am | 5 ++++-
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index d4301a2..33a2f57 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -216,6 +216,13 @@ AC_ARG_ENABLE(nfsdcltrack,
>>  	enable_nfsdcltrack=$enableval,
>>  	enable_nfsdcltrack="yes")
>>  
>> +AC_ARG_ENABLE(osdlogin,
>> +	[AC_HELP_STRING([--disable-osdlogin],
>> +			[disable osd_login scripts @<:@default=no@:>@])],
>> +	enable_osdlogin=$enableval,
>> +	enable_osdlogin="yes")
>> +	AM_CONDITIONAL(CONFIG_OSD_LOGIN, [test "$enable_osdlogin" = "yes" ])
>> +
>>  dnl Check for TI-RPC library and headers
>>  AC_LIBTIRPC
>>  
>> diff --git a/utils/Makefile.am b/utils/Makefile.am
>> index b892dc8..6dd4a57 100644
>> --- a/utils/Makefile.am
>> +++ b/utils/Makefile.am
>> @@ -25,6 +25,10 @@ if CONFIG_NFSDCLTRACK
>>  OPTDIRS += nfsdcltrack
>>  endif
>>  
>> +if CONFIG_OSD_LOGIN
>> +OPTDIRS += osd_login
>> +endif
>> +
>>  SUBDIRS = \
>>  	exportfs \
>>  	mountd \
>> @@ -32,7 +36,6 @@ SUBDIRS = \
>>  	nfsstat \
>>  	showmount \
>>  	statd \
>> -	osd_login \
>>  	$(OPTDIRS)
>>  
>>  MAINTAINERCLEANFILES = Makefile.in

Miss updating of utils/Makefile.am in your tree.

http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=3e28fe73af023bf42e0d654146bfb9314b4d8438

thanks,
Kinglong Mee

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login
  2015-05-07 14:59   ` Kinglong Mee
@ 2015-05-07 15:22     ` Steve Dickson
  2015-05-08  0:23       ` Kinglong Mee
  0 siblings, 1 reply; 5+ messages in thread
From: Steve Dickson @ 2015-05-07 15:22 UTC (permalink / raw)
  To: Kinglong Mee; +Cc: linux-nfs, Eino Juhani Oltedal

Hello,

On 05/07/2015 10:59 AM, Kinglong Mee wrote:
> Miss updating of utils/Makefile.am in your tree.
> 
> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=3e28fe73af023bf42e0d654146bfb9314b4d8438
Are you saying something is missing??

steved.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login
  2015-05-07 15:22     ` Steve Dickson
@ 2015-05-08  0:23       ` Kinglong Mee
  0 siblings, 0 replies; 5+ messages in thread
From: Kinglong Mee @ 2015-05-08  0:23 UTC (permalink / raw)
  To: Steve Dickson; +Cc: linux-nfs, Eino Juhani Oltedal, kinglongmee


On 5/7/2015 11:22 PM, Steve Dickson wrote:
> Hello,
> 
> On 05/07/2015 10:59 AM, Kinglong Mee wrote:
>> Miss updating of utils/Makefile.am in your tree.
>>
>> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=3e28fe73af023bf42e0d654146bfb9314b4d8438
> Are you saying something is missing??

Yes,
the old patch also update utils/Makefile.am, 
otherwise adding --enable-osdlogin is useless.


diff --git a/utils/Makefile.am b/utils/Makefile.am
index b892dc8..6dd4a57 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -25,6 +25,10 @@ if CONFIG_NFSDCLTRACK
 OPTDIRS += nfsdcltrack
 endif
 
+if CONFIG_OSD_LOGIN
+OPTDIRS += osd_login
+endif
+
 SUBDIRS = \
 	exportfs \
 	mountd \
@@ -32,7 +36,6 @@ SUBDIRS = \
 	nfsstat \
 	showmount \
 	statd \
-	osd_login \
 	$(OPTDIRS)
 
 MAINTAINERCLEANFILES = Makefile.in
-- 2.3.5 

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-08  0:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 16:20 [PATCH 3/3] osd_login: add --disable-osdlogin for configure osd_login Kinglong Mee
2015-05-07 14:16 ` Steve Dickson
2015-05-07 14:59   ` Kinglong Mee
2015-05-07 15:22     ` Steve Dickson
2015-05-08  0:23       ` Kinglong Mee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.