All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	target-devel@vger.kernel.org,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.
Date: Thu, 16 Apr 2015 11:52:16 +0300	[thread overview]
Message-ID: <552F7840.2080804@dev.mellanox.co.il> (raw)
In-Reply-To: <yq1egnl4bjm.fsf@sermon.lab.mkp.net>

On 4/15/2015 7:10 PM, Martin K. Petersen wrote:
>>>>>> "Sagi" == Sagi Grimberg <sagig@dev.mellanox.co.il> writes:
>
>>>> By the commit 436f4a0a ("loopback: Add fabric_prot_type attribute
>>>> support"), When WRITE_SAME command with WRPROTECT=0 is executed,
>>>> sbc_dif_generate() is called but cmd->t_prot_sg is NULL as block
>>>> layer didn't allocate it for WRITE_SAME.
>
> Sagi> Actually this is a bug. Why didn't the initiator allocate
> Sagi> integrity meta-data for WRITE_SAME? Looking at the code it looks
> Sagi> like it should.
>
> We don't issue WRITE SAME with PI so there is no prot SGL.
>

Is there a specific reason why we don't?

  reply	other threads:[~2015-04-16  8:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 17:19 [RFC] Simlify dif_verify routines and fixup fileio protection information code Sagi Grimberg
2015-04-13 17:19 ` [PATCH RFC 1/2] target: Merge sbc_verify_dif_read|write Sagi Grimberg
2015-04-13 17:19 ` [PATCH RFC 2/2] target/file: Remove fd_prot bounce buffer Sagi Grimberg
2015-04-14  1:23 ` [RFC] Simlify dif_verify routines and fixup fileio protection information code Martin K. Petersen
2015-04-14 12:17 ` Akinobu Mita
2015-04-14 17:20   ` Sagi Grimberg
2015-04-14 23:52     ` Akinobu Mita
2015-04-15 10:07       ` Sagi Grimberg
2015-04-15 14:16         ` Akinobu Mita
2015-04-15 14:33           ` Sagi Grimberg
2015-04-15 15:05             ` Martin K. Petersen
2015-04-15 15:08             ` Sagi Grimberg
2015-04-15 16:10               ` Martin K. Petersen
2015-04-16  8:52                 ` Sagi Grimberg [this message]
2015-04-16 13:46                   ` Akinobu Mita
2015-04-16 15:30                     ` Martin K. Petersen
2015-04-16 15:58                     ` Sagi Grimberg
2015-04-16 16:04                       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552F7840.2080804@dev.mellanox.co.il \
    --to=sagig@dev.mellanox.co.il \
    --cc=akinobu.mita@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.