From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
target-devel@vger.kernel.org,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.
Date: Wed, 15 Apr 2015 11:05:33 -0400 [thread overview]
Message-ID: <yq1lhht4eki.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <552E76D1.7040204@dev.mellanox.co.il> (Sagi Grimberg's message of "Wed, 15 Apr 2015 17:33:53 +0300")
>>>>> "Sagi" == Sagi Grimberg <sagig@dev.mellanox.co.il> writes:
Sagi> I don't think this is sufficient. With this we actually write
Sagi> unprotected data for WRITE_SAME (i.e. write data blocks but not
Sagi> storing the corresponding PI information). When this data will be
Sagi> read back you will see PI errors (you currently don't see those
Sagi> because your backend drive contains escape values I assume).
Sagi> I'd say the correct fix is to calc PI for the block
Indeed!
Sagi> and "write_same" it...
Well, the ref tag needs to be incremented for each block (for Type 1).
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-04-15 15:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 17:19 [RFC] Simlify dif_verify routines and fixup fileio protection information code Sagi Grimberg
2015-04-13 17:19 ` [PATCH RFC 1/2] target: Merge sbc_verify_dif_read|write Sagi Grimberg
2015-04-13 17:19 ` [PATCH RFC 2/2] target/file: Remove fd_prot bounce buffer Sagi Grimberg
2015-04-14 1:23 ` [RFC] Simlify dif_verify routines and fixup fileio protection information code Martin K. Petersen
2015-04-14 12:17 ` Akinobu Mita
2015-04-14 17:20 ` Sagi Grimberg
2015-04-14 23:52 ` Akinobu Mita
2015-04-15 10:07 ` Sagi Grimberg
2015-04-15 14:16 ` Akinobu Mita
2015-04-15 14:33 ` Sagi Grimberg
2015-04-15 15:05 ` Martin K. Petersen [this message]
2015-04-15 15:08 ` Sagi Grimberg
2015-04-15 16:10 ` Martin K. Petersen
2015-04-16 8:52 ` Sagi Grimberg
2015-04-16 13:46 ` Akinobu Mita
2015-04-16 15:30 ` Martin K. Petersen
2015-04-16 15:58 ` Sagi Grimberg
2015-04-16 16:04 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lhht4eki.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=akinobu.mita@gmail.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@dev.mellanox.co.il \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.