From: Boaz Harrosh <boaz@plexistor.com> To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com Cc: linux-fsdevel@vger.kernel.org, willy@linux.intel.com, jack@suse.cz Subject: Re: [PATCH 5/8] xfs: add DAX file operations support Date: Thu, 16 Apr 2015 12:33:26 +0300 [thread overview] Message-ID: <552F81E6.4050700@plexistor.com> (raw) In-Reply-To: <1427194266-2885-6-git-send-email-david@fromorbit.com> On 03/24/2015 12:51 PM, Dave Chinner wrote: <> > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 94713c2..8017175 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -385,7 +385,11 @@ xfs_file_splice_read( > > trace_xfs_file_splice_read(ip, count, *ppos, ioflags); > > - ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); > + /* for dax, we need to avoid the page cache */ > + if (IS_DAX(VFS_I(ip))) > + ret = default_file_splice_read(infilp, ppos, pipe, count, flags); > + else > + ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); Dave hi Linus has accepted this patch: [be64f884be] dax: unify ext2/4_{dax,}_file_operations Which adds the same exact if(IS_DAX)) to generic_file_splice_read for use by ext2/4. (It made things easier for both ext2/4) But also this code is just fine of course Thanks Boaz > if (ret > 0) > XFS_STATS_ADD(xs_read_bytes, ret); > <>
WARNING: multiple messages have this Message-ID (diff)
From: Boaz Harrosh <boaz@plexistor.com> To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com Cc: linux-fsdevel@vger.kernel.org, willy@linux.intel.com, jack@suse.cz Subject: Re: [PATCH 5/8] xfs: add DAX file operations support Date: Thu, 16 Apr 2015 12:33:26 +0300 [thread overview] Message-ID: <552F81E6.4050700@plexistor.com> (raw) In-Reply-To: <1427194266-2885-6-git-send-email-david@fromorbit.com> On 03/24/2015 12:51 PM, Dave Chinner wrote: <> > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 94713c2..8017175 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -385,7 +385,11 @@ xfs_file_splice_read( > > trace_xfs_file_splice_read(ip, count, *ppos, ioflags); > > - ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); > + /* for dax, we need to avoid the page cache */ > + if (IS_DAX(VFS_I(ip))) > + ret = default_file_splice_read(infilp, ppos, pipe, count, flags); > + else > + ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); Dave hi Linus has accepted this patch: [be64f884be] dax: unify ext2/4_{dax,}_file_operations Which adds the same exact if(IS_DAX)) to generic_file_splice_read for use by ext2/4. (It made things easier for both ext2/4) But also this code is just fine of course Thanks Boaz > if (ret > 0) > XFS_STATS_ADD(xs_read_bytes, ret); > <> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-04-16 9:33 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-24 10:50 [PATCH 0/8 v2] xfs: DAX support Dave Chinner 2015-03-24 10:50 ` Dave Chinner 2015-03-24 10:50 ` [PATCH 1/8] xfs: mmap lock needs to be inside freeze protection Dave Chinner 2015-04-01 14:34 ` Jan Kara 2015-04-01 14:34 ` Jan Kara 2015-04-06 17:48 ` Brian Foster 2015-04-06 17:48 ` Brian Foster 2015-03-24 10:51 ` [PATCH 2/8] dax: don't abuse get_block mapping for endio callbacks Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-04-01 14:53 ` Jan Kara 2015-04-01 14:53 ` Jan Kara 2015-03-24 10:51 ` [PATCH 3/8] dax: expose __dax_fault for filesystems with locking constraints Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-04-01 15:07 ` Jan Kara 2015-04-01 15:07 ` Jan Kara 2015-03-24 10:51 ` [PATCH 4/8] xfs: add DAX block zeroing support Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-04-06 17:48 ` Brian Foster 2015-04-06 17:48 ` Brian Foster 2015-03-24 10:51 ` [PATCH 5/8] xfs: add DAX file operations support Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-03-24 12:08 ` Boaz Harrosh 2015-03-24 12:08 ` Boaz Harrosh 2015-03-24 12:24 ` Boaz Harrosh 2015-03-24 12:24 ` Boaz Harrosh 2015-03-24 21:17 ` Dave Chinner 2015-03-24 21:17 ` Dave Chinner 2015-03-25 8:47 ` Boaz Harrosh 2015-03-25 8:47 ` Boaz Harrosh 2015-04-06 17:49 ` Brian Foster 2015-04-06 17:49 ` Brian Foster 2015-04-16 8:29 ` Dave Chinner 2015-04-16 8:29 ` Dave Chinner 2015-04-16 9:33 ` Boaz Harrosh [this message] 2015-04-16 9:33 ` Boaz Harrosh 2015-04-16 11:47 ` Dave Chinner 2015-04-16 11:47 ` Dave Chinner 2015-03-24 10:51 ` [PATCH 6/8] xfs: add DAX truncate support Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-04-06 17:49 ` Brian Foster 2015-04-06 17:49 ` Brian Foster 2015-03-24 10:51 ` [PATCH 7/8] xfs: add DAX IO path support Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-04-06 17:49 ` Brian Foster 2015-04-06 17:49 ` Brian Foster 2015-04-16 8:54 ` Dave Chinner 2015-04-16 8:54 ` Dave Chinner 2015-03-24 10:51 ` [PATCH 8/8] xfs: add initial DAX support Dave Chinner 2015-03-24 10:51 ` Dave Chinner 2015-03-24 12:52 ` Boaz Harrosh 2015-03-24 12:52 ` Boaz Harrosh 2015-03-24 21:25 ` Dave Chinner 2015-03-24 21:25 ` Dave Chinner 2015-03-25 9:14 ` Boaz Harrosh 2015-03-25 9:14 ` Boaz Harrosh 2015-04-06 19:00 ` Brian Foster 2015-04-06 19:00 ` Brian Foster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=552F81E6.4050700@plexistor.com \ --to=boaz@plexistor.com \ --cc=david@fromorbit.com \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=willy@linux.intel.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.