Re: [PATCH 3/9] raisin: add QEMU upstream component

[George Dunlap <george.dunlap@eu.citrix.com>]

On 04/16/2015 10:51 AM, Stefano Stabellini wrote:
> On Wed, 15 Apr 2015, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 15/04/2015 16:14, Stefano Stabellini wrote:
>>> diff --git a/components/series b/components/series
>>> index 3c3124d..8f614f0 100644
>>> --- a/components/series
>>> +++ b/components/series
>>> @@ -1,3 +1,4 @@
>>>   xen
>>> +qemu
>>>   grub
>>>   libvirt
>>> diff --git a/components/xen b/components/xen
>>> index 2d345a8..dcf2f92 100644
>>> --- a/components/xen
>>> +++ b/components/xen
>>> @@ -23,7 +23,7 @@ function xen_build() {
>>>       cd "$BASEDIR"
>>>       git-checkout $XEN_UPSTREAM_URL $XEN_UPSTREAM_REVISION xen-dir
>>>       cd xen-dir
>>> -    ./configure --prefix=$PREFIX
>>> +    ./configure --prefix=$PREFIX
>>> --with-system-qemu=/usr/bin/qemu-system-i386
>>
>> Currently the QEMU built by Xen is installed in a Xen directory (IIRC
>> /usr/lib/xen/bin). Should not you use a similar path for raisin? Otherwise you
>> would override the QEMU installed via the distrib package
>> manager.
> 
> This was done on purpose because the QEMU component built by Raisin
> should be generally usable, even without Xen.

Do we want raisin to clobber / conflict with a system qemu by befault?

I think if our goal is, "A Xen-focused configuration that Just Works",
putting it in /usr/lib/xen/bin is probably better.

 -George