[PATCH] DRM: Don't re-poll connector for disconnect

[PATCH] DRM: Don't re-poll connector for disconnect

[Josef Holzmayr]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

DRM probe should not repoll a connector if it is already
connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.

Signed-off-by: Josef Holzmayr <holzmayr@rsi-elektrotechnik.de>
---
 drivers/gpu/drm/drm_probe_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 3fee587..1a52ea2 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -323,8 +323,6 @@ static void output_poll_execute(struct work_struct *work)
 		if (!connector->polled || connector->polled == DRM_CONNECTOR_POLL_HPD)
 			continue;
 
-		repoll = true;
-
 		old_status = connector->status;
 		/* if we are connected and don't want to poll for disconnect
 		   skip it */
@@ -332,6 +330,8 @@ static void output_poll_execute(struct work_struct *work)
 		    !(connector->polled & DRM_CONNECTOR_POLL_DISCONNECT))
 			continue;
 
+		repoll = true;
+
 		connector->status = connector->funcs->detect(connector, false);
 		if (old_status != connector->status) {
 			const char *old, *new;
-- 
1.9.1


-- 
_____________________________________________________________
R-S-I Elektrotechnik GmbH & Co. KG
Woelkestrasse 11
D-85301 Schweitenkirchen
Fon: +49 8444 9204-0
Fax: +49 8444 9204-50
www.rsi-elektrotechnik.de

_____________________________________________________________
Amtsgericht Ingolstadt - GmbH: HRB 191328 - KG: HRA 170363
Geschäftsführer: Dr.-Ing. Michael Sorg, Dipl.-Ing. Franz Sorg
USt-IdNr.: DE 128592548


[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] DRM: Don't re-poll connector for disconnect

[Chris Wilson]

On Thu, Apr 16, 2015 at 02:16:29PM +0200, Josef Holzmayr wrote:
> DRM probe should not repoll a connector if it is already
> connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
> 
> Signed-off-by: Josef Holzmayr <holzmayr@rsi-elektrotechnik.de>

However, this requires review of all current users first to check for
masked bugs. So at least cc every driver maintainer.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] DRM: Don't re-poll connector for disconnect

[Josef Holzmayr]

Am 17.04.2015 um 13:23 schrieb Chris Wilson:
> On Thu, Apr 16, 2015 at 02:16:29PM +0200, Josef Holzmayr wrote:
>> DRM probe should not repoll a connector if it is already
>> connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
>>
>> Signed-off-by: Josef Holzmayr <holzmayr@rsi-elektrotechnik.de>
>
> However, this requires review of all current users first to check for
> masked bugs. So at least cc every driver maintainer.

Happily will do, is there some kind of list or resource to follow? I 
just started out with what get_maintainer.pl told me.

Greetz
-- 
Josef Holzmayr
Dipl-Ing. (FH)
Entwicklung Embedded Devices / Software

Tel.: +49 8444 9204-48>
Fax:  +49 8444 9204-50
holzmayr@rsi-elektrotechnik.de

R-S-I Elektrotechnik GmbH & Co. KG
Woelkestrasse 11
D-85301 Schweitenkirchen
www.rsi-elektrotechnik.de
_____________________________________________________________
Amtsgericht Ingolstadt - GmbH: HRB 191328 - KG: HRA 170363
Geschäftsführer: Dr.-Ing. Michael Sorg, Dipl.-Ing. Franz Sorg
USt-IdNr.: DE 128592548

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] DRM: Don't re-poll connector for disconnect

[Daniel Vetter]

On Fri, Apr 17, 2015 at 01:26:21PM +0200, Josef Holzmayr wrote:
> Am 17.04.2015 um 13:23 schrieb Chris Wilson:
> >On Thu, Apr 16, 2015 at 02:16:29PM +0200, Josef Holzmayr wrote:
> >>DRM probe should not repoll a connector if it is already
> >>connected and the DRM_CONNECTOR_POLL_DISCONNECT flag is not set.
> >>
> >>Signed-off-by: Josef Holzmayr <holzmayr@rsi-elektrotechnik.de>
> >
> >However, this requires review of all current users first to check for
> >masked bugs. So at least cc every driver maintainer.
> 
> Happily will do, is there some kind of list or resource to follow? I just
> started out with what get_maintainer.pl told me.

Sending to dri-devel should be enough generally. I've pulled this into
topic/drm-misc for 4.2, hopefully that's enough testing to figure out
whether anything is broken with this patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel