* [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
@ 2015-04-19 12:44 ` Yann E. MORIN
2015-04-19 16:41 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 2/7 v5] package/binutils: " Yann E. MORIN
` (6 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
Changes v4 -> v5:
- use alternate upstream as source of hashes (Arnout)
---
package/gcc/gcc-final/gcc-final.hash | 1 +
package/gcc/gcc-initial/gcc-initial.hash | 1 +
package/gcc/gcc.hash | 10 ++++++++++
3 files changed, 12 insertions(+)
create mode 120000 package/gcc/gcc-final/gcc-final.hash
create mode 120000 package/gcc/gcc-initial/gcc-initial.hash
create mode 100644 package/gcc/gcc.hash
diff --git a/package/gcc/gcc-final/gcc-final.hash b/package/gcc/gcc-final/gcc-final.hash
new file mode 120000
index 0000000..7ac9361
--- /dev/null
+++ b/package/gcc/gcc-final/gcc-final.hash
@@ -0,0 +1 @@
+../gcc.hash
\ No newline at end of file
diff --git a/package/gcc/gcc-initial/gcc-initial.hash b/package/gcc/gcc-initial/gcc-initial.hash
new file mode 120000
index 0000000..7ac9361
--- /dev/null
+++ b/package/gcc/gcc-initial/gcc-initial.hash
@@ -0,0 +1 @@
+../gcc.hash
\ No newline at end of file
diff --git a/package/gcc/gcc.hash b/package/gcc/gcc.hash
new file mode 100644
index 0000000..5eec97f
--- /dev/null
+++ b/package/gcc/gcc.hash
@@ -0,0 +1,10 @@
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.5.4/sha512.sum
+sha512 78696b287d46aacd6f150920da376ea32f58ad9f0dafd2d3b7fa6dbdd8dd7afe659108d1dfaa5807617fc5248719f50b39c37ade0173ea5b9fec2091f4656115 gcc-4.5.4.tar.bz2
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.7.4/sha512.sum
+sha512 dfcb737073191e628231031a3571ec77ee760a59377630f4a6e4fdfa66f9ddad39fde47e3f0f227eb43cdf90e0d34cde5abdc9ac892c1e111a911062a66c9189 gcc-4.7.4.tar.bz2
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.8.4/sha512.sum
+sha512 b4c84ebd754c026029d706ef52c4242df4dcadc6a22cc5669b3aa37ac9dc25bc9cd9651fda83fb24dd5d17b1710e6865a35bb6c5cd9b95d0971717453935ae8e gcc-4.8.4.tar.bz2
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.9.2/sha512.sum
+sha512 e96cba06d572dbe7f382a2b00fd9297dcf9f9219d46a9ad0bd904dc36d5e7db3335e422640b79a27fed6fde91b0731732b94a0e2fbcd47344d6779f8ba1f4f9c gcc-4.9.2.tar.bz2
+# No hash for the ARC variant, comes from the github-helper:
+none xxx gcc-arc-2014.12.tar.gz
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains)
@ 2015-04-19 12:44 Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes Yann E. MORIN
` (7 more replies)
0 siblings, 8 replies; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
Hello All!
This series makes it so we can download custom external toolchains, and
still have mandatory checks of hashes.
It also adds the long-awaited-for hashes for gcc and binutils.
Changes v4 -> v5:
- drop patch #8, that errored-out when an excluded file did have
one or more associated hashes (Arnout)
- typoes (Arnout)
Changes v3 -> v4:
- add missing fake-hash for uClibc eXtensa git snapshot; add uClibc
daily snapshots to exclusion list (Arnout)
- drop using a magic value; use a list of excluded files (Arnout)
Changes v2 -> v3:
- add hashes for gcc and binutils
- fix a few more typoes
Changes v1 -> v2:
- fix a few typoes
Regards,
Yann E. MORIN.
The following changes since commit 81e22ebd5ee3b9aa36fcbc86602a8fc5bfe87c17:
package/python-m2crypto: add hash (2015-04-19 14:25:28 +0200)
are available in the git repository at:
git://git.busybox.net/~ymorin/git/buildroot yem/dl-hash-toolchains
for you to fetch changes up to 92db9d9c24d6a53fa0db2aa7b3bff1456498d690:
support/download: restore mandatory check of hashes (2015-04-19 14:35:03 +0200)
----------------------------------------------------------------
Yann E. MORIN (7):
package/gcc: add hashes
package/binutils: add hashes
package/uclibc: add missing hash for eXtensa
support/download: add possibility to not fail on missing hash
toolchain/external: ignore missing hash for custom downloaded toolchain
package/uclibc: ignore missing hash for snapshots
support/download: restore mandatory check of hashes
package/binutils/binutils.hash | 7 +++++++
package/gcc/gcc-final/gcc-final.hash | 1 +
package/gcc/gcc-initial/gcc-initial.hash | 1 +
package/gcc/gcc.hash | 10 ++++++++++
package/pkg-download.mk | 3 +++
package/uclibc/uclibc.hash | 3 +++
package/uclibc/uclibc.mk | 1 +
support/download/check-hash | 8 +++++++-
toolchain/toolchain-external/toolchain-external.mk | 2 ++
9 files changed, 35 insertions(+), 1 deletion(-)
create mode 100644 package/binutils/binutils.hash
create mode 120000 package/gcc/gcc-final/gcc-final.hash
create mode 120000 package/gcc/gcc-initial/gcc-initial.hash
create mode 100644 package/gcc/gcc.hash
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 2/7 v5] package/binutils: add hashes
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes Yann E. MORIN
@ 2015-04-19 12:44 ` Yann E. MORIN
2015-04-19 16:42 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
` (5 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
Changes v4 -> v5:
- use alternate upstream as source for hashes (Arnout)
---
package/binutils/binutils.hash | 7 +++++++
1 file changed, 7 insertions(+)
create mode 100644 package/binutils/binutils.hash
diff --git a/package/binutils/binutils.hash b/package/binutils/binutils.hash
new file mode 100644
index 0000000..028fc10
--- /dev/null
+++ b/package/binutils/binutils.hash
@@ -0,0 +1,7 @@
+# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
+sha512 ffe8ef263ef99183e8cc823fe8487ff7d0f7bf9a8efd2853b5f4636aca0023850d13de4eac7d77a5f69413d8a50e6f95bb14569be53df86c0bce38034525ab74 binutils-2.22.tar.bz2
+sha512 dec753bbba008f1526b89cf1bd85feba78f362f5333ffdf93953fd131eb755976dec82a0a4ba38c43d2434da007137780cfe674de5414be5cf7ce7fbc6af6d16 binutils-2.23.2.tar.bz2
+sha512 5ec95ad47d49b12c4558a8db0ca2109d3ee1955e3776057f3330c4506f8f4d1cf5e505fbf8a16b98403a0fcdeaaf986fe0a22be6456247dbdace63ce1f776b12 binutils-2.24.tar.bz2
+sha512 49438970642f379978aba988e3d2e7b63dab6fd0b46d91f4100f083e87a84d242089daca58572245fe620457a77bbbe2d78588ff3fb79314e500d1a39bf96f30 binutils-2.25.tar.bz2
+# No hash for the ARC variant, comes from the github-helper:
+none xxx binutils-arc-2014.12.tar.gz
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 2/7 v5] package/binutils: " Yann E. MORIN
@ 2015-04-19 12:44 ` Yann E. MORIN
2015-04-19 16:47 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 4/7 v5] support/download: add possibility to not fail on missing hash Yann E. MORIN
` (4 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
This is a git snapshot, we can't have a hash for it.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/uclibc/uclibc.hash | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
index 69cc103..971ab26 100644
--- a/package/uclibc/uclibc.hash
+++ b/package/uclibc/uclibc.hash
@@ -6,3 +6,6 @@ sha256 0a9085a11615296cfe7783f16ff29073393eb330749947adece0eeddb31705a4 uClibc-a
# From http://www.uclibc-ng.org/trac/
sha256 e561040293ba4f21dcf3285ca1f683b5a8493eb0ffd3b3e495122cfde5a64a0e uClibc-ng-1.0.1.tar.xz
+
+# No hash for this git snapshot
+none xxx uClibc-7bf35c8b7d4a1f97174eb49f47f33946b282114c.tar.gz
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 4/7 v5] support/download: add possibility to not fail on missing hash
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
` (2 preceding siblings ...)
2015-04-19 12:44 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
@ 2015-04-19 12:44 ` Yann E. MORIN
2015-04-19 17:41 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 5/7 v5] toolchain/external: ignore missing hash for custom downloaded toolchain Yann E. MORIN
` (3 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
In very constrained cases, it might be needed to not fail if a hash is
missing. This is notably the case for custom external toolchains to be
downloaded, because we do have a .hash file for external toolchains,
but we obviously can not have hashes for all existing custom toolchains
(he, "custom"!).
So, add a way to avoid failing in that case.
From the Makefile, we export the list of files for which not to check
the hash. Then, from the check-hash script, if no check was done, and
the file we were trying to match in in this exclusion list, we just exit
without error.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Changes v4 -> v5:
- micro-optimisation, use case-esac instead of a for-loop (Arnout)
- typoes (Arnout)
Changes v3 -> v4:
- drop the magic value, use a list of excluded files (Arnout)
Changes v1 -> v2:
- fix typoes in commit log
---
package/pkg-download.mk | 3 +++
support/download/check-hash | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index e274712..1fc23c4 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -60,6 +60,9 @@ domainseparator = $(if $(1),$(1),/)
# github(user,package,version): returns site of GitHub repository
github = https://github.com/$(1)/$(2)/archive/$(3)
+# Expressly do not check hashes for those files
+export BR_NO_CHECK_HASH_FOR
+
################################################################################
# The DOWNLOAD_* helpers are in charge of getting a working copy
# of the source repository for their corresponding SCM,
diff --git a/support/download/check-hash b/support/download/check-hash
index 678a7ef..1280322 100755
--- a/support/download/check-hash
+++ b/support/download/check-hash
@@ -99,6 +99,12 @@ while read t h f; do
done <"${h_file}"
if [ ${nb_checks} -eq 0 ]; then
+ case " ${BR_NO_CHECK_HASH_FOR} " in
+ " ${base} ")
+ # File explicitly has no hash
+ exit 0
+ ;;
+ esac
printf "ERROR: No hash found for %s\n" "${base}" >&2
exit 0
fi
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 5/7 v5] toolchain/external: ignore missing hash for custom downloaded toolchain
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
` (3 preceding siblings ...)
2015-04-19 12:44 ` [Buildroot] [PATCH 4/7 v5] support/download: add possibility to not fail on missing hash Yann E. MORIN
@ 2015-04-19 12:44 ` Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 6/7 v5] package/uclibc: ignore missing hash for snapshots Yann E. MORIN
` (2 subsequent siblings)
7 siblings, 0 replies; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
We will *always* be missing a hash file for custom external toolchains
that are downloaded.
So, just ignore that failure.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Chamges v3 -> v4:
- drop magic value, append to the exclusion list (Arnout)
Changes v1 -> v2:
- fix typoes in title
---
toolchain/toolchain-external/toolchain-external.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index c0429bb..09b16d1 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -400,6 +400,8 @@ else
# Custom toolchain
TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
+# We can't check hashes for custom downloaded toolchains
+BR_NO_CHECK_HASH_FOR += $(TOOLCHAIN_EXTERNAL_SOURCE)
endif
# In fact, we don't need to download the toolchain, since it is already
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 6/7 v5] package/uclibc: ignore missing hash for snapshots
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
` (4 preceding siblings ...)
2015-04-19 12:44 ` [Buildroot] [PATCH 5/7 v5] toolchain/external: ignore missing hash for custom downloaded toolchain Yann E. MORIN
@ 2015-04-19 12:44 ` Yann E. MORIN
2015-04-19 17:46 ` Arnout Vandecappelle
2015-04-19 12:45 ` [Buildroot] [PATCH 7/7 v5] support/download: restore mandatory check of hashes Yann E. MORIN
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
7 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:44 UTC (permalink / raw)
To: buildroot
We can't have a hash for snapshots, so add them to the exclusion list.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/uclibc/uclibc.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index 72a46d9..1ec8b10 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -11,6 +11,7 @@ UCLIBC_LICENSE_FILES = COPYING.LIB
ifeq ($(BR2_UCLIBC_VERSION_SNAPSHOT),y)
UCLIBC_SITE = http://www.uclibc.org/downloads/snapshots
+BR_NO_CHECK_HASH_FOR += uClibc-$(UCLIBC_VERSION).tar.xz
else ifeq ($(BR2_UCLIBC_VERSION_NG),y)
UCLIBC_SITE = http://downloads.uclibc-ng.org/releases/$(UCLIBC_VERSION)
UCLIBC_SOURCE = uClibc-ng-$(UCLIBC_VERSION).tar.xz
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 7/7 v5] support/download: restore mandatory check of hashes
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
` (5 preceding siblings ...)
2015-04-19 12:44 ` [Buildroot] [PATCH 6/7 v5] package/uclibc: ignore missing hash for snapshots Yann E. MORIN
@ 2015-04-19 12:45 ` Yann E. MORIN
2015-04-19 17:54 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
7 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 12:45 UTC (permalink / raw)
To: buildroot
Now that custom external toolchains to be downloaded proprely instruct
to not fail on a missing hash, restore the mandatory hash check for
everything else.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
support/download/check-hash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/download/check-hash b/support/download/check-hash
index 1280322..383bd5c 100755
--- a/support/download/check-hash
+++ b/support/download/check-hash
@@ -106,5 +106,5 @@ if [ ${nb_checks} -eq 0 ]; then
;;
esac
printf "ERROR: No hash found for %s\n" "${base}" >&2
- exit 0
+ exit 3
fi
--
1.9.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes
2015-04-19 12:44 ` [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes Yann E. MORIN
@ 2015-04-19 16:41 ` Arnout Vandecappelle
0 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 16:41 UTC (permalink / raw)
To: buildroot
On 19/04/15 14:44, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Arnout Vandecappelle <arnout@mind.be>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
>
> ---
> Changes v4 -> v5:
> - use alternate upstream as source of hashes (Arnout)
> ---
> package/gcc/gcc-final/gcc-final.hash | 1 +
> package/gcc/gcc-initial/gcc-initial.hash | 1 +
> package/gcc/gcc.hash | 10 ++++++++++
> 3 files changed, 12 insertions(+)
> create mode 120000 package/gcc/gcc-final/gcc-final.hash
> create mode 120000 package/gcc/gcc-initial/gcc-initial.hash
> create mode 100644 package/gcc/gcc.hash
>
> diff --git a/package/gcc/gcc-final/gcc-final.hash b/package/gcc/gcc-final/gcc-final.hash
> new file mode 120000
> index 0000000..7ac9361
> --- /dev/null
> +++ b/package/gcc/gcc-final/gcc-final.hash
> @@ -0,0 +1 @@
> +../gcc.hash
> \ No newline at end of file
> diff --git a/package/gcc/gcc-initial/gcc-initial.hash b/package/gcc/gcc-initial/gcc-initial.hash
> new file mode 120000
> index 0000000..7ac9361
> --- /dev/null
> +++ b/package/gcc/gcc-initial/gcc-initial.hash
> @@ -0,0 +1 @@
> +../gcc.hash
> \ No newline at end of file
> diff --git a/package/gcc/gcc.hash b/package/gcc/gcc.hash
> new file mode 100644
> index 0000000..5eec97f
> --- /dev/null
> +++ b/package/gcc/gcc.hash
> @@ -0,0 +1,10 @@
> +# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.5.4/sha512.sum
> +sha512 78696b287d46aacd6f150920da376ea32f58ad9f0dafd2d3b7fa6dbdd8dd7afe659108d1dfaa5807617fc5248719f50b39c37ade0173ea5b9fec2091f4656115 gcc-4.5.4.tar.bz2
> +# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.7.4/sha512.sum
> +sha512 dfcb737073191e628231031a3571ec77ee760a59377630f4a6e4fdfa66f9ddad39fde47e3f0f227eb43cdf90e0d34cde5abdc9ac892c1e111a911062a66c9189 gcc-4.7.4.tar.bz2
> +# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.8.4/sha512.sum
> +sha512 b4c84ebd754c026029d706ef52c4242df4dcadc6a22cc5669b3aa37ac9dc25bc9cd9651fda83fb24dd5d17b1710e6865a35bb6c5cd9b95d0971717453935ae8e gcc-4.8.4.tar.bz2
> +# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.9.2/sha512.sum
> +sha512 e96cba06d572dbe7f382a2b00fd9297dcf9f9219d46a9ad0bd904dc36d5e7db3335e422640b79a27fed6fde91b0731732b94a0e2fbcd47344d6779f8ba1f4f9c gcc-4.9.2.tar.bz2
> +# No hash for the ARC variant, comes from the github-helper:
> +none xxx gcc-arc-2014.12.tar.gz
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 2/7 v5] package/binutils: add hashes
2015-04-19 12:44 ` [Buildroot] [PATCH 2/7 v5] package/binutils: " Yann E. MORIN
@ 2015-04-19 16:42 ` Arnout Vandecappelle
0 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 16:42 UTC (permalink / raw)
To: buildroot
On 19/04/15 14:44, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Arnout Vandecappelle <arnout@mind.be>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> Changes v4 -> v5:
> - use alternate upstream as source for hashes (Arnout)
> ---
> package/binutils/binutils.hash | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 package/binutils/binutils.hash
>
> diff --git a/package/binutils/binutils.hash b/package/binutils/binutils.hash
> new file mode 100644
> index 0000000..028fc10
> --- /dev/null
> +++ b/package/binutils/binutils.hash
> @@ -0,0 +1,7 @@
> +# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
> +sha512 ffe8ef263ef99183e8cc823fe8487ff7d0f7bf9a8efd2853b5f4636aca0023850d13de4eac7d77a5f69413d8a50e6f95bb14569be53df86c0bce38034525ab74 binutils-2.22.tar.bz2
> +sha512 dec753bbba008f1526b89cf1bd85feba78f362f5333ffdf93953fd131eb755976dec82a0a4ba38c43d2434da007137780cfe674de5414be5cf7ce7fbc6af6d16 binutils-2.23.2.tar.bz2
> +sha512 5ec95ad47d49b12c4558a8db0ca2109d3ee1955e3776057f3330c4506f8f4d1cf5e505fbf8a16b98403a0fcdeaaf986fe0a22be6456247dbdace63ce1f776b12 binutils-2.24.tar.bz2
> +sha512 49438970642f379978aba988e3d2e7b63dab6fd0b46d91f4100f083e87a84d242089daca58572245fe620457a77bbbe2d78588ff3fb79314e500d1a39bf96f30 binutils-2.25.tar.bz2
> +# No hash for the ARC variant, comes from the github-helper:
> +none xxx binutils-arc-2014.12.tar.gz
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa
2015-04-19 12:44 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
@ 2015-04-19 16:47 ` Arnout Vandecappelle
2015-04-19 16:57 ` [Buildroot] [PATCH] uclibc: update hash for arc Arnout Vandecappelle
2015-04-19 17:03 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
0 siblings, 2 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 16:47 UTC (permalink / raw)
To: buildroot
On 19/04/15 14:44, Yann E. MORIN wrote:
> This is a git snapshot, we can't have a hash for it.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
My reviewed-by still stands, but you should probably also fix the hash for arc,
which currently still points at 2014.08 while we use 2014.12 and it's from github
none xxx uClibc-arc-2014.12.tar.gz
Regards,
Arnout
> ---
> package/uclibc/uclibc.hash | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
> index 69cc103..971ab26 100644
> --- a/package/uclibc/uclibc.hash
> +++ b/package/uclibc/uclibc.hash
> @@ -6,3 +6,6 @@ sha256 0a9085a11615296cfe7783f16ff29073393eb330749947adece0eeddb31705a4 uClibc-a
>
> # From http://www.uclibc-ng.org/trac/
> sha256 e561040293ba4f21dcf3285ca1f683b5a8493eb0ffd3b3e495122cfde5a64a0e uClibc-ng-1.0.1.tar.xz
> +
> +# No hash for this git snapshot
> +none xxx uClibc-7bf35c8b7d4a1f97174eb49f47f33946b282114c.tar.gz
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH] uclibc: update hash for arc
2015-04-19 16:47 ` Arnout Vandecappelle
@ 2015-04-19 16:57 ` Arnout Vandecappelle
2015-04-19 17:03 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
1 sibling, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 16:57 UTC (permalink / raw)
To: buildroot
The old hash for 2014.08 was never updated. Since uclibc-arc-2014.12 is
downloaded from the github helper, it is converted into a 'none' hash.
Reordered the hashes so the none-hashes are together.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
This should be inserted into Yann's series before or after 3/7.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/uclibc/uclibc.hash | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
index 971ab26..01e71c0 100644
--- a/package/uclibc/uclibc.hash
+++ b/package/uclibc/uclibc.hash
@@ -1,11 +1,11 @@
# Locally calculated after checking pgp signature
sha256 62333167b79afb0b25a843513288c67b59547acf653e8fbe62ee64e71ebd1587 uClibc-0.9.33.2.tar.xz
-# Locally calculated
-sha256 0a9085a11615296cfe7783f16ff29073393eb330749947adece0eeddb31705a4 uClibc-arc-2014.08.tar.gz
-
# From http://www.uclibc-ng.org/trac/
sha256 e561040293ba4f21dcf3285ca1f683b5a8493eb0ffd3b3e495122cfde5a64a0e uClibc-ng-1.0.1.tar.xz
+# No hash for the ARC variant, comes from the github-helper
+none xxx uClibc-arc-2014.12.tar.gz
+
# No hash for this git snapshot
none xxx uClibc-7bf35c8b7d4a1f97174eb49f47f33946b282114c.tar.gz
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa
2015-04-19 16:47 ` Arnout Vandecappelle
2015-04-19 16:57 ` [Buildroot] [PATCH] uclibc: update hash for arc Arnout Vandecappelle
@ 2015-04-19 17:03 ` Yann E. MORIN
1 sibling, 0 replies; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 17:03 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-04-19 18:47 +0200, Arnout Vandecappelle spake thusly:
> On 19/04/15 14:44, Yann E. MORIN wrote:
> > This is a git snapshot, we can't have a hash for it.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > Cc: Arnout Vandecappelle <arnout@mind.be>
> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> My reviewed-by still stands, but you should probably also fix the hash for arc,
> which currently still points at 2014.08 while we use 2014.12 and it's from github
>
> none xxx uClibc-arc-2014.12.tar.gz
Damn, I did not even check that the version was correct. Thanks for
spotting! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 4/7 v5] support/download: add possibility to not fail on missing hash
2015-04-19 12:44 ` [Buildroot] [PATCH 4/7 v5] support/download: add possibility to not fail on missing hash Yann E. MORIN
@ 2015-04-19 17:41 ` Arnout Vandecappelle
0 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:41 UTC (permalink / raw)
To: buildroot
On 19/04/15 14:44, Yann E. MORIN wrote:
> In very constrained cases, it might be needed to not fail if a hash is
> missing. This is notably the case for custom external toolchains to be
> downloaded, because we do have a .hash file for external toolchains,
> but we obviously can not have hashes for all existing custom toolchains
> (he, "custom"!).
>
> So, add a way to avoid failing in that case.
>
>>From the Makefile, we export the list of files for which not to check
> the hash. Then, from the check-hash script, if no check was done, and
> the file we were trying to match in in this exclusion list, we just exit
> without error.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Ouch, it doesn't work...
>
> ---
> Changes v4 -> v5:
> - micro-optimisation, use case-esac instead of a for-loop (Arnout)
> - typoes (Arnout)
>
> Changes v3 -> v4:
> - drop the magic value, use a list of excluded files (Arnout)
>
> Changes v1 -> v2:
> - fix typoes in commit log
> ---
> package/pkg-download.mk | 3 +++
> support/download/check-hash | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index e274712..1fc23c4 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -60,6 +60,9 @@ domainseparator = $(if $(1),$(1),/)
> # github(user,package,version): returns site of GitHub repository
> github = https://github.com/$(1)/$(2)/archive/$(3)
>
> +# Expressly do not check hashes for those files
> +export BR_NO_CHECK_HASH_FOR
The comment is not very clear. Perhaps
# Files in this variable do not get their hash checked.
export BR_NO_CHECK_HASH_FOR
> +
> ################################################################################
> # The DOWNLOAD_* helpers are in charge of getting a working copy
> # of the source repository for their corresponding SCM,
> diff --git a/support/download/check-hash b/support/download/check-hash
> index 678a7ef..1280322 100755
> --- a/support/download/check-hash
> +++ b/support/download/check-hash
> @@ -99,6 +99,12 @@ while read t h f; do
> done <"${h_file}"
>
> if [ ${nb_checks} -eq 0 ]; then
> + case " ${BR_NO_CHECK_HASH_FOR} " in
> + " ${base} ")
This does not work. If there is more than one file, there can be something
before/after ${base}, so we need to add * at the beginning and the end. But
then, the quotes stop the matching of *, so we have to write:
*\ ${base}\ *)
Regards,
Arnout
> + # File explicitly has no hash
> + exit 0
> + ;;
> + esac
> printf "ERROR: No hash found for %s\n" "${base}" >&2
> exit 0
> fi
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 6/7 v5] package/uclibc: ignore missing hash for snapshots
2015-04-19 12:44 ` [Buildroot] [PATCH 6/7 v5] package/uclibc: ignore missing hash for snapshots Yann E. MORIN
@ 2015-04-19 17:46 ` Arnout Vandecappelle
0 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:46 UTC (permalink / raw)
To: buildroot
On 19/04/15 14:44, Yann E. MORIN wrote:
> We can't have a hash for snapshots, so add them to the exclusion list.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/uclibc/uclibc.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index 72a46d9..1ec8b10 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -11,6 +11,7 @@ UCLIBC_LICENSE_FILES = COPYING.LIB
>
> ifeq ($(BR2_UCLIBC_VERSION_SNAPSHOT),y)
> UCLIBC_SITE = http://www.uclibc.org/downloads/snapshots
> +BR_NO_CHECK_HASH_FOR += uClibc-$(UCLIBC_VERSION).tar.xz
The file is .bz2, not .xz.
I think it's better to put $(UCLIBC_SOURCE) instead.
Regards,
Arnout
> else ifeq ($(BR2_UCLIBC_VERSION_NG),y)
> UCLIBC_SITE = http://downloads.uclibc-ng.org/releases/$(UCLIBC_VERSION)
> UCLIBC_SOURCE = uClibc-ng-$(UCLIBC_VERSION).tar.xz
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH 7/7 v5] support/download: restore mandatory check of hashes
2015-04-19 12:45 ` [Buildroot] [PATCH 7/7 v5] support/download: restore mandatory check of hashes Yann E. MORIN
@ 2015-04-19 17:54 ` Arnout Vandecappelle
0 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:54 UTC (permalink / raw)
To: buildroot
On 19/04/15 14:45, Yann E. MORIN wrote:
> Now that custom external toolchains to be downloaded proprely instruct
properly
Also, it's not just the external toolchains that you fixed in this series.
Regards,
Arnout
> to not fail on a missing hash, restore the mandatory hash check for
> everything else.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> support/download/check-hash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/download/check-hash b/support/download/check-hash
> index 1280322..383bd5c 100755
> --- a/support/download/check-hash
> +++ b/support/download/check-hash
> @@ -106,5 +106,5 @@ if [ ${nb_checks} -eq 0 ]; then
> ;;
> esac
> printf "ERROR: No hash found for %s\n" "${base}" >&2
> - exit 0
> + exit 3
> fi
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 1/8] package/gcc: add hashes
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
` (6 preceding siblings ...)
2015-04-19 12:45 ` [Buildroot] [PATCH 7/7 v5] support/download: restore mandatory check of hashes Yann E. MORIN
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 2/8] package/binutils: " Arnout Vandecappelle
` (6 more replies)
7 siblings, 7 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/gcc/gcc-final/gcc-final.hash | 1 +
package/gcc/gcc-initial/gcc-initial.hash | 1 +
package/gcc/gcc.hash | 10 ++++++++++
3 files changed, 12 insertions(+)
create mode 120000 package/gcc/gcc-final/gcc-final.hash
create mode 120000 package/gcc/gcc-initial/gcc-initial.hash
create mode 100644 package/gcc/gcc.hash
diff --git a/package/gcc/gcc-final/gcc-final.hash b/package/gcc/gcc-final/gcc-final.hash
new file mode 120000
index 0000000..7ac9361
--- /dev/null
+++ b/package/gcc/gcc-final/gcc-final.hash
@@ -0,0 +1 @@
+../gcc.hash
\ No newline at end of file
diff --git a/package/gcc/gcc-initial/gcc-initial.hash b/package/gcc/gcc-initial/gcc-initial.hash
new file mode 120000
index 0000000..7ac9361
--- /dev/null
+++ b/package/gcc/gcc-initial/gcc-initial.hash
@@ -0,0 +1 @@
+../gcc.hash
\ No newline at end of file
diff --git a/package/gcc/gcc.hash b/package/gcc/gcc.hash
new file mode 100644
index 0000000..5eec97f
--- /dev/null
+++ b/package/gcc/gcc.hash
@@ -0,0 +1,10 @@
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.5.4/sha512.sum
+sha512 78696b287d46aacd6f150920da376ea32f58ad9f0dafd2d3b7fa6dbdd8dd7afe659108d1dfaa5807617fc5248719f50b39c37ade0173ea5b9fec2091f4656115 gcc-4.5.4.tar.bz2
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.7.4/sha512.sum
+sha512 dfcb737073191e628231031a3571ec77ee760a59377630f4a6e4fdfa66f9ddad39fde47e3f0f227eb43cdf90e0d34cde5abdc9ac892c1e111a911062a66c9189 gcc-4.7.4.tar.bz2
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.8.4/sha512.sum
+sha512 b4c84ebd754c026029d706ef52c4242df4dcadc6a22cc5669b3aa37ac9dc25bc9cd9651fda83fb24dd5d17b1710e6865a35bb6c5cd9b95d0971717453935ae8e gcc-4.8.4.tar.bz2
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-4.9.2/sha512.sum
+sha512 e96cba06d572dbe7f382a2b00fd9297dcf9f9219d46a9ad0bd904dc36d5e7db3335e422640b79a27fed6fde91b0731732b94a0e2fbcd47344d6779f8ba1f4f9c gcc-4.9.2.tar.bz2
+# No hash for the ARC variant, comes from the github-helper:
+none xxx gcc-arc-2014.12.tar.gz
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 2/8] package/binutils: add hashes
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 3/8] package/uclibc: add missing hash for eXtensa Arnout Vandecappelle
` (5 subsequent siblings)
6 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/binutils/binutils.hash | 7 +++++++
1 file changed, 7 insertions(+)
create mode 100644 package/binutils/binutils.hash
diff --git a/package/binutils/binutils.hash b/package/binutils/binutils.hash
new file mode 100644
index 0000000..028fc10
--- /dev/null
+++ b/package/binutils/binutils.hash
@@ -0,0 +1,7 @@
+# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
+sha512 ffe8ef263ef99183e8cc823fe8487ff7d0f7bf9a8efd2853b5f4636aca0023850d13de4eac7d77a5f69413d8a50e6f95bb14569be53df86c0bce38034525ab74 binutils-2.22.tar.bz2
+sha512 dec753bbba008f1526b89cf1bd85feba78f362f5333ffdf93953fd131eb755976dec82a0a4ba38c43d2434da007137780cfe674de5414be5cf7ce7fbc6af6d16 binutils-2.23.2.tar.bz2
+sha512 5ec95ad47d49b12c4558a8db0ca2109d3ee1955e3776057f3330c4506f8f4d1cf5e505fbf8a16b98403a0fcdeaaf986fe0a22be6456247dbdace63ce1f776b12 binutils-2.24.tar.bz2
+sha512 49438970642f379978aba988e3d2e7b63dab6fd0b46d91f4100f083e87a84d242089daca58572245fe620457a77bbbe2d78588ff3fb79314e500d1a39bf96f30 binutils-2.25.tar.bz2
+# No hash for the ARC variant, comes from the github-helper:
+none xxx binutils-arc-2014.12.tar.gz
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 3/8] package/uclibc: add missing hash for eXtensa
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 2/8] package/binutils: " Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 4/8] uclibc: update hash for arc Arnout Vandecappelle
` (4 subsequent siblings)
6 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
This is a git snapshot, we can't have a hash for it.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/uclibc/uclibc.hash | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
index 69cc103..971ab26 100644
--- a/package/uclibc/uclibc.hash
+++ b/package/uclibc/uclibc.hash
@@ -6,3 +6,6 @@ sha256 0a9085a11615296cfe7783f16ff29073393eb330749947adece0eeddb31705a4 uClibc-a
# From http://www.uclibc-ng.org/trac/
sha256 e561040293ba4f21dcf3285ca1f683b5a8493eb0ffd3b3e495122cfde5a64a0e uClibc-ng-1.0.1.tar.xz
+
+# No hash for this git snapshot
+none xxx uClibc-7bf35c8b7d4a1f97174eb49f47f33946b282114c.tar.gz
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 4/8] uclibc: update hash for arc
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 2/8] package/binutils: " Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 3/8] package/uclibc: add missing hash for eXtensa Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 18:28 ` Yann E. MORIN
2015-04-19 17:55 ` [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash Arnout Vandecappelle
` (3 subsequent siblings)
6 siblings, 1 reply; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
The old hash for 2014.08 was never updated. Since uclibc-arc-2014.12 is
downloaded from the github helper, it is converted into a 'none' hash.
Reordered the hashes so the none-hashes are together.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
This should be inserted into Yann's series before or after 3/7.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/uclibc/uclibc.hash | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
index 971ab26..01e71c0 100644
--- a/package/uclibc/uclibc.hash
+++ b/package/uclibc/uclibc.hash
@@ -1,11 +1,11 @@
# Locally calculated after checking pgp signature
sha256 62333167b79afb0b25a843513288c67b59547acf653e8fbe62ee64e71ebd1587 uClibc-0.9.33.2.tar.xz
-# Locally calculated
-sha256 0a9085a11615296cfe7783f16ff29073393eb330749947adece0eeddb31705a4 uClibc-arc-2014.08.tar.gz
-
# From http://www.uclibc-ng.org/trac/
sha256 e561040293ba4f21dcf3285ca1f683b5a8493eb0ffd3b3e495122cfde5a64a0e uClibc-ng-1.0.1.tar.xz
+# No hash for the ARC variant, comes from the github-helper
+none xxx uClibc-arc-2014.12.tar.gz
+
# No hash for this git snapshot
none xxx uClibc-7bf35c8b7d4a1f97174eb49f47f33946b282114c.tar.gz
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
` (2 preceding siblings ...)
2015-04-19 17:55 ` [Buildroot] [PATCH v6 4/8] uclibc: update hash for arc Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 18:38 ` Yann E. MORIN
2015-04-19 17:55 ` [Buildroot] [PATCH v6 6/8] toolchain/external: ignore missing hash for custom downloaded toolchain Arnout Vandecappelle
` (2 subsequent siblings)
6 siblings, 1 reply; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
In very constrained cases, it might be needed to not fail if a hash is
missing. This is notably the case for custom external toolchains to be
downloaded, because we do have a .hash file for external toolchains,
but we obviously can not have hashes for all existing custom toolchains
(he, "custom"!).
So, add a way to avoid failing in that case.
From the Makefile, we export the list of files for which not to check
the hash. Then, from the check-hash script, if no check was done, and
the file we were trying to match in in this exclusion list, we just exit
without error.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[Arnout: fix the pattern in the case statement]
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Changed v5 -> v6:
- fix the pattern in the case clause
Changes v4 -> v5:
- micro-optimisation, use case-esac instead of a for-loop (Arnout)
- typoes (Arnout)
Changes v3 -> v4:
- drop the magic value, use a list of excluded files (Arnout)
Changes v1 -> v2:
- fix typoes in commit log
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/pkg-download.mk | 3 +++
support/download/check-hash | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index e274712..1fc23c4 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -60,6 +60,9 @@ domainseparator = $(if $(1),$(1),/)
# github(user,package,version): returns site of GitHub repository
github = https://github.com/$(1)/$(2)/archive/$(3)
+# Expressly do not check hashes for those files
+export BR_NO_CHECK_HASH_FOR
+
################################################################################
# The DOWNLOAD_* helpers are in charge of getting a working copy
# of the source repository for their corresponding SCM,
diff --git a/support/download/check-hash b/support/download/check-hash
index 678a7ef..d378701 100755
--- a/support/download/check-hash
+++ b/support/download/check-hash
@@ -99,6 +99,12 @@ while read t h f; do
done <"${h_file}"
if [ ${nb_checks} -eq 0 ]; then
+ case " ${BR_NO_CHECK_HASH_FOR} " in
+ *\ ${base}\ *)
+ # File explicitly has no hash
+ exit 0
+ ;;
+ esac
printf "ERROR: No hash found for %s\n" "${base}" >&2
exit 0
fi
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 6/8] toolchain/external: ignore missing hash for custom downloaded toolchain
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
` (3 preceding siblings ...)
2015-04-19 17:55 ` [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 7/8] package/uclibc: ignore missing hash for snapshots Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 8/8] support/download: restore mandatory check of hashes Arnout Vandecappelle
6 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
We will *always* be missing a hash file for custom external toolchains
that are downloaded.
So, just ignore that failure.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
toolchain/toolchain-external/toolchain-external.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index 2427463..5576dcb 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -400,6 +400,8 @@ else
# Custom toolchain
TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
+# We can't check hashes for custom downloaded toolchains
+BR_NO_CHECK_HASH_FOR += $(TOOLCHAIN_EXTERNAL_SOURCE)
endif
# In fact, we don't need to download the toolchain, since it is already
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 7/8] package/uclibc: ignore missing hash for snapshots
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
` (4 preceding siblings ...)
2015-04-19 17:55 ` [Buildroot] [PATCH v6 6/8] toolchain/external: ignore missing hash for custom downloaded toolchain Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 8/8] support/download: restore mandatory check of hashes Arnout Vandecappelle
6 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
We can't have a hash for snapshots, so add them to the exclusion list.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[Arnout: use the correct file name]
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Changes v1 -> v6: (Arnout)
- use $(UCLIBC_SOURCE) instead of a wrong filename
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/uclibc/uclibc.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index 72a46d9..72261f3 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -11,6 +11,7 @@ UCLIBC_LICENSE_FILES = COPYING.LIB
ifeq ($(BR2_UCLIBC_VERSION_SNAPSHOT),y)
UCLIBC_SITE = http://www.uclibc.org/downloads/snapshots
+BR_NO_CHECK_HASH_FOR += $(UCLIBC_SOURCE)
else ifeq ($(BR2_UCLIBC_VERSION_NG),y)
UCLIBC_SITE = http://downloads.uclibc-ng.org/releases/$(UCLIBC_VERSION)
UCLIBC_SOURCE = uClibc-ng-$(UCLIBC_VERSION).tar.xz
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 8/8] support/download: restore mandatory check of hashes
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
` (5 preceding siblings ...)
2015-04-19 17:55 ` [Buildroot] [PATCH v6 7/8] package/uclibc: ignore missing hash for snapshots Arnout Vandecappelle
@ 2015-04-19 17:55 ` Arnout Vandecappelle
6 siblings, 0 replies; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-19 17:55 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Now that custom external toolchains to be downloaded and the internal
toolchain components properly instruct to not fail on a missing hash,
restore the mandatory hash check for everything else.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[Arnout: fix typo in commit message]
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
support/download/check-hash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/download/check-hash b/support/download/check-hash
index d378701..f88b78b 100755
--- a/support/download/check-hash
+++ b/support/download/check-hash
@@ -106,5 +106,5 @@ if [ ${nb_checks} -eq 0 ]; then
;;
esac
printf "ERROR: No hash found for %s\n" "${base}" >&2
- exit 0
+ exit 3
fi
--
2.1.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 4/8] uclibc: update hash for arc
2015-04-19 17:55 ` [Buildroot] [PATCH v6 4/8] uclibc: update hash for arc Arnout Vandecappelle
@ 2015-04-19 18:28 ` Yann E. MORIN
0 siblings, 0 replies; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 18:28 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-04-19 19:55 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> The old hash for 2014.08 was never updated. Since uclibc-arc-2014.12 is
> downloaded from the github helper, it is converted into a 'none' hash.
>
> Reordered the hashes so the none-hashes are together.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> This should be inserted into Yann's series before or after 3/7.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/uclibc/uclibc.hash | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/uclibc/uclibc.hash b/package/uclibc/uclibc.hash
> index 971ab26..01e71c0 100644
> --- a/package/uclibc/uclibc.hash
> +++ b/package/uclibc/uclibc.hash
> @@ -1,11 +1,11 @@
> # Locally calculated after checking pgp signature
> sha256 62333167b79afb0b25a843513288c67b59547acf653e8fbe62ee64e71ebd1587 uClibc-0.9.33.2.tar.xz
>
> -# Locally calculated
> -sha256 0a9085a11615296cfe7783f16ff29073393eb330749947adece0eeddb31705a4 uClibc-arc-2014.08.tar.gz
> -
> # From http://www.uclibc-ng.org/trac/
> sha256 e561040293ba4f21dcf3285ca1f683b5a8493eb0ffd3b3e495122cfde5a64a0e uClibc-ng-1.0.1.tar.xz
>
> +# No hash for the ARC variant, comes from the github-helper
> +none xxx uClibc-arc-2014.12.tar.gz
> +
> # No hash for this git snapshot
> none xxx uClibc-7bf35c8b7d4a1f97174eb49f47f33946b282114c.tar.gz
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash
2015-04-19 17:55 ` [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash Arnout Vandecappelle
@ 2015-04-19 18:38 ` Yann E. MORIN
2015-04-20 7:45 ` Arnout Vandecappelle
0 siblings, 1 reply; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-19 18:38 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-04-19 19:55 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> In very constrained cases, it might be needed to not fail if a hash is
> missing. This is notably the case for custom external toolchains to be
> downloaded, because we do have a .hash file for external toolchains,
> but we obviously can not have hashes for all existing custom toolchains
> (he, "custom"!).
>
> So, add a way to avoid failing in that case.
>
> >From the Makefile, we export the list of files for which not to check
Stray leading '>' probably for a copy-paste from your mailer.
> the hash. Then, from the check-hash script, if no check was done, and
> the file we were trying to match in in this exclusion list, we just exit
> without error.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> [Arnout: fix the pattern in the case statement]
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Changed v5 -> v6:
> - fix the pattern in the case clause
Yeah, thanks. Obviously, I did not test that case (although the other
tests I ran were OK, I missed testing the custom toolchain to be
downloaded, which is a shame since that's exactly what I was trying to
fix with this series, to begin with...).
[--SNIP--]
> diff --git a/support/download/check-hash b/support/download/check-hash
> index 678a7ef..d378701 100755
> --- a/support/download/check-hash
> +++ b/support/download/check-hash
> @@ -99,6 +99,12 @@ while read t h f; do
> done <"${h_file}"
>
> if [ ${nb_checks} -eq 0 ]; then
> + case " ${BR_NO_CHECK_HASH_FOR} " in
> + *\ ${base}\ *)
I don't like much the escaping when it can be avoided. We can still use
quotes (even if not very much better), like so:
*" ${base} "*
Regards,
Yann E. MORIN.
> + # File explicitly has no hash
> + exit 0
> + ;;
> + esac
> printf "ERROR: No hash found for %s\n" "${base}" >&2
> exit 0
> fi
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash
2015-04-19 18:38 ` Yann E. MORIN
@ 2015-04-20 7:45 ` Arnout Vandecappelle
2015-04-20 21:24 ` Yann E. MORIN
0 siblings, 1 reply; 28+ messages in thread
From: Arnout Vandecappelle @ 2015-04-20 7:45 UTC (permalink / raw)
To: buildroot
On 19/04/15 20:38, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2015-04-19 19:55 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
>> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>
>> In very constrained cases, it might be needed to not fail if a hash is
>> missing. This is notably the case for custom external toolchains to be
>> downloaded, because we do have a .hash file for external toolchains,
>> but we obviously can not have hashes for all existing custom toolchains
>> (he, "custom"!).
>>
>> So, add a way to avoid failing in that case.
>>
>> >From the Makefile, we export the list of files for which not to check
>
> Stray leading '>' probably for a copy-paste from your mailer.
pwclient git-am actually... I would have expected patchwork (or actually, the
python mail handling infra) to handle >From correctly...
>
>> the hash. Then, from the check-hash script, if no check was done, and
>> the file we were trying to match in in this exclusion list, we just exit
>> without error.
>>
[snip]
>> diff --git a/support/download/check-hash b/support/download/check-hash
>> index 678a7ef..d378701 100755
>> --- a/support/download/check-hash
>> +++ b/support/download/check-hash
>> @@ -99,6 +99,12 @@ while read t h f; do
>> done <"${h_file}"
>>
>> if [ ${nb_checks} -eq 0 ]; then
>> + case " ${BR_NO_CHECK_HASH_FOR} " in
>> + *\ ${base}\ *)
>
> I don't like much the escaping when it can be avoided. We can still use
> quotes (even if not very much better), like so:
>
> *" ${base} "*
It's your patch, modify as you like :-)
I just reposted it since I anyway had it locally modified.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 28+ messages in thread
* [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash
2015-04-20 7:45 ` Arnout Vandecappelle
@ 2015-04-20 21:24 ` Yann E. MORIN
0 siblings, 0 replies; 28+ messages in thread
From: Yann E. MORIN @ 2015-04-20 21:24 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-04-20 09:45 +0200, Arnout Vandecappelle spake thusly:
> On 19/04/15 20:38, Yann E. MORIN wrote:
[--SNIP--]
> >> >From the Makefile, we export the list of files for which not to check
> >
> > Stray leading '>' probably for a copy-paste from your mailer.
>
> pwclient git-am actually... I would have expected patchwork (or actually, the
> python mail handling infra) to handle >From correctly...
Actually, that comes from RFC 4155.
https://tools.ietf.org/html/rfc4155
TL;DR: "From " is actually used in mbox format to define the begining
of an email. Thus, any lines in a body, that begins thusly, must be
"quoted" to avoid improperly detecting the begining of an email.
See also this mail in the Patchwork ML archives:
https://lists.ozlabs.org/pipermail/patchwork/2014-November/001218.html
I don't think this was ever applied...
[--SNIP--]
> > I don't like much the escaping when it can be avoided. We can still use
> > quotes (even if not very much better), like so:
> >
> > *" ${base} "*
>
> It's your patch, modify as you like :-)
Hehe! :-)
> I just reposted it since I anyway had it locally modified.
Yeah, thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2015-04-20 21:24 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-19 12:44 [Buildroot] [PATCH 0/7 v5] toolchain: better handle hashes (branch yem/dl-hash-toolchains) Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 1/7 v5] package/gcc: add hashes Yann E. MORIN
2015-04-19 16:41 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 2/7 v5] package/binutils: " Yann E. MORIN
2015-04-19 16:42 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
2015-04-19 16:47 ` Arnout Vandecappelle
2015-04-19 16:57 ` [Buildroot] [PATCH] uclibc: update hash for arc Arnout Vandecappelle
2015-04-19 17:03 ` [Buildroot] [PATCH 3/7 v5] package/uclibc: add missing hash for eXtensa Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 4/7 v5] support/download: add possibility to not fail on missing hash Yann E. MORIN
2015-04-19 17:41 ` Arnout Vandecappelle
2015-04-19 12:44 ` [Buildroot] [PATCH 5/7 v5] toolchain/external: ignore missing hash for custom downloaded toolchain Yann E. MORIN
2015-04-19 12:44 ` [Buildroot] [PATCH 6/7 v5] package/uclibc: ignore missing hash for snapshots Yann E. MORIN
2015-04-19 17:46 ` Arnout Vandecappelle
2015-04-19 12:45 ` [Buildroot] [PATCH 7/7 v5] support/download: restore mandatory check of hashes Yann E. MORIN
2015-04-19 17:54 ` Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 1/8] package/gcc: add hashes Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 2/8] package/binutils: " Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 3/8] package/uclibc: add missing hash for eXtensa Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 4/8] uclibc: update hash for arc Arnout Vandecappelle
2015-04-19 18:28 ` Yann E. MORIN
2015-04-19 17:55 ` [Buildroot] [PATCH v6 5/8] support/download: add possibility to not fail on missing hash Arnout Vandecappelle
2015-04-19 18:38 ` Yann E. MORIN
2015-04-20 7:45 ` Arnout Vandecappelle
2015-04-20 21:24 ` Yann E. MORIN
2015-04-19 17:55 ` [Buildroot] [PATCH v6 6/8] toolchain/external: ignore missing hash for custom downloaded toolchain Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 7/8] package/uclibc: ignore missing hash for snapshots Arnout Vandecappelle
2015-04-19 17:55 ` [Buildroot] [PATCH v6 8/8] support/download: restore mandatory check of hashes Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.