First patch

First patch

[Arkadiusz Lis]

Hi guys,
I created my first patch. Could you please take a look
and check for mistakes? It's a small clean up removing checkpatch.pl
warnings. It was generated using 'git format-patch master..<mybranch>'.  
See below:

>From 231fa77d595536cdaacf364b02dd64fd45a6adc4 Mon Sep 17 00:00:00 2001
From: Arkadiusz Lis <areklis909@gmail.com>
Date: Thu, 2 Aug 2018 23:38:17 +0200
Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license
 issues

Add argument names to the function pointers in struct
dcon_platform_data.
Add SPDX-License-Identifiers to the source files.

Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
---
 drivers/staging/olpc_dcon/olpc_dcon.c        | 1 +
 drivers/staging/olpc_dcon/olpc_dcon.h        | 6 +++---
 drivers/staging/olpc_dcon/olpc_dcon_xo_1.c   | 1 +
 drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 +
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index 2744c9f..318adc4 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Mainly by David Woodhouse, somewhat modified by Jordan Crouse
  *
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index fa89bb9..0ce1a7a 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -91,10 +91,10 @@ struct dcon_priv {
 };

 struct dcon_platform_data {
-	int (*init)(struct dcon_priv *);
+	int (*init)(struct dcon_priv *dcon);
 	void (*bus_stabilize_wiggle)(void);
-	void (*set_dconload)(int);
-	int (*read_status)(u8 *);
+	void (*set_dconload)(int val);
+	int (*read_status)(u8 *status);
 };

 #include <linux/interrupt.h>
diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c b/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
index 633c58c..c72f492 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Mainly by David Woodhouse, somewhat modified by Jordan Crouse
  *
diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c b/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
index 6458442..07b70eb 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright (c) 2009,2010       One Laptop per Child
  *
--
1.9.1

First patch

[valdis.kletnieks at vt.edu]

On Thu, 02 Aug 2018 23:49:03 +0200, Arkadiusz Lis said:

> From 231fa77d595536cdaacf364b02dd64fd45a6adc4 Mon Sep 17 00:00:00 2001
> From: Arkadiusz Lis <areklis909@gmail.com>
> Date: Thu, 2 Aug 2018 23:38:17 +0200
> Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license
>  issues

One thing per patch.  That's two things, therefor....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 486 bytes
Desc: not available
URL: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20180803/8131de0f/attachment.sig>

first patch

[Jerry Snitselaar]

On Wed Dec 23 15, maoma king wrote:
> Dear
>   I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
> linux-next tree.But I never received anything about it.So I sent it
> again. You say "Doesn't apply to my tree :(".but it can be apply to
> least linux-next branch .
> I make n new patch and send it.I receive
> review(https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1048115.html)
> .
> I want to know what's wrong with me?
> how do I know that my patch is accepted?
> 

Greg said your patch doesn't apply to his staging-next branch (located
in the following repo):

https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/

If you look at the comedi.h file on the HEAD of that branch with git
blame you will see the following patch has already been applied that 
fixes up the comments:

f904c4 | 2015-11-12 | Staging: comedi: Fixed multiple commenting and spacing codig style issues. (Daniel H. Hemmingsen)

snits

> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

first patch

[Mike Krinkin]

On Wed, Dec 23, 2015 at 11:37:14AM +0800, maoma king wrote:
> Dear
>   I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
> linux-next tree.But I never received anything about it.So I sent it
> again. You say "Doesn't apply to my tree :(".but it can be apply to
> least linux-next branch .

Check against staging-testing or staging-next branches on the staging tree.
Look at this http://kernelnewbies.org/FirstKernelPatch.

> I make n new patch and send it.I receive
> review(https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1048115.html)
> .
> I want to know what's wrong with me?
> how do I know that my patch is accepted?
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

first patch

[maoma king]

Dear
  I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
linux-next tree.But I never received anything about it.So I sent it
again. You say "Doesn't apply to my tree :(".but it can be apply to
least linux-next branch .
I make n new patch and send it.I receive
review(https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1048115.html)
.
I want to know what's wrong with me?
how do I know that my patch is accepted?

First Patch

[Michael Spradling]

I tried to follow the documentation for submitting patches.
Is the following patch correctly submitted.

I just cleaned up dead code warnings....

Let me know how it is and I can continue to commit more.  I 
have written drivers just not for the Linux kernel :).  
This is a good way to look over source code and become familiar
with the kernel.

--
Mike Spradling