From: Timo Kokkonen <timo.kokkonen@offcode.fi>
To: Guenter Roeck <linux@roeck-us.net>,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org,
boris.brezillon@free-electrons.com, nicolas.ferre@atmel.com,
alexandre.belloni@free-electrons.com
Cc: Wenyou.Yang@atmel.com
Subject: Re: [PATCHv7 7/8] watchdog: omap_wdt: Fix memory leak on probe fail
Date: Mon, 27 Apr 2015 08:50:02 +0300 [thread overview]
Message-ID: <553DCE0A.6010906@offcode.fi> (raw)
In-Reply-To: <553D0503.7050207@roeck-us.net>
On 26.04.2015 18:32, Guenter Roeck wrote:
> On 04/22/2015 04:11 AM, Timo Kokkonen wrote:
>> Structures allocated on the beginning of the probe function must be
>> freed in case of failure.
>
> Really ? The functions are allocated with devm_kzalloc.
> It might be useful to introduce an error on purpose, have the code
> jump to your new label, and observe what happens.
Interesting. I wasn't aware of devm_kzalloc. I will have to remove this
patch from the series and rework the another omap patch to apply without
this. Thanks!
-Timo
WARNING: multiple messages have this Message-ID (diff)
From: timo.kokkonen@offcode.fi (Timo Kokkonen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 7/8] watchdog: omap_wdt: Fix memory leak on probe fail
Date: Mon, 27 Apr 2015 08:50:02 +0300 [thread overview]
Message-ID: <553DCE0A.6010906@offcode.fi> (raw)
In-Reply-To: <553D0503.7050207@roeck-us.net>
On 26.04.2015 18:32, Guenter Roeck wrote:
> On 04/22/2015 04:11 AM, Timo Kokkonen wrote:
>> Structures allocated on the beginning of the probe function must be
>> freed in case of failure.
>
> Really ? The functions are allocated with devm_kzalloc.
> It might be useful to introduce an error on purpose, have the code
> jump to your new label, and observe what happens.
Interesting. I wasn't aware of devm_kzalloc. I will have to remove this
patch from the series and rework the another omap patch to apply without
this. Thanks!
-Timo
next prev parent reply other threads:[~2015-04-27 5:50 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 11:11 [PATCHv7 0/8] watchdog: Extend kernel API and add early_timeout_sec feature Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 1/8] watchdog: Extend kernel API to know about HW limitations Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-24 17:08 ` Guenter Roeck
2015-04-24 17:08 ` Guenter Roeck
2015-04-27 5:41 ` Timo Kokkonen
2015-04-27 5:41 ` Timo Kokkonen
2015-05-04 7:58 ` Uwe Kleine-König
2015-05-04 7:58 ` Uwe Kleine-König
2015-05-04 9:40 ` Timo Kokkonen
2015-05-04 9:40 ` Timo Kokkonen
2015-05-04 15:43 ` Guenter Roeck
2015-05-04 15:43 ` Guenter Roeck
2015-05-05 6:26 ` Timo Kokkonen
2015-05-05 6:26 ` Timo Kokkonen
2015-05-04 21:17 ` Marc Kleine-Budde
2015-05-04 21:17 ` Marc Kleine-Budde
2015-04-22 11:11 ` [PATCHv7 2/8] watchdog: Allow watchdog to reset device at early boot Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 3/8] devicetree: Document generic watchdog properties Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 4/8] Documentation/watchdog: watchdog-test.c: Add support for changing timeout Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 5/8] watchdog: at91sam9_wdt: Convert to use new watchdog core extensions Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 6/8] watchdog: imx2_wdt: Convert to use new " Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-05-05 8:11 ` Marc Kleine-Budde
2015-05-05 8:11 ` Marc Kleine-Budde
2015-05-05 8:31 ` Marc Kleine-Budde
2015-05-05 8:31 ` Marc Kleine-Budde
2015-05-05 9:07 ` Timo Kokkonen
2015-05-05 9:07 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 7/8] watchdog: omap_wdt: Fix memory leak on probe fail Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-04-26 15:32 ` Guenter Roeck
2015-04-26 15:32 ` Guenter Roeck
2015-04-27 5:50 ` Timo Kokkonen [this message]
2015-04-27 5:50 ` Timo Kokkonen
2015-04-22 11:11 ` [PATCHv7 8/8] watchdog: omap_wdt: Convert to use new core extensions Timo Kokkonen
2015-04-22 11:11 ` Timo Kokkonen
2015-05-03 18:56 ` Uwe Kleine-König
2015-05-03 18:56 ` Uwe Kleine-König
2015-05-04 5:59 ` Timo Kokkonen
2015-05-04 5:59 ` Timo Kokkonen
2015-05-04 7:04 ` Uwe Kleine-König
2015-05-04 7:04 ` Uwe Kleine-König
2015-05-04 10:06 ` Timo Kokkonen
2015-05-04 10:06 ` Timo Kokkonen
2015-05-07 6:42 ` Timo Kokkonen
2015-05-07 6:42 ` Timo Kokkonen
2015-05-07 7:30 ` Uwe Kleine-König
2015-05-07 7:30 ` Uwe Kleine-König
2015-05-07 7:39 ` Timo Kokkonen
2015-05-07 7:39 ` Timo Kokkonen
2015-05-04 16:08 ` Guenter Roeck
2015-05-04 16:08 ` Guenter Roeck
2015-05-05 13:50 ` [PATCHv7 0/8] watchdog: Extend kernel API and add early_timeout_sec feature Uwe Kleine-König
2015-05-05 13:50 ` Uwe Kleine-König
2015-05-06 7:26 ` Timo Kokkonen
2015-05-06 7:26 ` Timo Kokkonen
2015-05-06 7:48 ` Uwe Kleine-König
2015-05-06 7:48 ` Uwe Kleine-König
2015-05-06 8:23 ` Timo Kokkonen
2015-05-06 8:23 ` Timo Kokkonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553DCE0A.6010906@offcode.fi \
--to=timo.kokkonen@offcode.fi \
--cc=Wenyou.Yang@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.