* [PATCH] MIPS: Fix up obsolete cpu_set usage
@ 2015-04-28 21:34 ` Ezequiel Garcia
0 siblings, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2015-04-28 21:34 UTC (permalink / raw)
To: linux-mips, Ralf Baechle; +Cc: niklass, Ezequiel Garcia
cpu_set was removed (along with a bunch of cpumask helpers) by
commit 2f0f267ea072 ("cpumask: remove deprecated functions.").
Fix this by replacing cpu_set with cpumask_set_cpu. Without this
fix the following error is triggered when CONFIG_MIPS_MT_FPAFF=y.
arch/mips/kernel/smp-cps.c: In function 'cps_smp_setup':
arch/mips/kernel/smp-cps.c:95:3: error: implicit declaration of function 'cpu_set' [-Werror=implicit-function-declaration]
Fixes: 90db024f140d ("MIPS: smp-cps: cpu_set FPU mask if FPU present")
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
---
This is a fix for v4.1.
arch/mips/kernel/smp-cps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index 7e011f9..4251d39 100644
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -92,7 +92,7 @@ static void __init cps_smp_setup(void)
#ifdef CONFIG_MIPS_MT_FPAFF
/* If we have an FPU, enroll ourselves in the FPU-full mask */
if (cpu_has_fpu)
- cpu_set(0, mt_fpu_cpumask);
+ cpumask_set_cpu(0, &mt_fpu_cpumask);
#endif /* CONFIG_MIPS_MT_FPAFF */
}
--
2.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] MIPS: Fix up obsolete cpu_set usage
@ 2015-04-28 21:34 ` Ezequiel Garcia
0 siblings, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2015-04-28 21:34 UTC (permalink / raw)
To: linux-mips, Ralf Baechle; +Cc: niklass, Ezequiel Garcia
cpu_set was removed (along with a bunch of cpumask helpers) by
commit 2f0f267ea072 ("cpumask: remove deprecated functions.").
Fix this by replacing cpu_set with cpumask_set_cpu. Without this
fix the following error is triggered when CONFIG_MIPS_MT_FPAFF=y.
arch/mips/kernel/smp-cps.c: In function 'cps_smp_setup':
arch/mips/kernel/smp-cps.c:95:3: error: implicit declaration of function 'cpu_set' [-Werror=implicit-function-declaration]
Fixes: 90db024f140d ("MIPS: smp-cps: cpu_set FPU mask if FPU present")
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
---
This is a fix for v4.1.
arch/mips/kernel/smp-cps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index 7e011f9..4251d39 100644
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -92,7 +92,7 @@ static void __init cps_smp_setup(void)
#ifdef CONFIG_MIPS_MT_FPAFF
/* If we have an FPU, enroll ourselves in the FPU-full mask */
if (cpu_has_fpu)
- cpu_set(0, mt_fpu_cpumask);
+ cpumask_set_cpu(0, &mt_fpu_cpumask);
#endif /* CONFIG_MIPS_MT_FPAFF */
}
--
2.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Fix up obsolete cpu_set usage
2015-04-28 21:34 ` Ezequiel Garcia
(?)
@ 2015-04-29 9:38 ` Niklas Cassel
-1 siblings, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2015-04-29 9:38 UTC (permalink / raw)
To: Ezequiel Garcia, linux-mips, Ralf Baechle; +Cc: Niklas Cassel
On 04/28/2015 11:34 PM, Ezequiel Garcia wrote:
> cpu_set was removed (along with a bunch of cpumask helpers) by
> commit 2f0f267ea072 ("cpumask: remove deprecated functions.").
>
> Fix this by replacing cpu_set with cpumask_set_cpu. Without this
> fix the following error is triggered when CONFIG_MIPS_MT_FPAFF=y.
>
> arch/mips/kernel/smp-cps.c: In function 'cps_smp_setup':
> arch/mips/kernel/smp-cps.c:95:3: error: implicit declaration of function 'cpu_set' [-Werror=implicit-function-declaration]
>
> Fixes: 90db024f140d ("MIPS: smp-cps: cpu_set FPU mask if FPU present")
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Acked-by: Niklas Cassel <niklass@axis.com>
> ---
> This is a fix for v4.1.
>
> arch/mips/kernel/smp-cps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
> index 7e011f9..4251d39 100644
> --- a/arch/mips/kernel/smp-cps.c
> +++ b/arch/mips/kernel/smp-cps.c
> @@ -92,7 +92,7 @@ static void __init cps_smp_setup(void)
> #ifdef CONFIG_MIPS_MT_FPAFF
> /* If we have an FPU, enroll ourselves in the FPU-full mask */
> if (cpu_has_fpu)
> - cpu_set(0, mt_fpu_cpumask);
> + cpumask_set_cpu(0, &mt_fpu_cpumask);
> #endif /* CONFIG_MIPS_MT_FPAFF */
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-29 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-28 21:34 [PATCH] MIPS: Fix up obsolete cpu_set usage Ezequiel Garcia
2015-04-28 21:34 ` Ezequiel Garcia
2015-04-29 9:38 ` Niklas Cassel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.