From: Stephen Boyd <sboyd@codeaurora.org> To: Dong Aisheng <aisheng.dong@freescale.com>, linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mturquette@linaro.org, shawn.guo@linaro.org, b29396@freescale.com, linux-arm-kernel@lists.infradead.org, Ranjani.Vaidyanathan@freescale.com, b20596@freescale.com, r64343@freescale.com, b20788@freescale.com Subject: Re: [PATCH RFC v1 1/5] clk: change clk_core name of __clk_set_parent_after Date: Thu, 30 Apr 2015 12:06:13 -0700 [thread overview] Message-ID: <55427D25.3040904@codeaurora.org> (raw) In-Reply-To: <1429107999-24413-2-git-send-email-aisheng.dong@freescale.com> On 04/15/15 07:26, Dong Aisheng wrote: > To align with __clk_set_parent_before and some others functions, > change the host clk name to 'clk' instead of 'core'. > > Cc: Mike Turquette <mturquette@linaro.org> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Signed-off-by: Dong Aisheng <aisheng.dong@freescale.com> > --- No thanks. We should go and rename all clk_core pointers in this file from clk to core now that we're done splitting the two. I'll go do that now. > drivers/clk/clk.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 459ce9d..cc56ba2 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -1487,7 +1487,7 @@ static struct clk_core *__clk_set_parent_before(struct clk_core *clk, > return old_parent; > } > > -static void __clk_set_parent_after(struct clk_core *core, > +static void __clk_set_parent_after(struct clk_core *clk, > struct clk_core *parent, > struct clk_core *old_parent) > { > @@ -1495,8 +1495,8 @@ static void __clk_set_parent_after(struct clk_core *core, > * Finish the migration of prepare state and undo the changes done > * for preventing a race with clk_enable(). > */ > - if (core->prepare_count) { > - clk_core_disable(core); > + if (clk->prepare_count) { > + clk_core_disable(clk); > clk_core_disable(old_parent); > clk_core_unprepare(old_parent); > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC v1 1/5] clk: change clk_core name of __clk_set_parent_after Date: Thu, 30 Apr 2015 12:06:13 -0700 [thread overview] Message-ID: <55427D25.3040904@codeaurora.org> (raw) In-Reply-To: <1429107999-24413-2-git-send-email-aisheng.dong@freescale.com> On 04/15/15 07:26, Dong Aisheng wrote: > To align with __clk_set_parent_before and some others functions, > change the host clk name to 'clk' instead of 'core'. > > Cc: Mike Turquette <mturquette@linaro.org> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Signed-off-by: Dong Aisheng <aisheng.dong@freescale.com> > --- No thanks. We should go and rename all clk_core pointers in this file from clk to core now that we're done splitting the two. I'll go do that now. > drivers/clk/clk.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 459ce9d..cc56ba2 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -1487,7 +1487,7 @@ static struct clk_core *__clk_set_parent_before(struct clk_core *clk, > return old_parent; > } > > -static void __clk_set_parent_after(struct clk_core *core, > +static void __clk_set_parent_after(struct clk_core *clk, > struct clk_core *parent, > struct clk_core *old_parent) > { > @@ -1495,8 +1495,8 @@ static void __clk_set_parent_after(struct clk_core *core, > * Finish the migration of prepare state and undo the changes done > * for preventing a race with clk_enable(). > */ > - if (core->prepare_count) { > - clk_core_disable(core); > + if (clk->prepare_count) { > + clk_core_disable(clk); > clk_core_disable(old_parent); > clk_core_unprepare(old_parent); > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-04-30 19:06 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-15 14:26 [PATCH RFC v1 0/5] clk: support clocks which requires parent clock on during operation Dong Aisheng 2015-04-15 14:26 ` Dong Aisheng 2015-04-15 14:26 ` [PATCH RFC v1 1/5] clk: change clk_core name of __clk_set_parent_after Dong Aisheng 2015-04-15 14:26 ` Dong Aisheng 2015-04-30 19:06 ` Stephen Boyd [this message] 2015-04-30 19:06 ` Stephen Boyd 2015-05-04 8:15 ` Dong Aisheng 2015-05-04 8:15 ` Dong Aisheng 2015-04-15 14:26 ` [PATCH RFC v1 2/5] clk: add missing lock when call clk_core_enable in clk_set_parent Dong Aisheng 2015-04-15 14:26 ` Dong Aisheng 2015-04-30 19:07 ` Stephen Boyd 2015-04-30 19:07 ` Stephen Boyd 2015-05-04 8:35 ` Dong Aisheng 2015-05-04 8:35 ` Dong Aisheng 2015-05-07 0:01 ` Stephen Boyd 2015-05-07 0:01 ` Stephen Boyd 2015-05-13 9:21 ` Dong Aisheng 2015-05-13 9:21 ` Dong Aisheng 2015-04-15 14:26 ` [PATCH RFC v1 3/5] clk: remove unneeded __clk_enable and __clk_disable Dong Aisheng 2015-04-15 14:26 ` Dong Aisheng 2015-04-30 19:09 ` Stephen Boyd 2015-04-30 19:09 ` Stephen Boyd 2015-04-30 22:05 ` Stephen Boyd 2015-04-30 22:05 ` Stephen Boyd 2015-05-04 8:16 ` Dong Aisheng 2015-05-04 8:16 ` Dong Aisheng 2015-04-15 14:26 ` [PATCH RFC v1 4/5] clk: core: add CLK_SET_PARENT_ON flags to support clocks require parent on Dong Aisheng 2015-04-15 14:26 ` Dong Aisheng 2015-05-01 1:09 ` Stephen Boyd 2015-05-01 1:09 ` Stephen Boyd 2015-05-04 10:36 ` Dong Aisheng 2015-05-04 10:36 ` Dong Aisheng 2015-05-06 23:34 ` Stephen Boyd 2015-05-06 23:34 ` Stephen Boyd 2015-05-13 9:20 ` Dong Aisheng 2015-05-13 9:20 ` Dong Aisheng 2015-04-15 14:26 ` [PATCH RFC v1 5/5] clk: introduce clk_core_enable_lock and clk_core_disable_lock functions Dong Aisheng 2015-04-15 14:26 ` Dong Aisheng 2015-05-01 1:10 ` Stephen Boyd 2015-05-01 1:10 ` Stephen Boyd 2015-05-04 10:38 ` Dong Aisheng 2015-05-04 10:38 ` Dong Aisheng 2015-04-22 6:12 ` [PATCH RFC v1 0/5] clk: support clocks which requires parent clock on during operation Dong Aisheng 2015-04-22 6:12 ` Dong Aisheng 2015-04-30 2:37 ` Dong Aisheng 2015-04-30 2:37 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55427D25.3040904@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=Ranjani.Vaidyanathan@freescale.com \ --cc=aisheng.dong@freescale.com \ --cc=b20596@freescale.com \ --cc=b20788@freescale.com \ --cc=b29396@freescale.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=r64343@freescale.com \ --cc=shawn.guo@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.