From: "Jan Beulich" <JBeulich@suse.com>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: kevin.tian@intel.com, keir@xen.org, jinsong.liu@alibaba-inc.com,
xen-devel@lists.xen.org, andrew.cooper3@citrix.com,
yang.z.zhang@intel.com
Subject: Re: [PATCH 3/3] xen/iommu: disable IOMMU engine completely before enter S5
Date: Mon, 04 May 2015 10:00:34 +0100 [thread overview]
Message-ID: <554751520200007800076344@mail.emea.novell.com> (raw)
In-Reply-To: <1430705771-6744-3-git-send-email-tiejun.chen@intel.com>
>>> On 04.05.15 at 04:16, <tiejun.chen@intel.com> wrote:
> S5 menas we also shut down IOMMU engine as well, so we should
> disable IOMMU engine completely before enter S5, otherwise we
> still probably receive some interrupts in this period. But
> currently VT-D path depends on force_iommu and iommu_intremap
> to determine if we should disable translation and queued
> invalidation. So this unexpected behaviour can be fixed by
> clearing force_iommu and iommu_intremap.
Maybe it can, but is this the right way to do it? Fiddling with IOMMU
internal variables in xen/arch/x86/acpi/power.c seems bogus (not
to say hacky) at least. And why would this be S5-specific?
> Additionally, some cleanups to code comments.
Which has nothing to do in tis patch.
Jan
next prev parent reply other threads:[~2015-05-04 9:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 2:16 [PATCH 1/3] xen/vt-d: need barriers to workaround CLFLUSH Tiejun Chen
2015-05-04 2:16 ` [PATCH 2/3] xen/vt-d: mask interrupt message generation Tiejun Chen
2015-05-04 4:07 ` Zhang, Yang Z
2015-05-04 5:08 ` Chen, Tiejun
2015-05-04 6:41 ` Zhang, Yang Z
2015-05-04 8:57 ` Jan Beulich
2015-05-04 11:21 ` Chen, Tiejun
2015-05-04 2:16 ` [PATCH 3/3] xen/iommu: disable IOMMU engine completely before enter S5 Tiejun Chen
2015-05-04 9:00 ` Jan Beulich [this message]
2015-05-04 4:07 ` [PATCH 1/3] xen/vt-d: need barriers to workaround CLFLUSH Zhang, Yang Z
2015-05-04 8:52 ` Jan Beulich
2015-05-04 9:14 ` Andrew Cooper
2015-05-04 9:24 ` Jan Beulich
2015-05-05 1:13 ` Zhang, Yang Z
2015-05-05 15:46 ` Boris Ostrovsky
2015-05-05 15:58 ` Jan Beulich
2015-05-05 16:11 ` Boris Ostrovsky
2015-05-06 7:12 ` Jan Beulich
2015-05-06 7:26 ` Chen, Tiejun
2015-05-06 7:33 ` Jan Beulich
2015-05-06 15:11 ` Boris Ostrovsky
2015-05-06 7:09 ` Chen, Tiejun
2015-05-04 10:39 ` Chen, Tiejun
2015-05-04 10:43 ` Jan Beulich
2015-05-04 10:52 ` Tian, Kevin
2015-05-04 11:26 ` Chen, Tiejun
2015-05-05 1:13 ` Tian, Kevin
2015-05-05 2:45 ` Chen, Tiejun
2015-05-05 9:24 ` Jan Beulich
2015-05-06 6:47 ` Chen, Tiejun
2015-05-06 7:14 ` Jan Beulich
2015-05-04 15:22 ` Konrad Rzeszutek Wilk
2015-05-04 15:33 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554751520200007800076344@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=tiejun.chen@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.