All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Tom Tucker
	<tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	Hoang-Nam Nguyen
	<hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
	Christoph Raisch <raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
	Mike Marciniszyn
	<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Faisal Latif
	<faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Jack Morgenstein
	<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Tom Talpey <tom-CLs1Zie5N5HQT0dZR+AlfA@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Devesh Sharma
	<Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
	Liran Liss <liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Dave Goodell <dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers
Date: Tue, 5 May 2015 17:16:45 +0300	[thread overview]
Message-ID: <5548D0CD.3080400@mellanox.com> (raw)
In-Reply-To: <1430830240-32389-1-git-send-email-yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>

On 5/5/2015 3:50 PM, Michael Wang wrote:
> Since v7:
>    * Thanks to Doug, Ira, Devesh for the testing:-)
>    * Thanks for the comments from or, Doug, Ira, Jason:-)
>      Please remind me if anything missed:-P
>    * Use rdma_cap_XX() instead of cap_XX() for readability
>    * Remove CC list in git log for maintainability
>    * Use bool as return value
>    * Updated github repository to v8

Didn't you see that patches 15~23 will be squashed into one?


Also, when you post version N you need not only to list the changes 
since version N-1 but rather also to keep the full changes since Vx for 
x=1...N-2, reviewers needs not chase your previous cover letters and see 
if/whatwent wrong, specifically with a sensitive series like this one.

So if/when there's V9, use that practice, and for the time being, reply 
on the V8 cover letter with the full listing of changes

Or.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Michael Wang <yun.wang@profitbricks.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal@dev.mellanox.co.il>,
	Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Tom Tucker <tom@opengridcomputing.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Eli Cohen <eli@mellanox.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Haggai Eran <haggaie@mellanox.com>,
	Ira Weiny <ira.weiny@intel.com>, "Tom Talpey" <tom@talpey.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Devesh Sharma <Devesh.Sharma@Emulex.Com>,
	Liran Liss <liranl@mellanox.com>,
	Dave Goodell <dgoodell@cisco.com>
Subject: Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers
Date: Tue, 5 May 2015 17:16:45 +0300	[thread overview]
Message-ID: <5548D0CD.3080400@mellanox.com> (raw)
In-Reply-To: <1430830240-32389-1-git-send-email-yun.wang@profitbricks.com>

On 5/5/2015 3:50 PM, Michael Wang wrote:
> Since v7:
>    * Thanks to Doug, Ira, Devesh for the testing:-)
>    * Thanks for the comments from or, Doug, Ira, Jason:-)
>      Please remind me if anything missed:-P
>    * Use rdma_cap_XX() instead of cap_XX() for readability
>    * Remove CC list in git log for maintainability
>    * Use bool as return value
>    * Updated github repository to v8

Didn't you see that patches 15~23 will be squashed into one?


Also, when you post version N you need not only to list the changes 
since version N-1 but rather also to keep the full changes since Vx for 
x=1...N-2, reviewers needs not chase your previous cover letters and see 
if/whatwent wrong, specifically with a sensitive series like this one.

So if/when there's V9, use that practice, and for the time being, reply 
on the V8 cover letter with the full listing of changes

Or.



  parent reply	other threads:[~2015-05-05 14:16 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 12:50 [PATCH v8 00/23] IB/Verbs: IB Management Helpers Michael Wang
2015-05-05 12:50 ` Michael Wang
2015-05-05 12:50 ` [PATCH v8 01/23] IB/Verbs: Implement new callback query_protocol() Michael Wang
     [not found] ` <1430830240-32389-1-git-send-email-yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-05-05 12:50   ` [PATCH v8 02/23] IB/Verbs: Implement raw management helpers Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 04/23] IB/Verbs: Reform IB-core cm Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 05/23] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 06/23] IB/Verbs: Reform IB-core multicast Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 07/23] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 08/23] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 09/23] IB/Verbs: Reform IB-core verbs Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 11/23] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 13/23] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 14/23] IB/Verbs: Reform rest part in IB-core cma Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 16/23] IB/Verbs: Use management helper rdma_cap_ib_smi() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 17/23] IB/Verbs: Use management helper rdma_cap_ib_cm() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 18/23] IB/Verbs: Use management helper rdma_cap_iw_cm() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 19/23] IB/Verbs: Use management helper rdma_cap_ib_sa() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 21/23] IB/Verbs: Use management helper rdma_cap_read_multi_sge() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 22/23] IB/Verbs: Use management helper rdma_cap_af_ib() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 12:50   ` [PATCH v8 23/23] IB/Verbs: Use management helper rdma_cap_eth_ah() Michael Wang
2015-05-05 12:50     ` Michael Wang
2015-05-05 14:16   ` Or Gerlitz [this message]
2015-05-05 14:16     ` [PATCH v8 00/23] IB/Verbs: IB Management Helpers Or Gerlitz
2015-05-05 14:40     ` Michael Wang
2015-05-08 16:28       ` Devesh Sharma
2015-05-11 23:49   ` ira.weiny
2015-05-11 23:49     ` ira.weiny
     [not found]     ` <20150511234910.GA20027-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-12  0:27       ` Doug Ledford
2015-05-12  0:27         ` Doug Ledford
     [not found]         ` <1431390420.43876.4.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-12  7:57           ` Michael Wang
2015-05-12  7:57             ` Michael Wang
2015-05-12 14:24             ` Doug Ledford
     [not found]               ` <1431440667.43876.23.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-12 14:28                 ` Michael Wang
2015-05-12 14:28                   ` Michael Wang
2015-05-12 18:09           ` Jason Gunthorpe
2015-05-12 18:09             ` Jason Gunthorpe
     [not found]             ` <20150512180942.GC15891-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-12 20:09               ` Doug Ledford
2015-05-12 20:09                 ` Doug Ledford
     [not found]                 ` <1431461362.43876.81.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-13  7:44                   ` Michael Wang
2015-05-13  7:44                     ` Michael Wang
2015-05-12  8:04     ` Michael Wang
2015-05-05 12:50 ` [PATCH v8 12/23] IB/Verbs: Reform mcast related part in IB-core cma Michael Wang
2015-05-05 12:50 ` [PATCH v8 15/23] IB/Verbs: Use management helper rdma_cap_ib_mad() Michael Wang
2015-05-05 12:50 ` [PATCH v8 20/23] IB/Verbs: Use management helper rdma_cap_ib_mcast() Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5548D0CD.3080400@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
    --cc=dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    --cc=tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    --cc=tom-CLs1Zie5N5HQT0dZR+AlfA@public.gmane.org \
    --cc=yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.