All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Arnd Bergmann <arnd@arndb.de>, Suman Tripathi <stripathi@apm.com>
Cc: Rob Herring <robherring2@gmail.com>,
	"chris@printf.net" <chris@printf.net>,
	Anton Vorontsov <anton@enomsg.org>,
	Michal Simek <michal.simek@xilinx.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Don Dutile <ddutile@redhat.com>,
	"jcm@redhat.com" <jcm@redhat.com>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	"patches@apm.com" <patches@apm.com>
Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 6 May 2015 09:45:15 +0200	[thread overview]
Message-ID: <5549C68B.9090602@xilinx.com> (raw)
In-Reply-To: <4635229.bceBxngCoe@wuerfel>

On 05/06/2015 09:31 AM, Arnd Bergmann wrote:
> On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
>>>> @@ -533,6 +567,16 @@
>>>>                         interrupts = <0x0 0x4f 0x4>;
>>>>                 };
>>>>
>>>> +               sdhc0: sdhc@1c000000 {
>>>> +                       device_type = "sdhc";
>>>
>>> device_type generally should not be used (there are a few exceptions).
>>
>> Okay !!
>>
> 
> While we're at it, please change sdhc@1c000000 to mmc@1c000000.
> Even though Linux does not care, we try to use the standard device
> names for consistency.

Do we have a list of these names somewhere?
Normally I do use ePARP - generic names recommendation but mmc or sdhci
are not listed there.
Both combination mmc@ or sdhci@ are used in the kernel.

On zynq and zynqmp we do use shdci@.

Thanks,
Michal




WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Arnd Bergmann <arnd@arndb.de>, Suman Tripathi <stripathi@apm.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Mark Langsdorf <mlangsdo@redhat.com>,
	"jcm@redhat.com" <jcm@redhat.com>,
	Anton Vorontsov <anton@enomsg.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"chris@printf.net" <chris@printf.net>,
	Michal Simek <michal.simek@xilinx.com>,
	"patches@apm.com" <patches@apm.com>,
	Rob Herring <robherring2@gmail.com>,
	Don Dutile <ddutile@redhat.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 6 May 2015 09:45:15 +0200	[thread overview]
Message-ID: <5549C68B.9090602@xilinx.com> (raw)
In-Reply-To: <4635229.bceBxngCoe@wuerfel>

On 05/06/2015 09:31 AM, Arnd Bergmann wrote:
> On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
>>>> @@ -533,6 +567,16 @@
>>>>                         interrupts = <0x0 0x4f 0x4>;
>>>>                 };
>>>>
>>>> +               sdhc0: sdhc@1c000000 {
>>>> +                       device_type = "sdhc";
>>>
>>> device_type generally should not be used (there are a few exceptions).
>>
>> Okay !!
>>
> 
> While we're at it, please change sdhc@1c000000 to mmc@1c000000.
> Even though Linux does not care, we try to use the standard device
> names for consistency.

Do we have a list of these names somewhere?
Normally I do use ePARP - generic names recommendation but mmc or sdhci
are not listed there.
Both combination mmc@ or sdhci@ are used in the kernel.

On zynq and zynqmp we do use shdci@.

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
Date: Wed, 6 May 2015 09:45:15 +0200	[thread overview]
Message-ID: <5549C68B.9090602@xilinx.com> (raw)
In-Reply-To: <4635229.bceBxngCoe@wuerfel>

On 05/06/2015 09:31 AM, Arnd Bergmann wrote:
> On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
>>>> @@ -533,6 +567,16 @@
>>>>                         interrupts = <0x0 0x4f 0x4>;
>>>>                 };
>>>>
>>>> +               sdhc0: sdhc at 1c000000 {
>>>> +                       device_type = "sdhc";
>>>
>>> device_type generally should not be used (there are a few exceptions).
>>
>> Okay !!
>>
> 
> While we're at it, please change sdhc at 1c000000 to mmc at 1c000000.
> Even though Linux does not care, we try to use the standard device
> names for consistency.

Do we have a list of these names somewhere?
Normally I do use ePARP - generic names recommendation but mmc or sdhci
are not listed there.
Both combination mmc@ or sdhci@ are used in the kernel.

On zynq and zynqmp we do use shdci at .

Thanks,
Michal

  reply	other threads:[~2015-05-06  7:45 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05  9:17 [PATCH v5 0/1] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi
2015-05-05  9:17 ` Suman Tripathi
     [not found] ` <1430817426-5241-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2015-05-05  9:17   ` [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
2015-05-05  9:17     ` Suman Tripathi
2015-05-05 10:34     ` Ulf Hansson
2015-05-05 10:34       ` Ulf Hansson
2015-05-05 10:34       ` Ulf Hansson
2015-05-06  9:49       ` Ulf Hansson
2015-05-06  9:49         ` Ulf Hansson
2015-05-06  9:49         ` Ulf Hansson
2015-05-05 19:41     ` Rob Herring
2015-05-05 19:41       ` Rob Herring
2015-05-05 19:41       ` Rob Herring
2015-05-06  5:11       ` Suman Tripathi
2015-05-06  5:11         ` Suman Tripathi
2015-05-06  5:11         ` Suman Tripathi
2015-05-06  7:31         ` Arnd Bergmann
2015-05-06  7:31           ` Arnd Bergmann
2015-05-06  7:31           ` Arnd Bergmann
2015-05-06  7:45           ` Michal Simek [this message]
2015-05-06  7:45             ` Michal Simek
2015-05-06  7:45             ` Michal Simek
2015-05-06  8:40             ` Arnd Bergmann
2015-05-06  8:40               ` Arnd Bergmann
2015-05-06  8:40               ` Arnd Bergmann
2015-05-06 11:57               ` Suman Tripathi
2015-05-06 11:57                 ` Suman Tripathi
2015-05-06 12:01                 ` Suman Tripathi
2015-05-06 12:01                   ` Suman Tripathi
2015-05-06 12:41               ` Michal Simek
2015-05-06 12:41                 ` Michal Simek
2015-05-06 12:41                 ` Michal Simek
2015-05-06 12:47                 ` Suman Tripathi
2015-05-06 12:47                   ` Suman Tripathi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5549C68B.9090602@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=anton@enomsg.org \
    --cc=arnd@arndb.de \
    --cc=chris@printf.net \
    --cc=ddutile@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mlangsdo@redhat.com \
    --cc=patches@apm.com \
    --cc=robherring2@gmail.com \
    --cc=stripathi@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.