[PATCH] staging: comedi: coding style identation error fix

[PATCH] staging: comedi: coding style identation error fix

[Jaime Arrocha]

Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50

Signed-off-by: Jaime Arrocha <jarr@kerneldev.net>
---
 drivers/staging/comedi/drivers/das16m1.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das16m1.c b/drivers/staging/comedi/drivers/das16m1.c
index 1adf6a7..a18a887 100644
--- a/drivers/staging/comedi/drivers/das16m1.c
+++ b/drivers/staging/comedi/drivers/das16m1.c
@@ -46,8 +46,8 @@ list has 2 or more channels in it, then two conditions must be satisfied:
 (2) - the list must have an even number of entries.
 
 Options:
-        [0] - base io address
-        [1] - irq (optional, but you probably want it)
+	[0] - base io address
+	[1] - irq (optional, but you probably want it)
 
 irq can be omitted, although the cmd interface will not work without it.
 */
-- 
1.7.10.4

Re: [PATCH] staging: comedi: coding style identation error fix

[Sudip Mukherjee]

On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
> Errors found by checkpatch.pl.
> ERROR: code indent should use tabs where possible
> /drivers/staging/comedi/drivers/das16m1.c:49
> /drivers/staging/comedi/drivers/das16m1.c:50
> 
> Signed-off-by: Jaime Arrocha <jarr@kerneldev.net>
> ---
you are sending this patch second time with different subject.
any reason for that?

regards
sudip

Re: [PATCH] staging: comedi: coding style identation error fix

[Jaime Arrocha]

On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
> On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
>> Errors found by checkpatch.pl.
>> ERROR: code indent should use tabs where possible
>> /drivers/staging/comedi/drivers/das16m1.c:49
>> /drivers/staging/comedi/drivers/das16m1.c:50
>>
>> Signed-off-by: Jaime Arrocha <jarr@kerneldev.net>
>> ---
> you are sending this patch second time with different subject.
> any reason for that?
>
> regards
> sudip
>

Yes, the first one had the subject line too long and not clear.
When I need to resend a patch like I did, should I add on the second one 
the reason behind resending and dismissing the first one? Thank you.

Re: [PATCH] staging: comedi: coding style identation error fix

[Sudip Mukherjee]

On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
> 
> 
> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
> >On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
> >>Errors found by checkpatch.pl.
> >>ERROR: code indent should use tabs where possible
> >>/drivers/staging/comedi/drivers/das16m1.c:49
> >>/drivers/staging/comedi/drivers/das16m1.c:50
> >>
> >>Signed-off-by: Jaime Arrocha <jarr@kerneldev.net>
> >>---
> >you are sending this patch second time with different subject.
> >any reason for that?
> >
> >regards
> >sudip
> >
> 
> Yes, the first one had the subject line too long and not clear.
> When I need to resend a patch like I did, should I add on the second
> one the reason behind resending and dismissing the first one? Thank
> you.

first of all you should reply to the first patch stating that should not
be applied and that you have sent a second patch. And this one should
have had a v2 in the subject with the reason of v2 below the --- cutoff.
since you have already sent the second patch just reply to the fist
patch as of now.
And you have sent the patches to greg@kroah.com, it should have been
gregkh@linuxfoundation.org . always use get_maintainer.pl to see whom
to send patches.

regards
sudip
 

Re: [PATCH] staging: comedi: coding style identation error fix

[Jaime Arrocha]

On 05/07/2015 08:21 AM, Sudip Mukherjee wrote:
> On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
>>
>>
>> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
>>> On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
>>>> Errors found by checkpatch.pl.
>>>> ERROR: code indent should use tabs where possible
>>>> /drivers/staging/comedi/drivers/das16m1.c:49
>>>> /drivers/staging/comedi/drivers/das16m1.c:50
>>>>
>>>> Signed-off-by: Jaime Arrocha <jarr@kerneldev.net>
>>>> ---
>>> you are sending this patch second time with different subject.
>>> any reason for that?
>>>
>>> regards
>>> sudip
>>>
>>
>> Yes, the first one had the subject line too long and not clear.
>> When I need to resend a patch like I did, should I add on the second
>> one the reason behind resending and dismissing the first one? Thank
>> you.
>
> first of all you should reply to the first patch stating that should not
> be applied and that you have sent a second patch. And this one should
> have had a v2 in the subject with the reason of v2 below the --- cutoff.
> since you have already sent the second patch just reply to the fist
> patch as of now.
> And you have sent the patches to greg@kroah.com, it should have been
> gregkh@linuxfoundation.org . always use get_maintainer.pl to see whom
> to send patches.
>
> regards
> sudip
>
>

Thanks Sudip, I will dismiss this one too and do it correctly. I 
accidentally took Greg's email from the TODO file.




This patch should not be applied.



Thanks,
jaime