All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lu, Baolu" <baolu.lu@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume
Date: Fri, 08 May 2015 15:55:11 +0800	[thread overview]
Message-ID: <554C6BDF.7050307@linux.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1505061031450.1094-100000@iolanthe.rowland.org>



On 05/06/2015 10:35 PM, Alan Stern wrote:
>> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
>> >index 68b1e83..621d9b7 100644
>> >--- a/include/linux/usb/hcd.h
>> >+++ b/include/linux/usb/hcd.h
>> >@@ -383,7 +383,13 @@ struct hc_driver {
>> >  	int	(*find_raw_port_number)(struct usb_hcd *, int);
>> >  	/* Call for power on/off the port if necessary */
>> >  	int	(*port_power)(struct usb_hcd *hcd, int portnum, bool enable);
>> >-
>> >+	/* Call back to hcd when a USB device is going to suspend or just
>> >+	 * resumed.
>> >+	 */
>> >+	void	(*device_suspend)(struct usb_hcd *, struct usb_device *udev,
>> >+			pm_message_t msg);
>> >+	void	(*device_resume)(struct usb_hcd *, struct usb_device *udev,
>> >+			pm_message_t msg);
>> >  };
> Your callbacks don't use the msg argument.  What makes you think it is
> needed?

'msg' arguments are not used in this patch series. I will remove them.

>
> Alan Stern

Thank you,
Baolu

  parent reply	other threads:[~2015-05-08  7:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  7:39 [PATCH v2 0/3] usb: notify hcd when USB device suspend or resume Lu Baolu
2015-05-06  7:40 ` [PATCH v2 1/3] " Lu Baolu
2015-05-06 14:35   ` Alan Stern
2015-05-07  0:27     ` Lu, Baolu
2015-05-07 14:34       ` Alan Stern
2015-05-08  1:14         ` Lu, Baolu
2015-05-08 14:21           ` Alan Stern
2015-05-09  0:42             ` Lu, Baolu
2015-05-11 14:25               ` Alan Stern
2015-05-12  2:05                 ` Lu, Baolu
2015-05-12 15:54                   ` Alan Stern
2015-05-13  2:36                     ` Lu, Baolu
2015-05-13 14:14                       ` Alan Stern
2015-05-08  7:55     ` Lu, Baolu [this message]
2015-05-06  7:40 ` [PATCH v2 2/3] usb: xhci: implement device_suspend/device_resume entries Lu Baolu
2015-05-06 14:30   ` Alan Stern
2015-05-07  0:30     ` Lu, Baolu
2015-05-06  7:40 ` [PATCH v2 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554C6BDF.7050307@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.