* [meta-fsl-arm-extra][PATCH v3] riotboard: Fix broken image builds against linux-fslc @ 2015-04-30 15:49 Nikolay Dimitrov 2015-04-30 15:49 ` [meta-fsl-demos][PATCH] " Nikolay Dimitrov 2015-05-11 16:42 ` [meta-fsl-arm-extra][PATCH v3] " Nikolay Dimitrov 0 siblings, 2 replies; 16+ messages in thread From: Nikolay Dimitrov @ 2015-04-30 15:49 UTC (permalink / raw) To: meta-freescale Several Yocto images fail to build because they're using packages that require imx6-specific hardware support (ASRC, VPU, GPU3D), which is not available in the mainline kernel. This patch fixes the following image builds: - core-image-minimal - core-image-base - fsl-image-multimedia - fsl-image-multimedia-full - fsl-image-machine-test Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg> --- conf/machine/imx6dl-riotboard.conf | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/conf/machine/imx6dl-riotboard.conf b/conf/machine/imx6dl-riotboard.conf index b611ffb..bf50eaf 100644 --- a/conf/machine/imx6dl-riotboard.conf +++ b/conf/machine/imx6dl-riotboard.conf @@ -15,3 +15,8 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-fslc" KERNEL_DEVICETREE = "imx6dl-riotboard.dtb" SERIAL_CONSOLE = "115200 ttymxc1" + +# FIXME: Workaround for building against linux-fslc +MACHINE_EXTRA_RRECOMMENDS_remove = "fsl-alsa-plugins" +PREFERRED_VERSION_imx-test = "00.00.00" +MACHINE_GSTREAMER_PLUGIN = "" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-04-30 15:49 [meta-fsl-arm-extra][PATCH v3] riotboard: Fix broken image builds against linux-fslc Nikolay Dimitrov @ 2015-04-30 15:49 ` Nikolay Dimitrov 2015-05-04 12:41 ` Fabio Estevam 2015-05-11 16:43 ` Nikolay Dimitrov 2015-05-11 16:42 ` [meta-fsl-arm-extra][PATCH v3] " Nikolay Dimitrov 1 sibling, 2 replies; 16+ messages in thread From: Nikolay Dimitrov @ 2015-04-30 15:49 UTC (permalink / raw) To: meta-freescale Several Yocto images fail to build because they're using packages that require imx6-specific hardware support (GPU3D), which is not available in the mainline kernel. This patch fixes the following image builds: - fsl-image-multimedia - fsl-image-multimedia-full - fsl-image-machine-test Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg> --- recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb index 25b26f6..97aab66 100644 --- a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb +++ b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb @@ -25,3 +25,6 @@ RDEPENDS_${PN} = " \ # FIXME: i.MX6SL cannot use mesa for Graphics and it lacks 3D support, # so skip it for now. RDEPENDS_${PN}_remove_mx6sl = "gst-plugins-gl" + +# FIXME: Workaround for building against linux-fslc +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-04-30 15:49 ` [meta-fsl-demos][PATCH] " Nikolay Dimitrov @ 2015-05-04 12:41 ` Fabio Estevam 2015-05-04 13:33 ` Nikolay Dimitrov 2015-05-11 16:43 ` Nikolay Dimitrov 1 sibling, 1 reply; 16+ messages in thread From: Fabio Estevam @ 2015-05-04 12:41 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: meta-freescale Hi Nikolay, On Thu, Apr 30, 2015 at 12:49 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > +# FIXME: Workaround for building against linux-fslc > +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" This doesn't seem to scale very well as we would need to put every mx6q/dl board that uses linux-fslc in this list. Regards, Fabio Estevam ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-04 12:41 ` Fabio Estevam @ 2015-05-04 13:33 ` Nikolay Dimitrov 2015-05-04 17:06 ` Daiane Angolini 0 siblings, 1 reply; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-04 13:33 UTC (permalink / raw) To: Fabio Estevam; +Cc: meta-freescale Hi Fabio, On 05/04/2015 03:41 PM, Fabio Estevam wrote: > Hi Nikolay, > > On Thu, Apr 30, 2015 at 12:49 PM, Nikolay Dimitrov > <picmaster@mail.bg> wrote: > >> +# FIXME: Workaround for building against linux-fslc >> +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" > > This doesn't seem to scale very well as we would need to put every > mx6q/dl board that uses linux-fslc in this list. > > Regards, > > Fabio Estevam I completely understand and agree, but I don't feel qualified to force all other mx6 maintainers to use the same approach. If others decide to go this way, we can then use the "_remove" clause for all "mx6" SOCs, and put appropriate comment in the file. But as of today, I don't see such push. Considering the amount of discussion my patches provoke, I'm now more inclined to propose micro-changes that are more obvious/easier to approve and move forward. Kind regards, Nikolay ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-04 13:33 ` Nikolay Dimitrov @ 2015-05-04 17:06 ` Daiane Angolini 2015-05-04 17:12 ` Gary Thomas 2015-05-04 19:38 ` Nikolay Dimitrov 0 siblings, 2 replies; 16+ messages in thread From: Daiane Angolini @ 2015-05-04 17:06 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: meta-freescale On Mon, May 4, 2015 at 10:33 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > Hi Fabio, > > On 05/04/2015 03:41 PM, Fabio Estevam wrote: >> >> Hi Nikolay, >> >> On Thu, Apr 30, 2015 at 12:49 PM, Nikolay Dimitrov >> <picmaster@mail.bg> wrote: >> >>> +# FIXME: Workaround for building against linux-fslc >>> +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" >> >> >> This doesn't seem to scale very well as we would need to put every >> mx6q/dl board that uses linux-fslc in this list. >> >> Regards, >> >> Fabio Estevam > > > I completely understand and agree, but I don't feel qualified to force > all other mx6 maintainers to use the same approach. If others decide to > go this way, we can then use the "_remove" clause for all "mx6" SOCs, > and put appropriate comment in the file. But as of today, I don't see > such push. gst-plugins-gl is included in the image by: https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb#L21 right? So, remove opengl from your DISTRO_FEATURES and it should work. However, we have already this line: https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb#L27 Which means mx6sl cannot handle gst-plugins-gl. Riot is not mx6sl, so maybe you have spoted another corner case. > > Considering the amount of discussion my patches provoke, I'm now more > inclined to propose micro-changes that are more obvious/easier to > approve and move forward. Please, keep the discussion up and running. Please, keep the questions and the patches, we really need more experienced board maintainers for the community boards. Daiane > > Kind regards, > Nikolay > > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-04 17:06 ` Daiane Angolini @ 2015-05-04 17:12 ` Gary Thomas 2015-05-04 19:38 ` Nikolay Dimitrov 1 sibling, 0 replies; 16+ messages in thread From: Gary Thomas @ 2015-05-04 17:12 UTC (permalink / raw) To: meta-freescale On 2015-05-04 11:06, Daiane Angolini wrote: > On Mon, May 4, 2015 at 10:33 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote: >> Hi Fabio, >> >> On 05/04/2015 03:41 PM, Fabio Estevam wrote: >>> >>> Hi Nikolay, >>> >>> On Thu, Apr 30, 2015 at 12:49 PM, Nikolay Dimitrov >>> <picmaster@mail.bg> wrote: >>> >>>> +# FIXME: Workaround for building against linux-fslc >>>> +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" >>> >>> >>> This doesn't seem to scale very well as we would need to put every >>> mx6q/dl board that uses linux-fslc in this list. >>> >>> Regards, >>> >>> Fabio Estevam >> >> >> I completely understand and agree, but I don't feel qualified to force >> all other mx6 maintainers to use the same approach. If others decide to >> go this way, we can then use the "_remove" clause for all "mx6" SOCs, >> and put appropriate comment in the file. But as of today, I don't see >> such push. > > gst-plugins-gl is included in the image by: > https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb#L21 > > right? > > So, remove opengl from your DISTRO_FEATURES and it should work. > > > However, we have already this line: > > https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb#L27 > > Which means mx6sl cannot handle gst-plugins-gl. Riot is not mx6sl, so > maybe you have spoted another corner case. These problems are not a new corner case; rather just that the RIoTboard is not using the FSL kernel and hence does not have the GPU support required for building the packages that rely on it [the GPU support] > >> >> Considering the amount of discussion my patches provoke, I'm now more >> inclined to propose micro-changes that are more obvious/easier to >> approve and move forward. > > Please, keep the discussion up and running. Please, keep the questions > and the patches, we really need more experienced board maintainers for > the community boards. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-04 17:06 ` Daiane Angolini 2015-05-04 17:12 ` Gary Thomas @ 2015-05-04 19:38 ` Nikolay Dimitrov 1 sibling, 0 replies; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-04 19:38 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale Hi Daiane, On 05/04/2015 08:06 PM, Daiane Angolini wrote: > On Mon, May 4, 2015 at 10:33 AM, Nikolay Dimitrov <picmaster@mail.bg> > wrote: >> Hi Fabio, >> >> On 05/04/2015 03:41 PM, Fabio Estevam wrote: >>> >>> Hi Nikolay, >>> >>> On Thu, Apr 30, 2015 at 12:49 PM, Nikolay Dimitrov >>> <picmaster@mail.bg> wrote: >>> >>>> +# FIXME: Workaround for building against linux-fslc >>>> +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" >>> >>> >>> This doesn't seem to scale very well as we would need to put >>> every mx6q/dl board that uses linux-fslc in this list. >>> >>> Regards, >>> >>> Fabio Estevam >> >> >> I completely understand and agree, but I don't feel qualified to >> force all other mx6 maintainers to use the same approach. If others >> decide to go this way, we can then use the "_remove" clause for all >> "mx6" SOCs, and put appropriate comment in the file. But as of >> today, I don't see such push. > > gst-plugins-gl is included in the image by: > https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb#L21 > > right? > > So, remove opengl from your DISTRO_FEATURES and it should work. > > > However, we have already this line: > > https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb#L27 > > Which means mx6sl cannot handle gst-plugins-gl. Riot is not mx6sl, > so maybe you have spoted another corner case. Thanks for your comments. I've already sent an email with same analysis just before sending the patch, which uses the described above method. >> Considering the amount of discussion my patches provoke, I'm now >> more inclined to propose micro-changes that are more obvious/easier >> to approve and move forward. > > Please, keep the discussion up and running. Please, keep the > questions and the patches, we really need more experienced board > maintainers for the community boards. Regards, Nikolay ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-04-30 15:49 ` [meta-fsl-demos][PATCH] " Nikolay Dimitrov 2015-05-04 12:41 ` Fabio Estevam @ 2015-05-11 16:43 ` Nikolay Dimitrov 2015-05-11 17:09 ` Otavio Salvador 1 sibling, 1 reply; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-11 16:43 UTC (permalink / raw) To: Otavio Salvador, Fabio Estevam; +Cc: meta-freescale Ping. On 04/30/2015 06:49 PM, Nikolay Dimitrov wrote: > Several Yocto images fail to build because they're using packages that require > imx6-specific hardware support (GPU3D), which is not available in the mainline > kernel. This patch fixes the following image builds: > - fsl-image-multimedia > - fsl-image-multimedia-full > - fsl-image-machine-test > > Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg> > --- > recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb > index 25b26f6..97aab66 100644 > --- a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb > +++ b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer-full.bb > @@ -25,3 +25,6 @@ RDEPENDS_${PN} = " \ > # FIXME: i.MX6SL cannot use mesa for Graphics and it lacks 3D support, > # so skip it for now. > RDEPENDS_${PN}_remove_mx6sl = "gst-plugins-gl" > + > +# FIXME: Workaround for building against linux-fslc > +RDEPENDS_${PN}_remove_imx6dl-riotboard = "gst-plugins-gl" > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-11 16:43 ` Nikolay Dimitrov @ 2015-05-11 17:09 ` Otavio Salvador 2015-05-11 17:24 ` Nikolay Dimitrov 0 siblings, 1 reply; 16+ messages in thread From: Otavio Salvador @ 2015-05-11 17:09 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: meta-freescale On Mon, May 11, 2015 at 1:43 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > Ping. I am building it here for testing. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-11 17:09 ` Otavio Salvador @ 2015-05-11 17:24 ` Nikolay Dimitrov 2015-05-11 17:46 ` Otavio Salvador 0 siblings, 1 reply; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-11 17:24 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale Hi Otavio, On 05/11/2015 08:09 PM, Otavio Salvador wrote: > On Mon, May 11, 2015 at 1:43 PM, Nikolay Dimitrov <picmaster@mail.bg> > wrote: >> Ping. > > I am building it here for testing. That's great, thanks for looking into it. Regards, Nikolay ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-11 17:24 ` Nikolay Dimitrov @ 2015-05-11 17:46 ` Otavio Salvador 2015-05-11 23:42 ` Nikolay Dimitrov 0 siblings, 1 reply; 16+ messages in thread From: Otavio Salvador @ 2015-05-11 17:46 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: meta-freescale On Mon, May 11, 2015 at 2:24 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > Hi Otavio, > > On 05/11/2015 08:09 PM, Otavio Salvador wrote: >> >> On Mon, May 11, 2015 at 1:43 PM, Nikolay Dimitrov <picmaster@mail.bg> >> wrote: >>> >>> Ping. >> >> >> I am building it here for testing. > > > That's great, thanks for looking into it. Your patch can get a change: diff --git a/conf/machine/imx6dl-riotboard.conf b/conf/machine/imx6dl-riotboard.conf index bf50eaf..260deed 100644 --- a/conf/machine/imx6dl-riotboard.conf +++ b/conf/machine/imx6dl-riotboard.conf @@ -19,4 +19,4 @@ SERIAL_CONSOLE = "115200 ttymxc1" # FIXME: Workaround for building against linux-fslc MACHINE_EXTRA_RRECOMMENDS_remove = "fsl-alsa-plugins" PREFERRED_VERSION_imx-test = "00.00.00" -MACHINE_GSTREAMER_PLUGIN = "" +MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard = "" This makes the patch in meta-fsl-demos not needed and seems cleaner. Can you take a look and confirm? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-11 17:46 ` Otavio Salvador @ 2015-05-11 23:42 ` Nikolay Dimitrov 2015-05-12 12:41 ` Otavio Salvador 0 siblings, 1 reply; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-11 23:42 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale Hi Otavio, On 05/11/2015 08:46 PM, Otavio Salvador wrote: > On Mon, May 11, 2015 at 2:24 PM, Nikolay Dimitrov <picmaster@mail.bg> > wrote: >> Hi Otavio, >> >> On 05/11/2015 08:09 PM, Otavio Salvador wrote: >>> >>> On Mon, May 11, 2015 at 1:43 PM, Nikolay Dimitrov >>> <picmaster@mail.bg> wrote: >>>> >>>> Ping. >>> >>> >>> I am building it here for testing. >> >> >> That's great, thanks for looking into it. > > Your patch can get a change: > > diff --git a/conf/machine/imx6dl-riotboard.conf > b/conf/machine/imx6dl-riotboard.conf index bf50eaf..260deed 100644 > --- a/conf/machine/imx6dl-riotboard.conf +++ > b/conf/machine/imx6dl-riotboard.conf @@ -19,4 +19,4 @@ SERIAL_CONSOLE > = "115200 ttymxc1" # FIXME: Workaround for building against > linux-fslc MACHINE_EXTRA_RRECOMMENDS_remove = "fsl-alsa-plugins" > PREFERRED_VERSION_imx-test = "00.00.00" -MACHINE_GSTREAMER_PLUGIN = > "" +MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard = "" > > This makes the patch in meta-fsl-demos not needed and seems cleaner. > > Can you take a look and confirm? This code sits in riotboard-specific conf file, so there's no difference between MACHINE_GSTREAMER_PLUGIN and MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard variables. The machine suffix is redundant in the 2nd case. But even if I use the proposed MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard, the fsl-image-multimedia-full image build still fails. Regarding the meta-fsl-demos patch - the need for this fix is because the packagegroup-fsl-gstreamer-full.bb is again adding the gst-plugins-gl dependency, disregarding the available capabilities (either hardware or kernel). So, my motivation for doing it this way for short term is the following: 1. I still have single kernel to maintain (fslc) as of today. 2. The board builds are broken at least since 23.April and I have to do something about it. FYI, for a long-term solution I plan to do the following, if you agree: - Support building multiple kernels, including both FSL and FSLC - Somehow declare the capabilities of the hardware/kernel and take it into account by in recipes. We need something like KERNEL_FEATURES and MACHINE_FEATURES, and only if a feature is declared by both variables, then it should be used (not sure whether this is the same as the COMBINED_FEATURES mechanism). I'm looking towards your ideas here, as you guys have much more Yocto experience than me. To summarize: my patch set is not perfect, but as of today we don't have all the ingredients to make it perfect. Tomorrow we could have these ingredients, but I can't see how far is this tomorrow. Regards, Nikolay ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-11 23:42 ` Nikolay Dimitrov @ 2015-05-12 12:41 ` Otavio Salvador 2015-05-13 4:09 ` Nikolay Dimitrov 0 siblings, 1 reply; 16+ messages in thread From: Otavio Salvador @ 2015-05-12 12:41 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: meta-freescale On Mon, May 11, 2015 at 8:42 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > On 05/11/2015 08:46 PM, Otavio Salvador wrote: >> On Mon, May 11, 2015 at 2:24 PM, Nikolay Dimitrov <picmaster@mail.bg> >> wrote: >>> >>> Hi Otavio, >>> >>> On 05/11/2015 08:09 PM, Otavio Salvador wrote: >>>> >>>> >>>> On Mon, May 11, 2015 at 1:43 PM, Nikolay Dimitrov >>>> <picmaster@mail.bg> wrote: >>>>> >>>>> >>>>> Ping. >>>> >>>> >>>> >>>> I am building it here for testing. >>> >>> >>> >>> That's great, thanks for looking into it. >> >> >> Your patch can get a change: >> >> diff --git a/conf/machine/imx6dl-riotboard.conf >> b/conf/machine/imx6dl-riotboard.conf index bf50eaf..260deed 100644 >> --- a/conf/machine/imx6dl-riotboard.conf +++ >> b/conf/machine/imx6dl-riotboard.conf @@ -19,4 +19,4 @@ SERIAL_CONSOLE >> = "115200 ttymxc1" # FIXME: Workaround for building against >> linux-fslc MACHINE_EXTRA_RRECOMMENDS_remove = "fsl-alsa-plugins" >> PREFERRED_VERSION_imx-test = "00.00.00" -MACHINE_GSTREAMER_PLUGIN = >> "" +MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard = "" >> >> This makes the patch in meta-fsl-demos not needed and seems cleaner. >> >> Can you take a look and confirm? > > > This code sits in riotboard-specific conf file, so there's no difference > between MACHINE_GSTREAMER_PLUGIN and > MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard variables. The machine suffix > is redundant in the 2nd case. But even if I use the proposed > MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard, the fsl-image-multimedia-full > image build still fails. I reproduced it here. It fails only with X11 and my test was using Framebuffer. I have sent a patch for review. > Regarding the meta-fsl-demos patch - the need for this fix is because > the packagegroup-fsl-gstreamer-full.bb is again adding the > gst-plugins-gl dependency, disregarding the available capabilities > (either hardware or kernel). See above. > So, my motivation for doing it this way for short term is the following: > 1. I still have single kernel to maintain (fslc) as of today. > 2. The board builds are broken at least since 23.April and I have to do > something about it. > > FYI, for a long-term solution I plan to do the following, if you agree: > - Support building multiple kernels, including both FSL and FSLC > - Somehow declare the capabilities of the hardware/kernel and take it > into account by in recipes. We need something like KERNEL_FEATURES and > MACHINE_FEATURES, and only if a feature is declared by both variables, > then it should be used (not sure whether this is the same as the > COMBINED_FEATURES mechanism). I'm looking towards your ideas here, as > you guys have much more Yocto experience than me. > > To summarize: my patch set is not perfect, but as of today we don't > have all the ingredients to make it perfect. Tomorrow we could have > these ingredients, but I can't see how far is this tomorrow. The biggest challenge here is how to express KERNEL_FEATURES which are recipe/provider specific. We have some providers: linux-fslc linux-imx linux-<vendor> and each can provide different kernel features. I agree with the long term plan but I didn't yet came up with something which scales and work. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-12 12:41 ` Otavio Salvador @ 2015-05-13 4:09 ` Nikolay Dimitrov 2015-05-13 11:06 ` Otavio Salvador 0 siblings, 1 reply; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-13 4:09 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale Hi Otavio, On 05/12/2015 03:41 PM, Otavio Salvador wrote: > On Mon, May 11, 2015 at 8:42 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote: >> On 05/11/2015 08:46 PM, Otavio Salvador wrote: >>> On Mon, May 11, 2015 at 2:24 PM, Nikolay Dimitrov <picmaster@mail.bg> >>> wrote: >>>> >>>> Hi Otavio, >>>> >>>> On 05/11/2015 08:09 PM, Otavio Salvador wrote: >>>>> >>>>> >>>>> On Mon, May 11, 2015 at 1:43 PM, Nikolay Dimitrov >>>>> <picmaster@mail.bg> wrote: >>>>>> >>>>>> >>>>>> Ping. >>>>> >>>>> >>>>> >>>>> I am building it here for testing. >>>> >>>> >>>> >>>> That's great, thanks for looking into it. >>> >>> >>> Your patch can get a change: >>> >>> diff --git a/conf/machine/imx6dl-riotboard.conf >>> b/conf/machine/imx6dl-riotboard.conf index bf50eaf..260deed 100644 >>> --- a/conf/machine/imx6dl-riotboard.conf +++ >>> b/conf/machine/imx6dl-riotboard.conf @@ -19,4 +19,4 @@ SERIAL_CONSOLE >>> = "115200 ttymxc1" # FIXME: Workaround for building against >>> linux-fslc MACHINE_EXTRA_RRECOMMENDS_remove = "fsl-alsa-plugins" >>> PREFERRED_VERSION_imx-test = "00.00.00" -MACHINE_GSTREAMER_PLUGIN = >>> "" +MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard = "" >>> >>> This makes the patch in meta-fsl-demos not needed and seems cleaner. >>> >>> Can you take a look and confirm? >> >> >> This code sits in riotboard-specific conf file, so there's no difference >> between MACHINE_GSTREAMER_PLUGIN and >> MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard variables. The machine suffix >> is redundant in the 2nd case. But even if I use the proposed >> MACHINE_GSTREAMER_PLUGIN_imx6dl-riotboard, the fsl-image-multimedia-full >> image build still fails. > > I reproduced it here. It fails only with X11 and my test was using > Framebuffer. I have sent a patch for review. The patch looks ok to me. I suppose that after this fix, the RDEPENDS hack for imx6sl is not needed anymore? >> Regarding the meta-fsl-demos patch - the need for this fix is because >> the packagegroup-fsl-gstreamer-full.bb is again adding the >> gst-plugins-gl dependency, disregarding the available capabilities >> (either hardware or kernel). > > See above. > >> So, my motivation for doing it this way for short term is the following: >> 1. I still have single kernel to maintain (fslc) as of today. >> 2. The board builds are broken at least since 23.April and I have to do >> something about it. >> >> FYI, for a long-term solution I plan to do the following, if you agree: >> - Support building multiple kernels, including both FSL and FSLC >> - Somehow declare the capabilities of the hardware/kernel and take it >> into account by in recipes. We need something like KERNEL_FEATURES and >> MACHINE_FEATURES, and only if a feature is declared by both variables, >> then it should be used (not sure whether this is the same as the >> COMBINED_FEATURES mechanism). I'm looking towards your ideas here, as >> you guys have much more Yocto experience than me. >> >> To summarize: my patch set is not perfect, but as of today we don't >> have all the ingredients to make it perfect. Tomorrow we could have >> these ingredients, but I can't see how far is this tomorrow. > > The biggest challenge here is how to express KERNEL_FEATURES which are > recipe/provider specific. > > We have some providers: > > linux-fslc > linux-imx > linux-<vendor> > > and each can provide different kernel features. I agree with the long > term plan but I didn't yet came up with something which scales and > work. I'll reiterate my thoughts - it's not only the kernel features. All the parts in the system need to consider a feature, before it's built: - hardware - kernel - userspace A feature shouldn't be compiled and/or deployed in the image unless all the system parts confirm its support, otherwise we'll have a failed build or runtime issues. With my current limited knowledge I see 2 basic paths for implementing this: - 1 shared variable per feature, which is mangled across the recipes/layers (the usual enable/disable dance); - mechanism similar to COMBINED_FEATURES, which needs to "AND" 2 or more sets of variables across the system. This is already done implicitly in lots of places with heavy usage of $base_contains, but it's not easy to read and explicit. // board.conf MACHINE_FEATURES += "opengl" // kernel provider KERNEL_FEATURES += "opengl" // image or recipe should check features indirectly XXXXXXX_append = "${base_contains('COMBINED_FEATURES', 'opengl', 'gst-plugins-gl', '', d)} Something like this... Regards, Nikolay ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-demos][PATCH] riotboard: Fix broken image builds against linux-fslc 2015-05-13 4:09 ` Nikolay Dimitrov @ 2015-05-13 11:06 ` Otavio Salvador 0 siblings, 0 replies; 16+ messages in thread From: Otavio Salvador @ 2015-05-13 11:06 UTC (permalink / raw) To: Nikolay Dimitrov; +Cc: meta-freescale On Wed, May 13, 2015 at 1:09 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote: > On 05/12/2015 03:41 PM, Otavio Salvador wrote: >> I reproduced it here. It fails only with X11 and my test was using >> Framebuffer. I have sent a patch for review. > > The patch looks ok to me. I suppose that after this fix, the RDEPENDS > hack for imx6sl is not needed anymore? It is as imx6sl does not provide the headers[1] and gst-plugins-gl fail to build. 1. http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/recipes-graphics/imx-gpu-viv/imx-gpu-viv.inc#n220 ... >> The biggest challenge here is how to express KERNEL_FEATURES which are >> recipe/provider specific. >> >> We have some providers: >> >> linux-fslc >> linux-imx >> linux-<vendor> >> >> and each can provide different kernel features. I agree with the long >> term plan but I didn't yet came up with something which scales and >> work. > > > I'll reiterate my thoughts - it's not only the kernel features. All the > parts in the system need to consider a feature, before it's built: > - hardware > - kernel > - userspace > > A feature shouldn't be compiled and/or deployed in the image unless all > the system parts confirm its support, otherwise we'll have a failed > build or runtime issues. > > With my current limited knowledge I see 2 basic paths for implementing > this: > - 1 shared variable per feature, which is mangled across the > recipes/layers (the usual enable/disable dance); > - mechanism similar to COMBINED_FEATURES, which needs to "AND" 2 or > more sets of variables across the system. This is already done > implicitly in lots of places with heavy usage of $base_contains, but > it's not easy to read and explicit. > > // board.conf > MACHINE_FEATURES += "opengl" > > // kernel provider > KERNEL_FEATURES += "opengl" > > // image or recipe should check features indirectly > XXXXXXX_append = "${base_contains('COMBINED_FEATURES', 'opengl', > 'gst-plugins-gl', '', d)} > > Something like this... The biggest challenge here is how to express KERNEL_FEATURES which are recipe/provider specific. We have some providers: linux-fslc linux-imx linux-<vendor> and each can provide different kernel features. We will need to come up with a solution to export the KERNEL_FEATURES outside of recipe namespace and make it in a clean and easy to maintain way. This is the part of puzzle still not in place. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [meta-fsl-arm-extra][PATCH v3] riotboard: Fix broken image builds against linux-fslc 2015-04-30 15:49 [meta-fsl-arm-extra][PATCH v3] riotboard: Fix broken image builds against linux-fslc Nikolay Dimitrov 2015-04-30 15:49 ` [meta-fsl-demos][PATCH] " Nikolay Dimitrov @ 2015-05-11 16:42 ` Nikolay Dimitrov 1 sibling, 0 replies; 16+ messages in thread From: Nikolay Dimitrov @ 2015-05-11 16:42 UTC (permalink / raw) To: Otavio Salvador, Fabio Estevam; +Cc: meta-freescale Ping. On 04/30/2015 06:49 PM, Nikolay Dimitrov wrote: > Several Yocto images fail to build because they're using packages that require > imx6-specific hardware support (ASRC, VPU, GPU3D), which is not available in > the mainline kernel. This patch fixes the following image builds: > - core-image-minimal > - core-image-base > - fsl-image-multimedia > - fsl-image-multimedia-full > - fsl-image-machine-test > > Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg> > --- > conf/machine/imx6dl-riotboard.conf | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/conf/machine/imx6dl-riotboard.conf b/conf/machine/imx6dl-riotboard.conf > index b611ffb..bf50eaf 100644 > --- a/conf/machine/imx6dl-riotboard.conf > +++ b/conf/machine/imx6dl-riotboard.conf > @@ -15,3 +15,8 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-fslc" > KERNEL_DEVICETREE = "imx6dl-riotboard.dtb" > > SERIAL_CONSOLE = "115200 ttymxc1" > + > +# FIXME: Workaround for building against linux-fslc > +MACHINE_EXTRA_RRECOMMENDS_remove = "fsl-alsa-plugins" > +PREFERRED_VERSION_imx-test = "00.00.00" > +MACHINE_GSTREAMER_PLUGIN = "" > ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2015-05-13 11:06 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-04-30 15:49 [meta-fsl-arm-extra][PATCH v3] riotboard: Fix broken image builds against linux-fslc Nikolay Dimitrov 2015-04-30 15:49 ` [meta-fsl-demos][PATCH] " Nikolay Dimitrov 2015-05-04 12:41 ` Fabio Estevam 2015-05-04 13:33 ` Nikolay Dimitrov 2015-05-04 17:06 ` Daiane Angolini 2015-05-04 17:12 ` Gary Thomas 2015-05-04 19:38 ` Nikolay Dimitrov 2015-05-11 16:43 ` Nikolay Dimitrov 2015-05-11 17:09 ` Otavio Salvador 2015-05-11 17:24 ` Nikolay Dimitrov 2015-05-11 17:46 ` Otavio Salvador 2015-05-11 23:42 ` Nikolay Dimitrov 2015-05-12 12:41 ` Otavio Salvador 2015-05-13 4:09 ` Nikolay Dimitrov 2015-05-13 11:06 ` Otavio Salvador 2015-05-11 16:42 ` [meta-fsl-arm-extra][PATCH v3] " Nikolay Dimitrov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.