From: Stephen Boyd <sboyd@codeaurora.org> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: "Kevin Hilman" <khilman@kernel.org>, "Heiko Stübner" <heiko@sntech.de>, "Mike Turquette" <mturquette@linaro.org>, "Doug Anderson" <dianders@chromium.org>, linux-clk@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Boris Brezillon" <boris.brezillon@free-electrons.com>, "Alex Elder" <elder@linaro.org>, "Alexandre Belloni" <alexandre.belloni@free-electrons.com>, "Stephen Warren" <swarren@wwwdotorg.org>, "Max Filippov" <jcmvbkbc@gmail.com>, "Sascha Hauer" <kernel@pengutronix.de>, "Zhangfei Gao" <zhangfei.gao@linaro.org>, "Santosh Shilimkar" <ssantosh@kernel.org>, "Chao Xie" <chao.xie@marvell.com>, "Jason Cooper" <jason@lakedaemon.net>, "Stefan Wahren" <stefan.wahren@i2se.com>, "Andrew Bresticker" <abrestic@chromium.org>, "Robert Jarzmik" <robert.jarzmik@free.fr>, "Georgi Djakov" <georgi.djakov@linaro.org>, "Sylwester Nawrocki" <s.nawrocki@samsung.com>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Barry Song" <baohua@kernel.org>, "Dinh Nguyen" <dinguyen@opensource.altera.com>, "Viresh Kumar" <viresh.linux@gmail.com>, "Gabriel FERNANDEZ" <gabriel.fernandez@st.com>, "Emilio López" <emilio@elopez.com.ar>, "Peter De Sc hrijver" <pdeschrijver@nvidia.com>, "Tero Kristo" <t-kristo@ti.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Pawel Moll" <pawel.moll@arm.com>, "Michal Simek" <michal.simek@xilinx.com>, "Olof Johansson" <olof@lixom.net>, "Tyler Baker" <tyler.baker@linaro.org> Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks Date: Tue, 12 May 2015 15:35:50 -0700 [thread overview] Message-ID: <55528046.4030107@codeaurora.org> (raw) In-Reply-To: <20150508100247.GQ11057@lukather> On 05/08/15 03:02, Maxime Ripard wrote: > On Thu, May 07, 2015 at 02:03:57PM -0700, Stephen Boyd wrote: >> On 05/07/15 08:17, Kevin Hilman wrote: >>> On Fri, May 1, 2015 at 4:40 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: >>>> On 05/01/15 15:07, Heiko Stübner wrote: >>>>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd: >>>>> >>>>>>> Instead I guess we could hook it less deep into clk_get_sys, like in the >>>>>>> following patch? >>>>>> It looks like it will work at least, but still I'd prefer to keep the >>>>>> orphan check contained to clk.c. How about this compile tested only patch? >>>>> I gave this a spin on my rk3288-firefly board. It still boots, the clock tree >>>>> looks the same and it also still defers nicely in the scenario I needed it >>>>> for. The implementation also looks nice - and of course much more compact than >>>>> my check in two places :-) . I don't know if you want to put this as follow-up >>>>> on top or fold it into the original orphan-check, so in any case >>>>> >>>>> Tested-by: Heiko Stuebner <heiko@sntech.de> >>>>> Reviewed-by: Heiko Stuebner <heiko@sntech.de> >>>> Thanks. I'm leaning towards tossing your patch 2/2 and replacing it with >>>> my patch and a note that it's based on an earlier patch from you. >>> It appears this has landed in linux-next in the form of 882667c1fcf1 >>> clk: prevent orphan clocks from being used. A bunch of boot failures >>> for sunxi in today's linux-next[1] were bisected down to that patch. >>> >>> I confirmed that reverting that commit on top of next/master gets >>> sunxi booting again. >>> >>> >> Thanks for the report. I've removed the two clk orphan patches from >> clk-next. Would it be possible to try with next-20150507 and >> clk_ignore_unused on the command line? > This makes it work, but it's not really an option. > Hmm.. I thought it didn't fix it for Kevin. Confused. >> Also we can try to see if critical clocks aren't being forced on by >> applying this patch and looking for clk_get() failures > And that shows that the CPU and DDR clocks are not protected, which > obviously is pretty mad. > > I've mass converted all our probing code to use OF_CLK_DECLARE, and > make things work again. > > http://code.bulix.org/5goa5j-88345?raw > > Is this an acceptable solution? > > We were already moving to this, I'm not really fond of doing this like > that, but I guess this whole debacle makes it necessary. > I wonder why we can't switch out the clk_ops on the affected platforms + clocks to be read-only (at least for the enable/disable part)? That would fix it just the same right? I wasn't around for the original discussion regarding this always-on stuff so perhaps I've missed something. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/2] clk: improve handling of orphan clocks Date: Tue, 12 May 2015 15:35:50 -0700 [thread overview] Message-ID: <55528046.4030107@codeaurora.org> (raw) In-Reply-To: <20150508100247.GQ11057@lukather> On 05/08/15 03:02, Maxime Ripard wrote: > On Thu, May 07, 2015 at 02:03:57PM -0700, Stephen Boyd wrote: >> On 05/07/15 08:17, Kevin Hilman wrote: >>> On Fri, May 1, 2015 at 4:40 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: >>>> On 05/01/15 15:07, Heiko St?bner wrote: >>>>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd: >>>>> >>>>>>> Instead I guess we could hook it less deep into clk_get_sys, like in the >>>>>>> following patch? >>>>>> It looks like it will work at least, but still I'd prefer to keep the >>>>>> orphan check contained to clk.c. How about this compile tested only patch? >>>>> I gave this a spin on my rk3288-firefly board. It still boots, the clock tree >>>>> looks the same and it also still defers nicely in the scenario I needed it >>>>> for. The implementation also looks nice - and of course much more compact than >>>>> my check in two places :-) . I don't know if you want to put this as follow-up >>>>> on top or fold it into the original orphan-check, so in any case >>>>> >>>>> Tested-by: Heiko Stuebner <heiko@sntech.de> >>>>> Reviewed-by: Heiko Stuebner <heiko@sntech.de> >>>> Thanks. I'm leaning towards tossing your patch 2/2 and replacing it with >>>> my patch and a note that it's based on an earlier patch from you. >>> It appears this has landed in linux-next in the form of 882667c1fcf1 >>> clk: prevent orphan clocks from being used. A bunch of boot failures >>> for sunxi in today's linux-next[1] were bisected down to that patch. >>> >>> I confirmed that reverting that commit on top of next/master gets >>> sunxi booting again. >>> >>> >> Thanks for the report. I've removed the two clk orphan patches from >> clk-next. Would it be possible to try with next-20150507 and >> clk_ignore_unused on the command line? > This makes it work, but it's not really an option. > Hmm.. I thought it didn't fix it for Kevin. Confused. >> Also we can try to see if critical clocks aren't being forced on by >> applying this patch and looking for clk_get() failures > And that shows that the CPU and DDR clocks are not protected, which > obviously is pretty mad. > > I've mass converted all our probing code to use OF_CLK_DECLARE, and > make things work again. > > http://code.bulix.org/5goa5j-88345?raw > > Is this an acceptable solution? > > We were already moving to this, I'm not really fond of doing this like > that, but I guess this whole debacle makes it necessary. > I wonder why we can't switch out the clk_ops on the affected platforms + clocks to be read-only (at least for the enable/disable part)? That would fix it just the same right? I wasn't around for the original discussion regarding this always-on stuff so perhaps I've missed something. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-12 22:36 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-22 20:53 [PATCH v3 0/2] clk: improve handling of orphan clocks Heiko Stuebner 2015-04-22 20:53 ` Heiko Stuebner 2015-04-22 20:53 ` [PATCH v3 1/2] clk: track the orphan status of clocks and their children Heiko Stuebner 2015-04-22 20:53 ` Heiko Stuebner 2015-04-30 23:20 ` Stephen Boyd 2015-04-30 23:20 ` Stephen Boyd 2015-04-22 20:53 ` [PATCH v3 2/2] clk: prevent orphan clocks from being used Heiko Stuebner 2015-04-22 20:53 ` Heiko Stuebner 2015-04-30 23:20 ` Stephen Boyd 2015-04-30 23:20 ` Stephen Boyd 2015-04-25 12:23 ` [PATCH v3 0/2] clk: improve handling of orphan clocks Stefan Wahren 2015-04-25 12:23 ` Stefan Wahren 2015-04-25 13:44 ` Heiko Stübner 2015-04-25 13:44 ` Heiko Stübner 2015-04-26 19:58 ` Robert Jarzmik 2015-04-26 19:58 ` Robert Jarzmik 2015-04-26 19:58 ` Robert Jarzmik 2015-05-01 0:19 ` Stephen Boyd 2015-05-01 0:19 ` Stephen Boyd 2015-05-01 19:59 ` Heiko Stübner 2015-05-01 19:59 ` Heiko Stübner 2015-05-01 20:52 ` Stephen Boyd 2015-05-01 20:52 ` Stephen Boyd 2015-05-01 22:07 ` Heiko Stübner 2015-05-01 22:07 ` Heiko Stübner 2015-05-01 23:40 ` Stephen Boyd 2015-05-01 23:40 ` Stephen Boyd 2015-05-07 8:22 ` Tero Kristo 2015-05-07 8:22 ` Tero Kristo 2015-05-07 18:18 ` Stephen Boyd 2015-05-07 18:18 ` Stephen Boyd 2015-05-08 11:41 ` Tero Kristo 2015-05-08 11:41 ` Tero Kristo 2015-05-07 15:17 ` Kevin Hilman 2015-05-07 15:17 ` Kevin Hilman 2015-05-07 15:17 ` Kevin Hilman 2015-05-07 21:03 ` Stephen Boyd 2015-05-07 21:03 ` Stephen Boyd 2015-05-08 0:27 ` Kevin Hilman 2015-05-08 0:27 ` Kevin Hilman 2015-05-08 0:27 ` Kevin Hilman 2015-05-08 6:53 ` Stephen Boyd 2015-05-08 6:53 ` Stephen Boyd 2015-05-08 8:13 ` Sascha Hauer 2015-05-08 8:13 ` Sascha Hauer 2015-05-08 9:30 ` Heiko Stübner 2015-05-08 9:30 ` Heiko Stübner 2015-05-08 9:53 ` Sascha Hauer 2015-05-08 9:53 ` Sascha Hauer 2015-05-08 10:02 ` Maxime Ripard 2015-05-08 10:02 ` Maxime Ripard 2015-05-12 22:35 ` Stephen Boyd [this message] 2015-05-12 22:35 ` Stephen Boyd 2015-05-13 13:03 ` Maxime Ripard 2015-05-13 13:03 ` Maxime Ripard 2015-05-13 14:33 ` Kevin Hilman 2015-05-13 14:33 ` Kevin Hilman 2015-05-13 14:33 ` Kevin Hilman 2015-05-13 20:14 ` Maxime Ripard 2015-05-13 20:14 ` Maxime Ripard 2015-05-13 20:44 ` Kevin Hilman 2015-05-13 20:44 ` Kevin Hilman 2015-05-13 20:44 ` Kevin Hilman 2015-05-13 20:51 ` Maxime Ripard 2015-05-13 20:51 ` Maxime Ripard 2015-07-27 8:57 ` Heiko Stübner 2015-07-27 8:57 ` Heiko Stübner 2015-07-30 10:09 ` Maxime Ripard 2015-07-30 10:09 ` Maxime Ripard 2015-08-11 22:34 ` Stephen Boyd 2015-08-11 22:34 ` Stephen Boyd 2015-08-12 8:26 ` Heiko Stübner 2015-08-12 8:26 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55528046.4030107@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=abrestic@chromium.org \ --cc=alexandre.belloni@free-electrons.com \ --cc=baohua@kernel.org \ --cc=boris.brezillon@free-electrons.com \ --cc=chao.xie@marvell.com \ --cc=dianders@chromium.org \ --cc=dinguyen@opensource.altera.com \ --cc=elder@linaro.org \ --cc=emilio@elopez.com.ar \ --cc=gabriel.fernandez@st.com \ --cc=geert+renesas@glider.be \ --cc=georgi.djakov@linaro.org \ --cc=heiko@sntech.de \ --cc=jason@lakedaemon.net \ --cc=jcmvbkbc@gmail.com \ --cc=kernel@pengutronix.de \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=michal.simek@xilinx.com \ --cc=mturquette@linaro.org \ --cc=olof@lixom.net \ --cc=pawel.moll@arm.com \ --cc=pdeschrijver@nvidia.com \ --cc=robert.jarzmik@free.fr \ --cc=s.nawrocki@samsung.com \ --cc=ssantosh@kernel.org \ --cc=stefan.wahren@i2se.com \ --cc=swarren@wwwdotorg.org \ --cc=t-kristo@ti.com \ --cc=tyler.baker@linaro.org \ --cc=ulf.hansson@linaro.org \ --cc=viresh.linux@gmail.com \ --cc=zhangfei.gao@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.