* [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias
@ 2015-05-14 0:32 Javier Martinez Canillas
2015-05-14 0:37 ` Krzysztof Kozlowski
2015-05-21 8:20 ` Thierry Reding
0 siblings, 2 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-05-14 0:32 UTC (permalink / raw)
To: Thierry Reding
Cc: Krzysztof Kozlowski, Olof Johansson, Doug Anderson,
linux-samsung-soc, linux-kernel, linux-pwm,
Javier Martinez Canillas
If the pwm-samsung driver is built as a module, modalias information is
not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
macro to export the OF device ID so the module contains that information.
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
drivers/pwm/pwm-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index ff201e1b9219..ada2d326dc3e 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -456,6 +456,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
{ .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
{},
};
+MODULE_DEVICE_TABLE(of, samsung_pwm_matches);
static int pwm_samsung_parse_dt(struct samsung_pwm_chip *chip)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias
2015-05-14 0:32 [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias Javier Martinez Canillas
@ 2015-05-14 0:37 ` Krzysztof Kozlowski
2015-05-14 0:47 ` Javier Martinez Canillas
2015-05-21 8:13 ` Javier Martinez Canillas
2015-05-21 8:20 ` Thierry Reding
1 sibling, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-14 0:37 UTC (permalink / raw)
To: Javier Martinez Canillas, Thierry Reding
Cc: Olof Johansson, Doug Anderson, linux-samsung-soc, linux-kernel,
linux-pwm
On 14.05.2015 09:32, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
I think many other Maxim/S[25]M drivers for Samsung boards may also be
affected... Probably they should also be updated.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias
2015-05-14 0:37 ` Krzysztof Kozlowski
@ 2015-05-14 0:47 ` Javier Martinez Canillas
2015-05-21 8:13 ` Javier Martinez Canillas
1 sibling, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-05-14 0:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thierry Reding
Cc: Olof Johansson, Doug Anderson, linux-samsung-soc, linux-kernel,
linux-pwm
Hello Krzysztof,
On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> I think many other Maxim/S[25]M drivers for Samsung boards may also be
> affected... Probably they should also be updated.
>
Yeah, I detected these since I'm preparing a series to reduce the delta
between exynos_defconfig and multi_v7_defconfig. And found these issues
since current multi_v7 policy is to build as much as possible as a module.
I think is unfortunate how many drivers are not providing proper module
aliases information and so building them as a module is less useful since
user-space can't associate the module with the modalias uevents to autoload.
Anyway, I'll take a look for other drivers and see if I can post similar
patches but now at least all the peripherals in the Exynos5 Chromebooks
are working when their drivers are built as a module.
> Best regards,
> Krzysztof
>
Best regards,
Javier
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias
2015-05-14 0:37 ` Krzysztof Kozlowski
2015-05-14 0:47 ` Javier Martinez Canillas
@ 2015-05-21 8:13 ` Javier Martinez Canillas
1 sibling, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2015-05-21 8:13 UTC (permalink / raw)
To: Thierry Reding
Cc: Krzysztof Kozlowski, Olof Johansson, Doug Anderson,
linux-samsung-soc, linux-kernel, linux-pwm
Hello Thierry,
On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
>
Any comments on this patch?
Best regards,
Javier
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias
2015-05-14 0:32 [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias Javier Martinez Canillas
2015-05-14 0:37 ` Krzysztof Kozlowski
@ 2015-05-21 8:20 ` Thierry Reding
1 sibling, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2015-05-21 8:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Krzysztof Kozlowski, Olof Johansson, Doug Anderson,
linux-samsung-soc, linux-kernel, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Thu, May 14, 2015 at 02:32:31AM +0200, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> drivers/pwm/pwm-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-21 8:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-14 0:32 [PATCH] pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias Javier Martinez Canillas
2015-05-14 0:37 ` Krzysztof Kozlowski
2015-05-14 0:47 ` Javier Martinez Canillas
2015-05-21 8:13 ` Javier Martinez Canillas
2015-05-21 8:20 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.