From: Leon Alrae <leon.alrae@imgtec.com>
To: Richard Henderson <rth@twiddle.net>,
Yongbok Kim <yongbok.kim@imgtec.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA
Date: Thu, 14 May 2015 10:50:42 +0100 [thread overview]
Message-ID: <55546FF2.1030405@imgtec.com> (raw)
In-Reply-To: <5553A5C4.6030902@twiddle.net>
On 13/05/2015 20:28, Richard Henderson wrote:
> As an aside, consider moving away from
>
> #define HELPER_LD(name, insn, type) \
> static inline type do_##name(CPUMIPSState *env, target_ulong addr, \
> int mem_idx) \
> { \
> switch (mem_idx) \
> { \
> case 0: return (type) cpu_##insn##_kernel(env, addr); break; \
> case 1: return (type) cpu_##insn##_super(env, addr); break; \
> default: \
> case 2: return (type) cpu_##insn##_user(env, addr); break; \
> } \
> }
>
> to using helper_ret_*_mmu directly. Which allows you to specify the mmu_idx
> directly rather than bouncing around different thunks. It also allows you to
> pass in GETRA(), which would allow these helpers to use cpu_restore_state on
> faults.
Just to confirm -– before using helper_ret_*_mmu directly we should also
check if we can take fast-path (not sure if “fast-path” is correct term
in this case as we've already generated a call to helper function...):
if (unlikely(env->tlb_table[mmu_idx][page_index].ADDR_READ !=
(addr & (TARGET_PAGE_MASK | (DATA_SIZE - 1))))) {
So basically we'll have similar functions to cpu_##insn##_* but allowing
to pass mmu_idx, GETRA() and calling helper_ret_*_mmu directly.
BTW what is the reason that we aren't passing GETRA() to cpu_##insn##_*
and using helper_ret_*_mmu directly in general?
Thanks,
Leon
next prev parent reply other threads:[~2015-05-14 10:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:37 [Qemu-devel] [PATCH v3 0/2] target-mips: Add support for misaligned accesses Yongbok Kim
2015-05-13 15:37 ` [Qemu-devel] [PATCH v3 1/2] target-mips: Misaligned memory accesses for R6 Yongbok Kim
2015-05-13 15:37 ` [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA Yongbok Kim
2015-05-13 19:28 ` Richard Henderson
2015-05-13 19:56 ` Maciej W. Rozycki
2015-05-13 19:58 ` Richard Henderson
2015-05-13 20:59 ` Leon Alrae
2015-05-13 21:21 ` Maciej W. Rozycki
2015-05-13 21:36 ` Richard Henderson
2015-05-13 22:54 ` Maciej W. Rozycki
2015-05-14 8:51 ` Leon Alrae
2015-05-14 11:22 ` Maciej W. Rozycki
2015-05-13 21:31 ` Richard Henderson
2015-05-14 9:00 ` Yongbok Kim
2015-05-14 9:46 ` Yongbok Kim
2015-05-14 18:44 ` Richard Henderson
2015-05-14 9:50 ` Leon Alrae [this message]
2015-05-14 15:27 ` Richard Henderson
2015-05-14 19:12 ` Richard Henderson
2015-05-15 12:09 ` Leon Alrae
2015-05-15 13:43 ` Richard Henderson
2015-05-15 14:04 ` Leon Alrae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55546FF2.1030405@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=yongbok.kim@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.