* Re: [PATCH v2 0/9] Porting the intel_pstate driver to Xen
@ 2015-05-15 6:50 Wang, Wei W
2015-05-15 7:17 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Wang, Wei W @ 2015-05-15 6:50 UTC (permalink / raw)
To: Wang, Wei W, jbeulich, andrew.cooper3, jinsong.liu, wei.liu2,
ian.campbell, xen-devel, Zhang, Yang Z
Hi Jan,
> On 28/04/2015 16:37, Wei Wang wrote
> > Changes:
> > *NO.1 The intel_pstate driver can be controlled via two ways:
> > A. min_perf_pct and max_perf_pct
> > The user directly adjusts min_perf_pct and max_perf_pct to get what
> > they want. For example, if min_perf_pct=max_perf_pct=60%, then the
> > user is asking for something similar to a userspace governor with
> > setting the requested performance=60%.
> > B. set-scaling-governor
> > This one is functionally redundant, since A. can achieve all the
> > governor functions. It is remained to give people time to get
> > familiar with method A.
> > Users can choose from the four governors: Powersave, Ondemand,
> > Powersave, Performance. The driver achieves the functionality of
> > the selected governor via adjusting the min_perf_pct and max_perf_pct
> > itself.
> >
> > *NO.2 The xenpm "get-cpufreq-para" displays the following things:
> > cpu id : 10
> > affected_cpus : 10
> > cpuinfo frequency : max [3700000] min [1200000] cur [1400000]
> > scaling_driver : intel_pstate
> > scaling_avail_gov : performance powersave userspace ondemand
> > current_governor : ondemand
> > max_perf_pct : 100
> > min_perf_pct : 32
> > turbo_pct : 54
> > turbo mode : enabled
> >
> > *NO.3 Changed "intel_pstate=disable" to "intel_pstate=enable".
> > If "intel_pstate=enable" is added, but the CPU does not support the
> > intel_pstate driver, the old P-state driver (acpi-cpufreq) will be loaded.
> >
> > *NO.4 Moved the declarations under xen/include/acpi to an x86-specific
> > header.
> >
> > ** Basic Description **
> > This patch series ports the intel_pstate driver from the Linux kernel to Xen.
> > The intel_pstate driver is used to tune P states for SandyBridge+
> processors.
> > It needs to be enabled by adding "intel_pstate=enable" to the booting
> > parameter list.
> >
> > The intel_pstate.c file under xen/arch/x86/acpi/cpufreq/ contains all
> > the logic for selecting the current P-state. It follows its
> > implementation in the kernel. In order to better support future Intel
> > CPUs (e.g. the HWP feature on
> > Skylake+), intel_pstate changes to tune P-state based on percentage
> values.
> >
> > The xenpm tool is also upgraded to support the intel_pstate driver. If
> > intel_pstate is used, "get-cpufreq-para" displays percentage value
> > based feedback. If the intel_pstate driver is not enabled, xenpm will
> > work in the old style.
> >
> >
> > Wei Wang (9):
> > x86/acpi: add a common interface for x86 cpu matching
> > x86/intel_pstate: add some calculation related support
> > x86/cpu_hotplug: add the unregister_cpu_notifier function to support
> > CPU hotplug
> > x86/intel_pstate: add new policy fields and a new driver interface
> > x86/intel_pstate: relocate the driver register/unregister function
> > x86/intel_pstate: the main boby of the intel_pstate driver
> > x86/intel_pstate: add a booting param to select the driver to load
> > x86/intel_pstate: support the use of intel_pstate in pmstat.c
> > x86/intel_pstate: enable xenpm to control the intel_pstate driver
> >
> > tools/libxc/include/xenctrl.h | 14 +-
> > tools/libxc/xc_pm.c | 17 +-
> > tools/misc/xenpm.c | 104 +++-
> > xen/arch/x86/acpi/cpufreq/Makefile | 1 +
> > xen/arch/x86/acpi/cpufreq/cpufreq.c | 9 +-
> > xen/arch/x86/acpi/cpufreq/intel_pstate.c | 869
> > +++++++++++++++++++++++++++++++
> > xen/arch/x86/cpu/common.c | 39 ++
> > xen/arch/x86/cpu/mwait-idle.c | 30 +-
> > xen/common/cpu.c | 7 +
> > xen/drivers/acpi/pmstat.c | 106 +++-
> > xen/drivers/cpufreq/cpufreq.c | 27 +-
> > xen/drivers/cpufreq/utility.c | 5 +
> > xen/include/acpi/cpufreq/cpufreq.h | 45 +-
> > xen/include/asm-x86/acpi.h | 4 +
> > xen/include/asm-x86/cpufeature.h | 1 +
> > xen/include/asm-x86/div64.h | 68 +++
> > xen/include/asm-x86/msr-index.h | 3 +
> > xen/include/asm-x86/processor.h | 10 +
> > xen/include/public/sysctl.h | 16 +-
> > xen/include/xen/cpu.h | 1 +
> > xen/include/xen/kernel.h | 30 ++
> > 21 files changed, 1300 insertions(+), 106 deletions(-) create mode
> > 100644 xen/arch/x86/acpi/cpufreq/intel_pstate.c
> >
> > --
> > 1.9.1
Do you have any comments on this version?
Best,
Wei
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/9] Porting the intel_pstate driver to Xen
2015-05-15 6:50 [PATCH v2 0/9] Porting the intel_pstate driver to Xen Wang, Wei W
@ 2015-05-15 7:17 ` Jan Beulich
2015-05-15 7:46 ` Wang, Wei W
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2015-05-15 7:17 UTC (permalink / raw)
To: Wei W Wang
Cc: wei.liu2, ian.campbell, jinsong.liu, xen-devel, andrew.cooper3,
Yang Z Zhang
>>> On 15.05.15 at 08:50, <wei.w.wang@intel.com> wrote:
> Hi Jan,
>
>> On 28/04/2015 16:37, Wei Wang wrote
This looks wrong - the mail you seem to reply to is dated May 13th
in my inbox. While I realize that I never got to reply to the v1
series (which may indeed have been around the date quoted above)
pinging a patch series after just two days is not appropriate.
> Do you have any comments on this version?
Eventually I will. But as recently noted elsewhere, there are way
too many things needing review right now, and I've got things
other than reviews to do, and as long as others (read: people not
already doing a fair share of reviewing work) aren't helping with
reviews, getting to deal with series like this will take time.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/9] Porting the intel_pstate driver to Xen
2015-05-15 7:17 ` Jan Beulich
@ 2015-05-15 7:46 ` Wang, Wei W
2015-05-18 11:18 ` George Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Wang, Wei W @ 2015-05-15 7:46 UTC (permalink / raw)
To: Jan Beulich
Cc: wei.liu2, ian.campbell, jinsong.liu, xen-devel, andrew.cooper3,
Zhang, Yang Z
On 15/05/2015 15:17, Jan Beulich wrote
> >>> On 15.05.15 at 08:50, <wei.w.wang@intel.com> wrote:
> > Hi Jan,
> >
> >> On 28/04/2015 16:37, Wei Wang wrote
>
> This looks wrong - the mail you seem to reply to is dated May 13th in my
> inbox. While I realize that I never got to reply to the v1 series (which may
> indeed have been around the date quoted above) pinging a patch series
> after just two days is not appropriate.
The date/time on that machine was not correct, sorry about that. I have fixed it.
>
> > Do you have any comments on this version?
>
> Eventually I will. But as recently noted elsewhere, there are way too many
> things needing review right now, and I've got things other than reviews to do,
> and as long as others (read: people not already doing a fair share of
> reviewing work) aren't helping with reviews, getting to deal with series like
> this will take time.
OK. Understand it.
Hopefully, we can have both intel_pstate and the following HWP driver (will send it out when intel_pstate is ready) show up in the new version of Xen.
Best,
Wei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/9] Porting the intel_pstate driver to Xen
2015-05-15 7:46 ` Wang, Wei W
@ 2015-05-18 11:18 ` George Dunlap
2015-05-19 1:04 ` Wang, Wei W
0 siblings, 1 reply; 6+ messages in thread
From: George Dunlap @ 2015-05-18 11:18 UTC (permalink / raw)
To: Wang, Wei W
Cc: wei.liu2, ian.campbell, jinsong.liu, xen-devel, Jan Beulich,
andrew.cooper3, Zhang, Yang Z
On Fri, May 15, 2015 at 8:46 AM, Wang, Wei W <wei.w.wang@intel.com> wrote:
>> > Do you have any comments on this version?
>>
>> Eventually I will. But as recently noted elsewhere, there are way too many
>> things needing review right now, and I've got things other than reviews to do,
>> and as long as others (read: people not already doing a fair share of
>> reviewing work) aren't helping with reviews, getting to deal with series like
>> this will take time.
>
> OK. Understand it.
> Hopefully, we can have both intel_pstate and the following HWP driver (will send it out when intel_pstate is ready) show up in the new version of Xen.
I think what Jan was hinting at was that perhaps you could review some
of the other Intel patch series, and get their authors to review
yours. There are currently what, 5 or 6 outstanding series from
Intel? If each of you reviewed at least one other series, that would
be a big improvement and a good start towards building up reviewing
skills, so that everything wasn't blocked on reviews from Jan.
-George
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/9] Porting the intel_pstate driver to Xen
2015-05-18 11:18 ` George Dunlap
@ 2015-05-19 1:04 ` Wang, Wei W
0 siblings, 0 replies; 6+ messages in thread
From: Wang, Wei W @ 2015-05-19 1:04 UTC (permalink / raw)
To: George Dunlap, jinsong.liu
Cc: wei.liu2, ian.campbell, andrew.cooper3, xen-devel, Jan Beulich,
Zhang, Yang Z
On 18/05/2015 19:18, George Dunlap wrote
> On Fri, May 15, 2015 at 8:46 AM, Wang, Wei W <wei.w.wang@intel.com>
> wrote:
> >> > Do you have any comments on this version?
> >>
> >> Eventually I will. But as recently noted elsewhere, there are way too
> >> many things needing review right now, and I've got things other than
> >> reviews to do, and as long as others (read: people not already doing
> >> a fair share of reviewing work) aren't helping with reviews, getting
> >> to deal with series like this will take time.
> >
> > OK. Understand it.
> > Hopefully, we can have both intel_pstate and the following HWP driver
> (will send it out when intel_pstate is ready) show up in the new version of
> Xen.
>
Hi Jinsong,
Can you please help to review the patch series? Thanks a lot.
> I think what Jan was hinting at was that perhaps you could review some of
> the other Intel patch series, and get their authors to review yours. There are
> currently what, 5 or 6 outstanding series from Intel? If each of you reviewed
> at least one other series, that would be a big improvement and a good start
> towards building up reviewing skills, so that everything wasn't blocked on
> reviews from Jan.
>
Thanks George. Jinsong is the x86 acpi maintainer, and he is probably more familiar with this work. It would be great if he could offer some help here.
Best,
Wei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/9] Porting the intel_pstate driver to Xen
[not found] <1463128431-786-1-git-send-email-wei.w.wang@intel.com>
@ 2015-05-13 8:47 ` Wang, Wei W
0 siblings, 0 replies; 6+ messages in thread
From: Wang, Wei W @ 2015-05-13 8:47 UTC (permalink / raw)
To: jbeulich, andrew.cooper3, jinsong.liu, wei.liu2, ian.campbell,
xen-devel, Zhang, Yang Z
Appologies if you received multiple emails of this patch. Just couldn't see it showing up in the mailinglist.
Best,
Wei
On 28/04/2015 16:37, Wei Wang wrote
> Changes:
> *NO.1 The intel_pstate driver can be controlled via two ways:
> A. min_perf_pct and max_perf_pct
> The user directly adjusts min_perf_pct and max_perf_pct to get what
> they want. For example, if min_perf_pct=max_perf_pct=60%, then the
> user is asking for something similar to a userspace governor with
> setting the requested performance=60%.
> B. set-scaling-governor
> This one is functionally redundant, since A. can achieve all the
> governor functions. It is remained to give people time to get
> familiar with method A.
> Users can choose from the four governors: Powersave, Ondemand,
> Powersave, Performance. The driver achieves the functionality of
> the selected governor via adjusting the min_perf_pct and max_perf_pct
> itself.
>
> *NO.2 The xenpm "get-cpufreq-para" displays the following things:
> cpu id : 10
> affected_cpus : 10
> cpuinfo frequency : max [3700000] min [1200000] cur [1400000]
> scaling_driver : intel_pstate
> scaling_avail_gov : performance powersave userspace ondemand
> current_governor : ondemand
> max_perf_pct : 100
> min_perf_pct : 32
> turbo_pct : 54
> turbo mode : enabled
>
> *NO.3 Changed "intel_pstate=disable" to "intel_pstate=enable".
> If "intel_pstate=enable" is added, but the CPU does not support the
> intel_pstate driver, the old P-state driver (acpi-cpufreq) will be loaded.
>
> *NO.4 Moved the declarations under xen/include/acpi to an x86-specific
> header.
>
> ** Basic Description **
> This patch series ports the intel_pstate driver from the Linux kernel to Xen.
> The intel_pstate driver is used to tune P states for SandyBridge+ processors.
> It needs to be enabled by adding "intel_pstate=enable" to the booting
> parameter list.
>
> The intel_pstate.c file under xen/arch/x86/acpi/cpufreq/ contains all the
> logic for selecting the current P-state. It follows its implementation in the
> kernel. In order to better support future Intel CPUs (e.g. the HWP feature on
> Skylake+), intel_pstate changes to tune P-state based on percentage values.
>
> The xenpm tool is also upgraded to support the intel_pstate driver. If
> intel_pstate is used, "get-cpufreq-para" displays percentage value based
> feedback. If the intel_pstate driver is not enabled, xenpm will work in the old
> style.
>
>
> Wei Wang (9):
> x86/acpi: add a common interface for x86 cpu matching
> x86/intel_pstate: add some calculation related support
> x86/cpu_hotplug: add the unregister_cpu_notifier function to support
> CPU hotplug
> x86/intel_pstate: add new policy fields and a new driver interface
> x86/intel_pstate: relocate the driver register/unregister function
> x86/intel_pstate: the main boby of the intel_pstate driver
> x86/intel_pstate: add a booting param to select the driver to load
> x86/intel_pstate: support the use of intel_pstate in pmstat.c
> x86/intel_pstate: enable xenpm to control the intel_pstate driver
>
> tools/libxc/include/xenctrl.h | 14 +-
> tools/libxc/xc_pm.c | 17 +-
> tools/misc/xenpm.c | 104 +++-
> xen/arch/x86/acpi/cpufreq/Makefile | 1 +
> xen/arch/x86/acpi/cpufreq/cpufreq.c | 9 +-
> xen/arch/x86/acpi/cpufreq/intel_pstate.c | 869
> +++++++++++++++++++++++++++++++
> xen/arch/x86/cpu/common.c | 39 ++
> xen/arch/x86/cpu/mwait-idle.c | 30 +-
> xen/common/cpu.c | 7 +
> xen/drivers/acpi/pmstat.c | 106 +++-
> xen/drivers/cpufreq/cpufreq.c | 27 +-
> xen/drivers/cpufreq/utility.c | 5 +
> xen/include/acpi/cpufreq/cpufreq.h | 45 +-
> xen/include/asm-x86/acpi.h | 4 +
> xen/include/asm-x86/cpufeature.h | 1 +
> xen/include/asm-x86/div64.h | 68 +++
> xen/include/asm-x86/msr-index.h | 3 +
> xen/include/asm-x86/processor.h | 10 +
> xen/include/public/sysctl.h | 16 +-
> xen/include/xen/cpu.h | 1 +
> xen/include/xen/kernel.h | 30 ++
> 21 files changed, 1300 insertions(+), 106 deletions(-) create mode 100644
> xen/arch/x86/acpi/cpufreq/intel_pstate.c
>
> --
> 1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-19 1:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 6:50 [PATCH v2 0/9] Porting the intel_pstate driver to Xen Wang, Wei W
2015-05-15 7:17 ` Jan Beulich
2015-05-15 7:46 ` Wang, Wei W
2015-05-18 11:18 ` George Dunlap
2015-05-19 1:04 ` Wang, Wei W
[not found] <1463128431-786-1-git-send-email-wei.w.wang@intel.com>
2015-05-13 8:47 ` Wang, Wei W
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.