All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs
@ 2015-05-18 12:57 ` Colin King
  0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2015-05-18 12:57 UTC (permalink / raw)
  To: Will Deacon, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
	Arnaldo Carvalho de Melo, Russell King, linux-arm-kernel
  Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
missing interrupt-affinity property for PPIs") introduced a memory
leak of irqs on the "Don't bother with PPIs" return path. This issue
was picked up by static analysis by cppcheck:

[arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs

Instead, perform allocation of irqs after getting the irq hence
removing need to clean up an allocation on the PPI affine return path.

Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing interrupt-affinity property for PPIs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/arm/kernel/perf_event_cpu.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c
index 213919b..a7099ee 100644
--- a/arch/arm/kernel/perf_event_cpu.c
+++ b/arch/arm/kernel/perf_event_cpu.c
@@ -303,17 +303,17 @@ static int probe_current_pmu(struct arm_pmu *pmu)
 
 static int of_pmu_irq_cfg(struct platform_device *pdev)
 {
-	int i, irq;
-	int *irqs = kcalloc(pdev->num_resources, sizeof(*irqs), GFP_KERNEL);
-
-	if (!irqs)
-		return -ENOMEM;
+	int i, irq, *irqs;
 
 	/* Don't bother with PPIs; they're already affine */
 	irq = platform_get_irq(pdev, 0);
 	if (irq >= 0 && irq_is_percpu(irq))
 		return 0;
 
+	irqs = kcalloc(pdev->num_resources, sizeof(*irqs), GFP_KERNEL);
+	if (!irqs)
+		return -ENOMEM;
+
 	for (i = 0; i < pdev->num_resources; ++i) {
 		struct device_node *dn;
 		int cpu;
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs
@ 2015-05-18 12:57 ` Colin King
  0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2015-05-18 12:57 UTC (permalink / raw)
  To: linux-arm-kernel

From: Colin Ian King <colin.king@canonical.com>

Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
missing interrupt-affinity property for PPIs") introduced a memory
leak of irqs on the "Don't bother with PPIs" return path. This issue
was picked up by static analysis by cppcheck:

[arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs

Instead, perform allocation of irqs after getting the irq hence
removing need to clean up an allocation on the PPI affine return path.

Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing interrupt-affinity property for PPIs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/arm/kernel/perf_event_cpu.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c
index 213919b..a7099ee 100644
--- a/arch/arm/kernel/perf_event_cpu.c
+++ b/arch/arm/kernel/perf_event_cpu.c
@@ -303,17 +303,17 @@ static int probe_current_pmu(struct arm_pmu *pmu)
 
 static int of_pmu_irq_cfg(struct platform_device *pdev)
 {
-	int i, irq;
-	int *irqs = kcalloc(pdev->num_resources, sizeof(*irqs), GFP_KERNEL);
-
-	if (!irqs)
-		return -ENOMEM;
+	int i, irq, *irqs;
 
 	/* Don't bother with PPIs; they're already affine */
 	irq = platform_get_irq(pdev, 0);
 	if (irq >= 0 && irq_is_percpu(irq))
 		return 0;
 
+	irqs = kcalloc(pdev->num_resources, sizeof(*irqs), GFP_KERNEL);
+	if (!irqs)
+		return -ENOMEM;
+
 	for (i = 0; i < pdev->num_resources; ++i) {
 		struct device_node *dn;
 		int cpu;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs
  2015-05-18 13:27   ` Sudeep Holla
@ 2015-05-18 13:26     ` Colin Ian King
  -1 siblings, 0 replies; 6+ messages in thread
From: Colin Ian King @ 2015-05-18 13:26 UTC (permalink / raw)
  To: Sudeep Holla, linux-arm-kernel
  Cc: Will Deacon, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
	Arnaldo Carvalho de Melo, Russell King, linux-kernel

On 18/05/15 14:27, Sudeep Holla wrote:
> 
> 
> On 18/05/15 13:57, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
>> missing interrupt-affinity property for PPIs") introduced a memory
>> leak of irqs on the "Don't bother with PPIs" return path. This issue
>> was picked up by static analysis by cppcheck:
>>
>> [arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs
>>
>> Instead, perform allocation of irqs after getting the irq hence
>> removing need to clean up an allocation on the PPI affine return path.
>>
>> Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing
>> interrupt-affinity property for PPIs")
> 
> Will Deacon has similar patch[1] in Russell's patch tracker(8357/1)
> 
> Regards,
> Sudeep

OK, sorry for the dup and noise.

> 
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342367.html
> [2] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8357/1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs
@ 2015-05-18 13:26     ` Colin Ian King
  0 siblings, 0 replies; 6+ messages in thread
From: Colin Ian King @ 2015-05-18 13:26 UTC (permalink / raw)
  To: linux-arm-kernel

On 18/05/15 14:27, Sudeep Holla wrote:
> 
> 
> On 18/05/15 13:57, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
>> missing interrupt-affinity property for PPIs") introduced a memory
>> leak of irqs on the "Don't bother with PPIs" return path. This issue
>> was picked up by static analysis by cppcheck:
>>
>> [arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs
>>
>> Instead, perform allocation of irqs after getting the irq hence
>> removing need to clean up an allocation on the PPI affine return path.
>>
>> Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing
>> interrupt-affinity property for PPIs")
> 
> Will Deacon has similar patch[1] in Russell's patch tracker(8357/1)
> 
> Regards,
> Sudeep

OK, sorry for the dup and noise.

> 
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342367.html
> [2] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8357/1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs
  2015-05-18 12:57 ` Colin King
@ 2015-05-18 13:27   ` Sudeep Holla
  -1 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2015-05-18 13:27 UTC (permalink / raw)
  To: Colin King, linux-arm-kernel
  Cc: Will Deacon, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
	Arnaldo Carvalho de Melo, Russell King, Sudeep Holla,
	linux-kernel



On 18/05/15 13:57, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
> missing interrupt-affinity property for PPIs") introduced a memory
> leak of irqs on the "Don't bother with PPIs" return path. This issue
> was picked up by static analysis by cppcheck:
>
> [arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs
>
> Instead, perform allocation of irqs after getting the irq hence
> removing need to clean up an allocation on the PPI affine return path.
>
> Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing interrupt-affinity property for PPIs")

Will Deacon has similar patch[1] in Russell's patch tracker(8357/1)

Regards,
Sudeep

[1] 
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342367.html
[2] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8357/1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs
@ 2015-05-18 13:27   ` Sudeep Holla
  0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2015-05-18 13:27 UTC (permalink / raw)
  To: linux-arm-kernel



On 18/05/15 13:57, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Recent commit 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about
> missing interrupt-affinity property for PPIs") introduced a memory
> leak of irqs on the "Don't bother with PPIs" return path. This issue
> was picked up by static analysis by cppcheck:
>
> [arch/arm/kernel/perf_event_cpu.c:315]: (error) Memory leak: irqs
>
> Instead, perform allocation of irqs after getting the irq hence
> removing need to clean up an allocation on the PPI affine return path.
>
> Fixes: 338d9dd3e2ae ("ARM: 8351/1: perf: don't warn about missing interrupt-affinity property for PPIs")

Will Deacon has similar patch[1] in Russell's patch tracker(8357/1)

Regards,
Sudeep

[1] 
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342367.html
[2] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8357/1

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-18 13:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-18 12:57 [PATCH][V3] ARM: pmu: fix memory leak due to early return not freeing irqs Colin King
2015-05-18 12:57 ` Colin King
2015-05-18 13:27 ` Sudeep Holla
2015-05-18 13:27   ` Sudeep Holla
2015-05-18 13:26   ` Colin Ian King
2015-05-18 13:26     ` Colin Ian King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.