All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement
@ 2015-05-20 13:10 Andrew Cooper
  2015-05-20 13:12 ` Julien Grall
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Andrew Cooper @ 2015-05-20 13:10 UTC (permalink / raw)
  To: Xen-devel
  Cc: Keir Fraser, Ian Campbell, Andrew Cooper, Tim Deegan, Don Slutz,
	Julien Grall, Stefano Stabellini, Jan Beulich

This structure is used by XEN_DOMCTL_createdomain, and is liable to be
modified going forwards.  Explicitly state that it falls under the
XEN_DOMCTL_INTERFACE_VERSION.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Stefano Stabellini <stefano.stabellini@citrix.com>
CC: Tim Deegan <tim@xen.org>
CC: Julien Grall <julien.grall@citrix.com>
CC: Don Slutz <dslutz@verizon.com>
---
 xen/include/public/arch-arm.h     |    4 ++++
 xen/include/public/arch-x86/xen.h |    4 ++++
 2 files changed, 8 insertions(+)

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index c029e0f..6e38638 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -309,6 +309,10 @@ struct arch_shared_info {
 typedef struct arch_shared_info arch_shared_info_t;
 typedef uint64_t xen_callback_t;
 
+/*
+ * struct xen_arch_domainconfig's ABI is covered by the
+ * XEN_DOMCTL_INTERFACE_VERSION.
+ */
 #define XEN_DOMCTL_CONFIG_GIC_DEFAULT   0
 #define XEN_DOMCTL_CONFIG_GIC_V2        1
 #define XEN_DOMCTL_CONFIG_GIC_V3        2
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index cea3fe7..b4ba233 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -262,6 +262,10 @@ struct arch_shared_info {
 };
 typedef struct arch_shared_info arch_shared_info_t;
 
+/*
+ * struct xen_arch_domainconfig's ABI is covered by the
+ * XEN_DOMCTL_INTERFACE_VERSION.
+ */
 struct xen_arch_domainconfig {
     char dummy;
 };
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement
  2015-05-20 13:10 [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement Andrew Cooper
@ 2015-05-20 13:12 ` Julien Grall
  2015-05-20 14:12 ` Don Slutz
  2015-05-21  7:13 ` [PATCH] public: restrict xen_arch_domainconfig visibility Jan Beulich
  2 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2015-05-20 13:12 UTC (permalink / raw)
  To: Andrew Cooper, Xen-devel
  Cc: Keir Fraser, Ian Campbell, Tim Deegan, Don Slutz, Julien Grall,
	Stefano Stabellini, Jan Beulich

Hi Andrew,

On 20/05/15 14:10, Andrew Cooper wrote:
> This structure is used by XEN_DOMCTL_createdomain, and is liable to be
> modified going forwards.  Explicitly state that it falls under the
> XEN_DOMCTL_INTERFACE_VERSION.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Julien Grall <julien.grall@citrix.com>
> CC: Don Slutz <dslutz@verizon.com>

Reviewed-by: Julien Grall <julien.grall@citrix.com>

Regards,

-- 
Julien Grall

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement
  2015-05-20 13:10 [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement Andrew Cooper
  2015-05-20 13:12 ` Julien Grall
@ 2015-05-20 14:12 ` Don Slutz
  2015-05-21  7:13 ` [PATCH] public: restrict xen_arch_domainconfig visibility Jan Beulich
  2 siblings, 0 replies; 6+ messages in thread
From: Don Slutz @ 2015-05-20 14:12 UTC (permalink / raw)
  To: Andrew Cooper, Xen-devel
  Cc: Keir Fraser, Ian Campbell, Tim Deegan, Julien Grall,
	Stefano Stabellini, Jan Beulich

On 05/20/15 09:10, Andrew Cooper wrote:
> This structure is used by XEN_DOMCTL_createdomain, and is liable to be
> modified going forwards.  Explicitly state that it falls under the
> XEN_DOMCTL_INTERFACE_VERSION.
> 

Looks good to me.

Reviewed-by: Don Slutz <dslutz@verizon.com>

   -Don Slutz

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Julien Grall <julien.grall@citrix.com>
> CC: Don Slutz <dslutz@verizon.com>
> ---
>  xen/include/public/arch-arm.h     |    4 ++++
>  xen/include/public/arch-x86/xen.h |    4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index c029e0f..6e38638 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -309,6 +309,10 @@ struct arch_shared_info {
>  typedef struct arch_shared_info arch_shared_info_t;
>  typedef uint64_t xen_callback_t;
>  
> +/*
> + * struct xen_arch_domainconfig's ABI is covered by the
> + * XEN_DOMCTL_INTERFACE_VERSION.
> + */
>  #define XEN_DOMCTL_CONFIG_GIC_DEFAULT   0
>  #define XEN_DOMCTL_CONFIG_GIC_V2        1
>  #define XEN_DOMCTL_CONFIG_GIC_V3        2
> diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
> index cea3fe7..b4ba233 100644
> --- a/xen/include/public/arch-x86/xen.h
> +++ b/xen/include/public/arch-x86/xen.h
> @@ -262,6 +262,10 @@ struct arch_shared_info {
>  };
>  typedef struct arch_shared_info arch_shared_info_t;
>  
> +/*
> + * struct xen_arch_domainconfig's ABI is covered by the
> + * XEN_DOMCTL_INTERFACE_VERSION.
> + */
>  struct xen_arch_domainconfig {
>      char dummy;
>  };
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] public: restrict xen_arch_domainconfig visibility
  2015-05-20 13:10 [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement Andrew Cooper
  2015-05-20 13:12 ` Julien Grall
  2015-05-20 14:12 ` Don Slutz
@ 2015-05-21  7:13 ` Jan Beulich
  2015-05-21  8:25   ` Ian Campbell
  2015-05-21  8:34   ` Andrew Cooper
  2 siblings, 2 replies; 6+ messages in thread
From: Jan Beulich @ 2015-05-21  7:13 UTC (permalink / raw)
  To: Xen-devel
  Cc: Andrew Cooper, Keir Fraser, Ian Jackson, Ian Campbell, Tim Deegan

>>> On 20.05.15 at 15:10, <andrew.cooper3@citrix.com> wrote:
As an extension to 931f5777c7 ("public: clarify xen_arch_domainconfig
ABI statement") limit the respective definitions' visibility to
hypervisor and tools.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -298,7 +298,21 @@ struct vcpu_guest_context {
 };
 typedef struct vcpu_guest_context vcpu_guest_context_t;
 DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
-#endif
+
+/*
+ * struct xen_arch_domainconfig's ABI is covered by
+ * XEN_DOMCTL_INTERFACE_VERSION.
+ */
+#define XEN_DOMCTL_CONFIG_GIC_DEFAULT   0
+#define XEN_DOMCTL_CONFIG_GIC_V2        1
+#define XEN_DOMCTL_CONFIG_GIC_V3        2
+struct xen_arch_domainconfig {
+    /* IN/OUT */
+    uint8_t gic_version;
+    /* IN */
+    uint32_t nr_spis;
+};
+#endif /* __XEN__ || __XEN_TOOLS__ */
 
 struct arch_vcpu_info {
 };
@@ -309,20 +323,6 @@ struct arch_shared_info {
 typedef struct arch_shared_info arch_shared_info_t;
 typedef uint64_t xen_callback_t;
 
-/*
- * struct xen_arch_domainconfig's ABI is covered by
- * XEN_DOMCTL_INTERFACE_VERSION.
- */
-#define XEN_DOMCTL_CONFIG_GIC_DEFAULT   0
-#define XEN_DOMCTL_CONFIG_GIC_V2        1
-#define XEN_DOMCTL_CONFIG_GIC_V3        2
-struct xen_arch_domainconfig {
-    /* IN/OUT */
-    uint8_t gic_version;
-    /* IN */
-    uint32_t nr_spis;
-};
-
 #endif
 
 #if defined(__XEN__) || defined(__XEN_TOOLS__)
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -262,6 +262,7 @@ struct arch_shared_info {
 };
 typedef struct arch_shared_info arch_shared_info_t;
 
+#if defined(__XEN__) || defined(__XEN_TOOLS__)
 /*
  * struct xen_arch_domainconfig's ABI is covered by
  * XEN_DOMCTL_INTERFACE_VERSION.
@@ -269,6 +270,7 @@ typedef struct arch_shared_
 struct xen_arch_domainconfig {
     char dummy;
 };
+#endif
 
 #endif /* !__ASSEMBLY__ */

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] public: restrict xen_arch_domainconfig visibility
  2015-05-21  7:13 ` [PATCH] public: restrict xen_arch_domainconfig visibility Jan Beulich
@ 2015-05-21  8:25   ` Ian Campbell
  2015-05-21  8:34   ` Andrew Cooper
  1 sibling, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-05-21  8:25 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Andrew Cooper, Tim Deegan, Keir Fraser, Ian Jackson, Xen-devel

On Thu, 2015-05-21 at 08:13 +0100, Jan Beulich wrote:
> >>> On 20.05.15 at 15:10, <andrew.cooper3@citrix.com> wrote:
> As an extension to 931f5777c7 ("public: clarify xen_arch_domainconfig
> ABI statement") limit the respective definitions' visibility to
> hypervisor and tools.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] public: restrict xen_arch_domainconfig visibility
  2015-05-21  7:13 ` [PATCH] public: restrict xen_arch_domainconfig visibility Jan Beulich
  2015-05-21  8:25   ` Ian Campbell
@ 2015-05-21  8:34   ` Andrew Cooper
  1 sibling, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2015-05-21  8:34 UTC (permalink / raw)
  To: Jan Beulich, Xen-devel; +Cc: Keir Fraser, Ian Jackson, Ian Campbell, Tim Deegan

On 21/05/2015 08:13, Jan Beulich wrote:
>>>> On 20.05.15 at 15:10, <andrew.cooper3@citrix.com> wrote:
> As an extension to 931f5777c7 ("public: clarify xen_arch_domainconfig
> ABI statement") limit the respective definitions' visibility to
> hypervisor and tools.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Ah yes - I should have considered this when doing my patch.  Sorry.

~Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-21  8:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-20 13:10 [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement Andrew Cooper
2015-05-20 13:12 ` Julien Grall
2015-05-20 14:12 ` Don Slutz
2015-05-21  7:13 ` [PATCH] public: restrict xen_arch_domainconfig visibility Jan Beulich
2015-05-21  8:25   ` Ian Campbell
2015-05-21  8:34   ` Andrew Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.