* [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs
@ 2015-05-22 19:19 Nikolay Dimitrov
2015-05-22 19:28 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Dimitrov @ 2015-05-22 19:19 UTC (permalink / raw)
To: u-boot
Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
---
include/configs/mx6sabre_common.h | 7 ++++++-
include/configs/mx6sabresd.h | 6 ++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index b72522b..86745ac 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -121,6 +121,10 @@
#define EMMC_ENV ""
#endif
+#ifndef VIDEO_ARGS
+#define VIDEO_ARGS ""
+#endif
+
#define CONFIG_EXTRA_ENV_SETTINGS \
"script=boot.scr\0" \
"image=zImage\0" \
@@ -149,7 +153,8 @@
"fi\0" \
EMMC_ENV \
"mmcargs=setenv bootargs console=${console},${baudrate} " \
- "root=${mmcroot}\0" \
+ "root=${mmcroot} " \
+ VIDEO_ARGS "\0" \
"loadbootscript=" \
"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
"bootscript=echo Running bootscript from mmc ...; " \
diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
index dab2fd2..1bd4912 100644
--- a/include/configs/mx6sabresd.h
+++ b/include/configs/mx6sabresd.h
@@ -31,6 +31,12 @@
#define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */
+#define VIDEO_ARGS "video=mxcfb0:dev=hdmi,1280x720M at 60,if=RGB24 " \
+ "video=mxcfb1:off " \
+ "video=mxcfb2:off " \
+ "video=mxcfb3:off " \
+ "fbmem=28M"
+
#include "mx6sabre_common.h"
#define CONFIG_SYS_FSL_USDHC_NUM 3
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs
2015-05-22 19:19 [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs Nikolay Dimitrov
@ 2015-05-22 19:28 ` Fabio Estevam
2015-05-22 22:19 ` Nikolay Dimitrov
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2015-05-22 19:28 UTC (permalink / raw)
To: u-boot
Hi Nikolay,
On Fri, May 22, 2015 at 4:19 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> +#define VIDEO_ARGS "video=mxcfb0:dev=hdmi,1280x720M at 60,if=RGB24 " \
> + "video=mxcfb1:off " \
> + "video=mxcfb2:off " \
> + "video=mxcfb3:off " \
> + "fbmem=28M"
> +
This is too specific to the FSL kernel. For mainline kernel users,
this is not needed and the strings would be different.
I would suggest you to patch this in Yocto instead.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs
2015-05-22 19:28 ` Fabio Estevam
@ 2015-05-22 22:19 ` Nikolay Dimitrov
2015-05-22 22:25 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Dimitrov @ 2015-05-22 22:19 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 05/22/2015 10:28 PM, Fabio Estevam wrote:
> Hi Nikolay,
>
> On Fri, May 22, 2015 at 4:19 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> +#define VIDEO_ARGS "video=mxcfb0:dev=hdmi,1280x720M at 60,if=RGB24 " \
>> + "video=mxcfb1:off " \
>> + "video=mxcfb2:off " \
>> + "video=mxcfb3:off " \
>> + "fbmem=28M"
>> +
>
> This is too specific to the FSL kernel. For mainline kernel users,
> this is not needed and the strings would be different.
>
> I would suggest you to patch this in Yocto instead.
Thanks for your comments. I was thinking about what's the best way to
approach this need, and last time we discussed similar topic, I was
asked about upstreaming my changes... so here I am doing it.
Fixing it in u-boot-fslc or as a ad-hoc patch will also work for me.
Still - isn't the mainline kernel user expected to be able to use the
HDMI interface of the board?
Regards,
Nikolay
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs
2015-05-22 22:19 ` Nikolay Dimitrov
@ 2015-05-22 22:25 ` Fabio Estevam
2015-05-23 2:10 ` Nikolay Dimitrov
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2015-05-22 22:25 UTC (permalink / raw)
To: u-boot
Hi Nikolay,
On Fri, May 22, 2015 at 7:19 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> Still - isn't the mainline kernel user expected to be able to use the
> HDMI interface of the board?
Yes, and it works by default. No need to pass 'video=' arguments.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs
2015-05-22 22:25 ` Fabio Estevam
@ 2015-05-23 2:10 ` Nikolay Dimitrov
0 siblings, 0 replies; 5+ messages in thread
From: Nikolay Dimitrov @ 2015-05-23 2:10 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 05/23/2015 01:25 AM, Fabio Estevam wrote:
> Hi Nikolay,
>
> On Fri, May 22, 2015 at 7:19 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> Still - isn't the mainline kernel user expected to be able to use the
>> HDMI interface of the board?
>
> Yes, and it works by default. No need to pass 'video=' arguments.
I was just able to test it on Debian 8 armhf, and I can confirm it
works.
@Stefano: Please discard my patch.
Kind regards,
Nikolay
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-23 2:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-22 19:19 [U-Boot] [PATCH] mx6sabresd: Enable HDMI video in bootargs Nikolay Dimitrov
2015-05-22 19:28 ` Fabio Estevam
2015-05-22 22:19 ` Nikolay Dimitrov
2015-05-22 22:25 ` Fabio Estevam
2015-05-23 2:10 ` Nikolay Dimitrov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.