[target:for-next 53/60] drivers/target/target_core_device.c:652:6: sparse: symbol 'se_dev_check_wce' was not declared. Should it be static?

[target:for-next 53/60] drivers/target/target_core_device.c:652:6: sparse: symbol 'se_dev_check_wce' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
head:   9cfc3ea41c4f9db514a7fdde9b77657b5aeaa46c
commit: 9c10e8080d9ac17ec5b0b9f7da1a5dd31215ef5e [53/60] target: simplify backend attribute implementation
reproduce:
  # apt-get install sparse
  git checkout 9c10e8080d9ac17ec5b0b9f7da1a5dd31215ef5e
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/target/target_core_device.c:249:38: sparse: incorrect type in initializer (different address spaces)
   drivers/target/target_core_device.c:249:38:    expected struct se_lun *lun
   drivers/target/target_core_device.c:249:38:    got struct se_lun [noderef] <asn:4>*_________p1
   drivers/target/target_core_device.c:339:43: sparse: incorrect type in initializer (different address spaces)
   drivers/target/target_core_device.c:339:43:    expected struct se_lun *orig_lun
   drivers/target/target_core_device.c:339:43:    got struct se_lun [noderef] <asn:4>*_________p1
   drivers/target/target_core_device.c:445:50: sparse: incorrect type in initializer (different address spaces)
   drivers/target/target_core_device.c:445:50:    expected struct se_lun *tmp_lun
   drivers/target/target_core_device.c:445:50:    got struct se_lun [noderef] <asn:4>*_________p1
>> drivers/target/target_core_device.c:652:6: sparse: symbol 'se_dev_check_wce' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH target] target: se_dev_check_wce() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 target_core_device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 2321884..1d309ad 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -649,7 +649,7 @@ static u32 se_dev_align_max_sectors(u32 max_sectors, u32 block_size)
 	return aligned_max_sectors;
 }
 
-bool se_dev_check_wce(struct se_device *dev)
+static bool se_dev_check_wce(struct se_device *dev)
 {
 	bool wce = false;
 

Re: [PATCH target] target: se_dev_check_wce() can be static

[Bart Van Assche]

On 05/26/15 10:13, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   target_core_device.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2321884..1d309ad 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -649,7 +649,7 @@ static u32 se_dev_align_max_sectors(u32 max_sectors, u32 block_size)
>   	return aligned_max_sectors;
>   }
>
> -bool se_dev_check_wce(struct se_device *dev)
> +static bool se_dev_check_wce(struct se_device *dev)
>   {
>   	bool wce = false;
>

Since patch "target: fix DPO and FUA bit checks" removed the last user 
of this function, please remove this function completely instead of 
declaring it static.

Thanks,

Bart.

Re: [PATCH target] target: se_dev_check_wce() can be static

[Bart Van Assche]

On 05/26/15 10:13, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   target_core_device.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2321884..1d309ad 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -649,7 +649,7 @@ static u32 se_dev_align_max_sectors(u32 max_sectors, u32 block_size)
>   	return aligned_max_sectors;
>   }
>
> -bool se_dev_check_wce(struct se_device *dev)
> +static bool se_dev_check_wce(struct se_device *dev)
>   {
>   	bool wce = false;
>

Since patch "target: fix DPO and FUA bit checks" removed the last user 
of this function, please remove this function completely instead of 
declaring it static.

Thanks,

Bart.